You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Bhathiya <no...@github.com> on 2014/08/24 18:51:54 UTC
[jclouds-labs-google] JCLOUDS-458:Added Object Access Controls with
live tests (#42)
You can merge this Pull Request by running:
git pull https://github.com/hsbhathiya/jclouds-labs-google objectAcl_3
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-google/pull/42
-- Commit Summary --
* JCLOUDS-458:Added Object Access Controls live tests
-- File Changes --
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/GoogleCloudStorageApi.java (8)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/BucketAccessControls.java (3)
A google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/ListObjectAccessControls.java (113)
A google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/ObjectAccessControls.java (208)
A google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/ObjectAccessControlsTemplate.java (65)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/internal/ProjectTeam.java (26)
A google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/features/ObjectAccessControlsApi.java (365)
M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/handlers/GoogleCloudStorageErrorHandler.java (10)
A google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/handlers/ObjectAccessControlsBinder.java (43)
A google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/BucketAccessControlsApiLiveTest.java (113)
A google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/ObjectAccessControlsApiExpectTest.java (282)
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/BucketAclListTest.java (2)
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/DefaultObjectAclGetTest.java (2)
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/DefaultObjectAclListTest.java (2)
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/FullBucketGetTest.java (2)
A google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/ObjectaclGetTest.java (54)
A google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/ObjectaclInsertTest.java (49)
A google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/ObjectaclListTest.java (55)
A google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/ObjectaclUpdateTest.java (44)
A google-cloud-storage/src/test/resources/objectacl_get.json (15)
A google-cloud-storage/src/test/resources/objectacl_insert_requestpayload.json (4)
A google-cloud-storage/src/test/resources/objectacl_insert_response.json (10)
A google-cloud-storage/src/test/resources/objectacl_list.json (18)
A google-cloud-storage/src/test/resources/objectacl_request_payload.json (4)
A google-cloud-storage/src/test/resources/objectacl_update_initial.json (9)
A google-cloud-storage/src/test/resources/objectacl_update_response.json (9)
-- Patch Links --
https://github.com/jclouds/jclouds-labs-google/pull/42.patch
https://github.com/jclouds/jclouds-labs-google/pull/42.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/42
Re: [jclouds-labs-google] JCLOUDS-458:Added Object Access Controls
with live tests (#42)
Posted by Bhathiya <no...@github.com>.
> @@ -46,17 +46,17 @@ public static Team fromValue(String team) {
> }
> }
>
> - private final String projectId;
> + private final String projectNumber;
In practice this is a long value.But API define it as a string.
https://developers.google.com/storage/docs/json_api/v1/defaultObjectAccessControls
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/42/files#r16663707
Re: [jclouds-labs-google] JCLOUDS-458:Added Object Access Controls
with live tests (#42)
Posted by Andrew Gaul <no...@github.com>.
@hsbhathiya This mostly looks good, although please address the comments and include the test from #43 in this pull request. Thank you for your patience with this old commit; I know it is frustrating to modify code which subsequent commits depend on but this process will result in higher-quality code. I believe we can move faster on subsequent commits and I will spend substantial time reviewing and testing GCS this week.
@demobox Any comments on this pull request?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/42#issuecomment-53215479
Re: [jclouds-labs-google] JCLOUDS-458:Added Object Access Controls
with live tests (#42)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #128](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/128/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/42#issuecomment-53295436
Re: [jclouds-labs-google] JCLOUDS-458:Added Object Access Controls
with live tests (#42)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1279](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1279/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/42#issuecomment-53296137
Re: [jclouds-labs-google] JCLOUDS-458:Added Object Access Controls
with live tests (#42)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #126](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/126/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/42#issuecomment-53249551
Re: [jclouds-labs-google] JCLOUDS-458:Added Object Access Controls
with live tests (#42)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1274](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1274/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/42#issuecomment-53199518
Re: [jclouds-labs-google] JCLOUDS-458:Added Object Access Controls
with live tests (#42)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #124](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/124/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/42#issuecomment-53199516
Re: [jclouds-labs-google] JCLOUDS-458:Added Object Access Controls
with live tests (#42)
Posted by Andrew Gaul <no...@github.com>.
Closed #42.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/42#event-156989344
Re: [jclouds-labs-google] JCLOUDS-458:Added Object Access Controls
with live tests (#42)
Posted by Andrew Gaul <no...@github.com>.
I reworded the commit message, removed some trailing whitespace, tested locally, and pushed to master as 38e05f6cdf33b5e42d893dd35fbf5717a2cd9213.
Thank you for your patience @hsbhathiya and I look forward to subsequent commits!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/42#issuecomment-53332279
Re: [jclouds-labs-google] JCLOUDS-458:Added Object Access Controls
with live tests (#42)
Posted by Andrew Gaul <no...@github.com>.
> @@ -46,17 +46,17 @@ public static Team fromValue(String team) {
> }
> }
>
> - private final String projectId;
> + private final String projectNumber;
If this is a project *number*, should it be a `Long` instead of a `String`?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/42/files#r16639004
Re: [jclouds-labs-google] JCLOUDS-458:Added Object Access Controls
with live tests (#42)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #127](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/127/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/42#issuecomment-53250794
Re: [jclouds-labs-google] JCLOUDS-458:Added Object Access Controls
with live tests (#42)
Posted by Andrew Gaul <no...@github.com>.
> @@ -46,17 +46,17 @@ public static Team fromValue(String team) {
> }
> }
>
> - private final String projectId;
> + private final String projectNumber;
Thanks for explaining!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/42/files#r16666102
Re: [jclouds-labs-google] JCLOUDS-458:Added Object Access Controls
with live tests (#42)
Posted by Andrew Gaul <no...@github.com>.
> + * See the License for the specific language governing permissions and
> + * limitations under the License.
> + */
> +
> +package org.jclouds.googlecloudstorage.features;
> +
> +import static org.jclouds.googlecloudstorage.reference.GoogleCloudStorageConstants.STORAGE_FULLCONTROL_SCOPE;
> +import static org.testng.Assert.assertEquals;
> +import static org.testng.AssertJUnit.assertNull;
> +
> +import javax.ws.rs.core.MediaType;
> +
> +import org.jclouds.googlecloudstorage.domain.DomainResourceRefferences.ObjectRole;
> +import org.jclouds.googlecloudstorage.domain.ObjectAccessControlsTemplate;
> +import org.jclouds.googlecloudstorage.internal.BaseGoogleCloudStorageApiExpectTest;
> +import org.jclouds.googlecloudstorage.parse.ObjectaclGetTest;
Can you reformat these in camel case as `ObjectAclGetTest`? For the constants below, this would be GET_OBJECT_ACL_REQUEST.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/42/files#r16639001
Re: [jclouds-labs-google] JCLOUDS-458:Added Object Access Controls
with live tests (#42)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1277](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1277/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/42#issuecomment-53251028