You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Hoss Man (JIRA)" <ji...@apache.org> on 2017/05/26 16:52:04 UTC
[jira] [Updated] (SOLR-10755) delete/refactor (most) solrj
deprecations on master
[ https://issues.apache.org/jira/browse/SOLR-10755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man updated SOLR-10755:
----------------------------
Attachment: SOLR-10755.patch
Most of the *classes* in solrj that involve deprecations are fairly straight forward to delete/refactor the affected code, with occasional tweaking of tests that were still using these methods -- that's what's in this patch, the low haning fruit.
still running precommig & want to do a few more test runs to sanity check
----
Things not included in this patch that should be tracked in their own jiras (i'll spin off where needed)...
* CollectionAdminRequest
** has roughly double the number of deprecations of all other solrj classes combined
** many of the deprecated methods/constructors are still used in a lot of places in tests
** in many cases the non-deprecated "constructor" versions aren't validating the same way the deprecated setters do
** in at least one case i see obvious bugs in the non-deprecated methods (see ForceLeader constructors)
** once many of these deprecated setters are removed, a lot of member variables should become final
* ClusterState
** punted on that since we also have SOLR-9321
* ZkStateReader
** deprecated updateClusterState() is Still used by Overseer
*** is the Overseer usage a mistake? should Overseer be doing something else?
** no obviously easy way to refactor this method it into Overseer w/o making several private ZkStateReader methods public
** if Overseer usage is "ok" perhaps we should just rename this method something more dangerous sounding and mark lucene.internal ?
> delete/refactor (most) solrj deprecations on master
> ---------------------------------------------------
>
> Key: SOLR-10755
> URL: https://issues.apache.org/jira/browse/SOLR-10755
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Hoss Man
> Assignee: Hoss Man
> Priority: Blocker
> Fix For: master (7.0)
>
> Attachments: SOLR-10755.patch, SOLR-10755.patch
>
>
> using this issue to track some work i've done to cleanup deprecations in solrj for master (7.0)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org