You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by "Billy Liu (JIRA)" <ji...@apache.org> on 2018/01/25 11:45:00 UTC
[jira] [Updated] (KYLIN-3087) Fix the DistributedLock release bug
in GlobalDictionaryBuilder
[ https://issues.apache.org/jira/browse/KYLIN-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Billy Liu updated KYLIN-3087:
-----------------------------
Summary: Fix the DistributedLock release bug in GlobalDictionaryBuilder (was: DistributedLock in GlobalDictionaryBuilder may not release)
> Fix the DistributedLock release bug in GlobalDictionaryBuilder
> --------------------------------------------------------------
>
> Key: KYLIN-3087
> URL: https://issues.apache.org/jira/browse/KYLIN-3087
> Project: Kylin
> Issue Type: Bug
> Components: Job Engine
> Affects Versions: v2.2.0
> Reporter: Fangyuan Deng
> Assignee: Fangyuan Deng
> Priority: Major
> Fix For: v2.3.0
>
> Attachments: KYLIN-3087.1.patch, KYLIN-3087.patch
>
>
> In GlobalDictionaryBuilder.init(),
> this.builder = new AppendTrieDictionaryBuilder(baseDir, maxEntriesPerSlice, true);
> if this line has exception, the DistributedLock will not release, and other jobs can not run.
> so,I added a try catch.
> try {
> this.builder = new AppendTrieDictionaryBuilder(baseDir, maxEntriesPerSlice, true);
> } catch (Throwable e) {
> lock.unlock(getLockPath(sourceColumn));
> throw new RuntimeException(String.format("Failed to create global dictionary on %s ", sourceColumn), e);
> }
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)