You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uniffle.apache.org by "crain-cn (via GitHub)" <gi...@apache.org> on 2023/02/22 11:20:23 UTC
[GitHub] [incubator-uniffle] crain-cn opened a new issue, #645: [Improvement] feat(operator): Support for custom initialization parameters.
crain-cn opened a new issue, #645:
URL: https://github.com/apache/incubator-uniffle/issues/645
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
### Search before asking
- [X] I have searched in the [issues](https://github.com/apache/incubator-uniffle/issues?q=is%3Aissue) and found no similar issues.
### What would you like to be improved?
I want to support the InitFlags method in main.go, which can modify the Options setting of the Manager to customize many properties.
### How should we improve?
We should add an InitFlags method in main.go, and then use flag package to set default parameters to accept command-line arguments. This allows users to customize various startup parameters and configurations easily.
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] crain-cn commented on issue #645: [Improvement] feat(operator): Support for custom initialization parameters.
Posted by "crain-cn (via GitHub)" <gi...@apache.org>.
crain-cn commented on issue #645:
URL: https://github.com/apache/incubator-uniffle/issues/645#issuecomment-1447839178
>
> > > From the issue description, I don't quite get what you want to archive. The main.go for controller and webhook already handles flag parsing.
> > > But you are always welcome to submit a PR, and let's discuss there.
> >
> >
> > Only the parameters in Config are configured, and parameters in ctrl.Options such as SyncPeriod, Namespace, and RetryPeriod cannot be modified.
>
> I see. SGTM.
Submitted. #670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] zuston commented on issue #645: [Improvement] feat(operator): Support for custom initialization parameters.
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on issue #645:
URL: https://github.com/apache/incubator-uniffle/issues/645#issuecomment-1445588333
PTAL @advancedxy @wangao1236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on issue #645: [Improvement] feat(operator): Support for custom initialization parameters.
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on issue #645:
URL: https://github.com/apache/incubator-uniffle/issues/645#issuecomment-1445827403
Form the issue description, I don't quite get what you want to archive. The main.go for controller and webhook already handles flag parsing.
But you are always welcome to submit a PR, and let's discuss there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] crain-cn commented on issue #645: [Improvement] feat(operator): Support for custom initialization parameters.
Posted by "crain-cn (via GitHub)" <gi...@apache.org>.
crain-cn commented on issue #645:
URL: https://github.com/apache/incubator-uniffle/issues/645#issuecomment-1445910043
> From the issue description, I don't quite get what you want to archive. The main.go for controller and webhook already handles flag parsing.
>
> But you are always welcome to submit a PR, and let's discuss there.
Only the parameters in Config are configured, and parameters in ctrl.Options such as SyncPeriod, Namespace, and RetryPeriod cannot be modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on issue #645: [Improvement] feat(operator): Support for custom initialization parameters.
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on issue #645:
URL: https://github.com/apache/incubator-uniffle/issues/645#issuecomment-1446271085
> > From the issue description, I don't quite get what you want to archive. The main.go for controller and webhook already handles flag parsing.
> > But you are always welcome to submit a PR, and let's discuss there.
>
> Only the parameters in Config are configured, and parameters in ctrl.Options such as SyncPeriod, Namespace, and RetryPeriod cannot be modified.
I see. SGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] advancedxy closed issue #645: [Improvement] feat(operator): Support for custom initialization parameters.
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy closed issue #645: [Improvement] feat(operator): Support for custom initialization parameters.
URL: https://github.com/apache/incubator-uniffle/issues/645
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org