[GitHub] geode issue #570: GEODE-3055: waitUntilFlush should use data region's bucket...

[gesterzhou <gi...@git.apache.org>]

Github user gesterzhou commented on the issue:

    https://github.com/apache/geode/pull/570
  
    The forceRemovePrimary was useless and it can be removed because it always use "false".
    
    But when I added the logic to remove the leader region bucket (when the shadow bucket failed to initialize), I have to call the removeBucket(xxx, forceRemovePrimary=true) by myself.
    
    When removing leader bucket in the error handling, I have to skip a few "return false" exit points, because at this time the leader bucket is not logically ready and not qualified to be removed unless I force to remove it.
    
    So I make use of the forceRemovePrimary parameter. Maybe I should change it to better name, such as forceToRemove, though. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---