You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by John Kordich via Review Board <no...@reviews.apache.org> on 2018/06/01 21:58:52 UTC
Re: Review Request 67066: Modified the fetcher to use libarchive and
added associated tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/
-----------------------------------------------------------
(Updated June 1, 2018, 9:58 p.m.)
Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
Changes
-------
Updating review for another reviewbot pass.
Bugs: MESOS-8064
https://issues.apache.org/jira/browse/MESOS-8064
Repository: mesos
Description
-------
Modified the fetcher to use libarchive and added associated tests.
Diffs (updated)
-----
src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d
src/tests/fetcher_tests.cpp 8c353f2a30a6dd6338c91dad7ff76ff28d1005e8
Diff: https://reviews.apache.org/r/67066/diff/8/
Changes: https://reviews.apache.org/r/67066/diff/7-8/
Testing
-------
I've built on Windows with CMake and have run all tests, which all pass.
I've also built on Linux with both the autotools build and cmake build and have run all tests, which all pass.
Thanks,
John Kordich
Re: Review Request 67066: Modified the fetcher to use libarchive and
added associated tests.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/#review204274
-----------------------------------------------------------
PASS: Mesos patch 67066 was successfully built and tested.
Reviews applied: `['67118', '67064', '67065', '67066']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67066
- Mesos Reviewbot Windows
On June 4, 2018, 7:11 p.m., John Kordich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67066/
> -----------------------------------------------------------
>
> (Updated June 4, 2018, 7:11 p.m.)
>
>
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
>
>
> Bugs: MESOS-8064
> https://issues.apache.org/jira/browse/MESOS-8064
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Modified the fetcher to use libarchive and added associated tests.
>
>
> Diffs
> -----
>
> src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d
> src/tests/fetcher_tests.cpp 8c353f2a30a6dd6338c91dad7ff76ff28d1005e8
>
>
> Diff: https://reviews.apache.org/r/67066/diff/9/
>
>
> Testing
> -------
>
> I've built on Windows with CMake and have run all tests, which all pass.
> I've also built on Linux with both the autotools build and cmake build and have run all tests, which all pass.
>
>
> Thanks,
>
> John Kordich
>
>
Re: Review Request 67066: Modified the fetcher to use libarchive and
added associated tests.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/#review204276
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On June 4, 2018, 12:11 p.m., John Kordich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67066/
> -----------------------------------------------------------
>
> (Updated June 4, 2018, 12:11 p.m.)
>
>
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
>
>
> Bugs: MESOS-8064
> https://issues.apache.org/jira/browse/MESOS-8064
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Modified the fetcher to use libarchive and added associated tests.
>
>
> Diffs
> -----
>
> src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d
> src/tests/fetcher_tests.cpp 8c353f2a30a6dd6338c91dad7ff76ff28d1005e8
>
>
> Diff: https://reviews.apache.org/r/67066/diff/9/
>
>
> Testing
> -------
>
> I've built on Windows with CMake and have run all tests, which all pass.
> I've also built on Linux with both the autotools build and cmake build and have run all tests, which all pass.
>
>
> Thanks,
>
> John Kordich
>
>
Re: Review Request 67066: Modified the fetcher to use libarchive and
added associated tests.
Posted by John Kordich via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/
-----------------------------------------------------------
(Updated June 4, 2018, 7:11 p.m.)
Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
Changes
-------
Updating review for new reviewbot pass
Bugs: MESOS-8064
https://issues.apache.org/jira/browse/MESOS-8064
Repository: mesos
Description
-------
Modified the fetcher to use libarchive and added associated tests.
Diffs (updated)
-----
src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d
src/tests/fetcher_tests.cpp 8c353f2a30a6dd6338c91dad7ff76ff28d1005e8
Diff: https://reviews.apache.org/r/67066/diff/9/
Changes: https://reviews.apache.org/r/67066/diff/8-9/
Testing
-------
I've built on Windows with CMake and have run all tests, which all pass.
I've also built on Linux with both the autotools build and cmake build and have run all tests, which all pass.
Thanks,
John Kordich
Re: Review Request 67066: Modified the fetcher to use libarchive and
added associated tests.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/#review204222
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67118, 67064, 67065, 67066]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 1, 2018, 9:58 p.m., John Kordich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67066/
> -----------------------------------------------------------
>
> (Updated June 1, 2018, 9:58 p.m.)
>
>
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
>
>
> Bugs: MESOS-8064
> https://issues.apache.org/jira/browse/MESOS-8064
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Modified the fetcher to use libarchive and added associated tests.
>
>
> Diffs
> -----
>
> src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d
> src/tests/fetcher_tests.cpp 8c353f2a30a6dd6338c91dad7ff76ff28d1005e8
>
>
> Diff: https://reviews.apache.org/r/67066/diff/8/
>
>
> Testing
> -------
>
> I've built on Windows with CMake and have run all tests, which all pass.
> I've also built on Linux with both the autotools build and cmake build and have run all tests, which all pass.
>
>
> Thanks,
>
> John Kordich
>
>
Re: Review Request 67066: Modified the fetcher to use libarchive and
added associated tests.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67066/#review204209
-----------------------------------------------------------
PASS: Mesos patch 67066 was successfully built and tested.
Reviews applied: `['67118', '67064', '67065', '67066']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67066
- Mesos Reviewbot Windows
On June 1, 2018, 9:58 p.m., John Kordich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67066/
> -----------------------------------------------------------
>
> (Updated June 1, 2018, 9:58 p.m.)
>
>
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
>
>
> Bugs: MESOS-8064
> https://issues.apache.org/jira/browse/MESOS-8064
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Modified the fetcher to use libarchive and added associated tests.
>
>
> Diffs
> -----
>
> src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d
> src/tests/fetcher_tests.cpp 8c353f2a30a6dd6338c91dad7ff76ff28d1005e8
>
>
> Diff: https://reviews.apache.org/r/67066/diff/8/
>
>
> Testing
> -------
>
> I've built on Windows with CMake and have run all tests, which all pass.
> I've also built on Linux with both the autotools build and cmake build and have run all tests, which all pass.
>
>
> Thanks,
>
> John Kordich
>
>