You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by minahlee <gi...@git.apache.org> on 2015/11/14 18:28:55 UTC

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-420] Improve notebook c...

GitHub user minahlee opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/432

    [ZEPPELIN-420] Improve notebook clone behavior

    This PR handles two issues with notebook clone behavior.
    * If same paragraphs from original notebook and cloned notebook run at the same time, both paragraphs can be in `RUNNING` status. And clone notebook's paragraph stays in running status until restart Zeppelin server because two paragraphs have same paragraph id and job id:
    ![before1](https://cloud.githubusercontent.com/assets/8503346/11164773/35fba1be-8b3d-11e5-9d70-d49ed1b25bba.gif)
    
      After:
    ![after1](https://cloud.githubusercontent.com/assets/8503346/11164844/a6aff5fc-8b3f-11e5-9bb4-72152790db03.gif)
    
    
    * Copy paragraph status(RUNNING, PENDING):
    ![before2](https://cloud.githubusercontent.com/assets/8503346/11164793/265029fa-8b3e-11e5-9105-e2bf7f4af07e.gif)
    
      After:
    ![after2 fig](https://cloud.githubusercontent.com/assets/8503346/11164855/25a64938-8b40-11e5-87ba-8f3b6ff492b9.gif)
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/minahlee/incubator-zeppelin ZEPPELIN-420

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/432.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #432
    
----
commit ec238877e5f3c6a9b47562bd30d408bffb5e06b0
Author: Mina Lee <mi...@nflabs.com>
Date:   2015-11-14T12:36:03Z

    [ZEPPELIN-420] Improve notebook clone behavior

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-420] Improve notebook c...

Posted by corneadoug <gi...@git.apache.org>.

Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/432#issuecomment-156769983
  
    Nice!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-420] Improve notebook c...

Posted by khalidhuseynov <gi...@git.apache.org>.

Github user khalidhuseynov commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/432#issuecomment-156889962
  
    having unique id for clone paragraph is an important one, LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-420] Improve notebook c...

Posted by felixcheung <gi...@git.apache.org>.

Github user felixcheung commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/432#issuecomment-156789788
  
    looks good


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-420] Improve notebook c...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/432


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-420] Improve notebook c...

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/432#issuecomment-156979502
  
    Nice improvement!
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---