[PR] [ISSUE #1774] Restrict authentication argument resolver types [rocketmq-dashboard]

["yuluo-yx (via GitHub)" <gi...@apache.org>]

yuluo-yx opened a new pull request, #1783:
URL: https://github.com/apache/rocketmq-dashboard/pull/1783

   ## What is the purpose of the change
   
   Correct the authentication argument resolver type check. Reversed `isAssignableFrom` operands caused unrelated supertypes such as `Object` to be accepted.
   
   Fixes #1774
   
   ## Brief changelog
   
   - Reverse the assignability check to select `UserInfo` parameters correctly.
   - Add a regression test that accepts `UserInfo` and rejects `Object`.
   
   ## Verifying this change
   
   - JDK: Temurin 17.0.19
   - Focused backend Maven compile and test phases completed
   - `AuthWebMVCConfigurerAdapterTest`: 1 test, 0 failures, 0 errors
   - `mvn validate`: passed
   - `git diff --check`: passed
   - PR scope check: passed (2 files, 59 changed lines, one commit, base `master`)
   - Full lifecycle, integration, E2E, and container checks were not run because this five-PR workflow requires lightweight local verification and leaves heavyweight checks to upstream CI.
   
   Follow this checklist to help us incorporate your contribution quickly and easily.
   
   - [x] Make sure there is a Github issue filed for the change. This PR addresses only that issue.
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit has a meaningful subject and body.
   - [x] Write a pull request description that explains what, how, and why.
   - [x] Write necessary unit tests to verify the logic correction.
   - [ ] Run the repository full basic, install, and integration command matrix. The focused backend checks above pass; heavyweight checks are delegated to upstream CI.
   - [ ] If this contribution is large, file an Apache Individual Contributor License Agreement.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ISSUE #1774] Restrict authentication argument resolver types [rocketmq-dashboard]

["lizhimins (via GitHub)" <gi...@apache.org>]

lizhimins closed pull request #1783: [ISSUE #1774] Restrict authentication argument resolver types
URL: https://github.com/apache/rocketmq-dashboard/pull/1783


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ISSUE #1774] Restrict authentication argument resolver types [rocketmq-dashboard]

["lizhimins (via GitHub)" <gi...@apache.org>]

lizhimins commented on PR #1783:
URL: https://github.com/apache/rocketmq-dashboard/pull/1783#issuecomment-5278608111

   Closing: this PR targets the legacy dashboard codebase (the old src/ tree), which is no longer maintained — those files have been removed from the active branch. Development has moved to the new Studio architecture (server/ + web/) on the rocketmq-studio branch, which is expected to become the main branch in September. Thanks for the contribution — if the issue still applies to the new Studio, please feel free to open a new PR based on the rocketmq-studio branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org