You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@incubator.apache.org by Adrian Cole <ad...@gmail.com> on 2019/02/14 01:32:25 UTC
[VOTE] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2
Hello All,
This is a call for vote to release Apache Zipkin Brave Karaf
(Incubating) version 0.1.2
The Apache Zipkin community has voted on and approved a proposal to
release Apache Zipkin Brave Karaf (Incubating) version 0.1.2.
We now kindly request the Incubator PMC members review and vote on
this incubator release.
Apache Zipkin Brave Karaf (Incubating) sets up tracing components such
that tools built Karaf needn't configure these explicitly.
Zipkin community vote and result thread:
https://lists.apache.org/thread.html/e18e8561b6e1ad7bc6f544332d4e97e4f96a020de3e1e4cc721b7625@%3Cdev.zipkin.apache.org%3E
The release candidates:
https://dist.apache.org/repos/dist/dev/incubator/zipkin/brave-karaf/0.1.2/
Git tag for the release:
https://github.com/apache/incubator-zipkin-brave-karaf/tree/v0.1.2
Hash for the release tag:
31545805a55dbe5e495403d84172fc865a4935e0
Release Notes:
https://github.com/apache/incubator-zipkin-brave-karaf/releases/tag/v0.1.2
The artifacts have been signed with Key : BB67A050, which can be found
in the keys file:
https://dist.apache.org/repos/dist/dev/incubator/zipkin/KEYS
Verification Hints:
For your convenience, the below includes detailed how-to on verifying
a source release. Please note that this document is a work-in-progress
https://cwiki.apache.org/confluence/display/ZIPKIN/Verifying+a+Source+Release
The vote will be open for at least 72 hours or until necessary number
of votes are reached.
Please vote accordingly:
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason
Thanks,
The Apache Zipkin (Incubating) Team
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
[VOTE FAILED] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2
Posted by Adrian Cole <ad...@gmail.com>.
This vote failed due to binaries in the distribution. Will send a new
vote shortly.
Thanks for the input, all.
-A
On Fri, Feb 15, 2019 at 7:56 AM Adrian Cole <ad...@gmail.com> wrote:
>
> Perfectly fine naming suggestion. thanks, Dave.
>
> "Apache Zipkin Brave (incubating) for Apache Karaf"
>
> I will put that into a pull request and suspect no-one will contest it.
>
> -A
>
> On Fri, Feb 15, 2019, 7:43 AM Dave Fisher <wave@apache.org wrote:
>>
>> Hi Adrian,
>>
>> (NOTE - cross posted to private lists. Take care with replies.)
>>
>> Thanks for your patience regarding the branding issue I mentioned.
>>
>> > On Feb 14, 2019, at 4:29 AM, Adrian Cole <ad...@gmail.com> wrote:
>>
>> <snip>
>>
>> > Finally, there was an unresolved question about branding of the repo. I
>> > dont think we should attempt another release if there is something else
>> > lurking.
>>
>> The name Apache Zipkin Brave Karaf (incubating) represents a confusion of two Apache Brands - Zipkin an incubating podling and Apache Karaf.
>>
>> See http://www.apache.org/foundation/marks/pmcs#other
>>
>> This suggests that the proper name respecting Karaf’s brand would be "Apache Zipkin Brave (incubating) for Apache Karaf"
>>
>> Regards,
>> Dave
>>
>> >
>> > Thanks for the help folks.
>> >
>> > -Adrian
>> >
>> >
>> > On Thu, Feb 14, 2019, 7:40 PM John D. Ament <johndament@apache.org wrote:
>> >
>> >> On Thu, Feb 14, 2019 at 6:35 AM Justin Mclean <ju...@me.com> wrote:
>> >>
>> >>> Hi,
>> >>>
>> >>>> I can follow up with the developer to fix their headers via a github
>> >>> issue (if no one else gets to it before me).
>> >>>
>> >>> I already have raise it as an issue :-) Add to it it if you want. [1]
>> >>>
>> >>>> Including prior statements about NOTICE is completely optional, but in
>> >>> the
>> >>>> case of no SGA would be ideal. I don't think that's a blocker for
>> >>> release …
>> >>>
>> >>> No neither do I think it is a blocker, but having a jar in a source
>> >>> release is.
>> >>>
>> >>>
>> >> And I can see in the repo that's already been resolved. So I think
>> >> Adrian's all set to re-roll the release and put it up for a vote.
>> >>
>> >>
>> >>> Thanks,
>> >>> Justin
>> >>>
>> >>> 1. https://github.com/takari/maven-wrapper/issues/104
>> >>> ---------------------------------------------------------------------
>> >>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> >>> For additional commands, e-mail: general-help@incubator.apache.org
>> >>>
>> >>>
>> >>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
>> For additional commands, e-mail: dev-help@zipkin.apache.org
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org
[VOTE FAILED] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2
Posted by Adrian Cole <ad...@gmail.com>.
This vote failed due to binaries in the distribution. Will send a new
vote shortly.
Thanks for the input, all.
-A
On Fri, Feb 15, 2019 at 7:56 AM Adrian Cole <ad...@gmail.com> wrote:
>
> Perfectly fine naming suggestion. thanks, Dave.
>
> "Apache Zipkin Brave (incubating) for Apache Karaf"
>
> I will put that into a pull request and suspect no-one will contest it.
>
> -A
>
> On Fri, Feb 15, 2019, 7:43 AM Dave Fisher <wave@apache.org wrote:
>>
>> Hi Adrian,
>>
>> (NOTE - cross posted to private lists. Take care with replies.)
>>
>> Thanks for your patience regarding the branding issue I mentioned.
>>
>> > On Feb 14, 2019, at 4:29 AM, Adrian Cole <ad...@gmail.com> wrote:
>>
>> <snip>
>>
>> > Finally, there was an unresolved question about branding of the repo. I
>> > dont think we should attempt another release if there is something else
>> > lurking.
>>
>> The name Apache Zipkin Brave Karaf (incubating) represents a confusion of two Apache Brands - Zipkin an incubating podling and Apache Karaf.
>>
>> See http://www.apache.org/foundation/marks/pmcs#other
>>
>> This suggests that the proper name respecting Karaf’s brand would be "Apache Zipkin Brave (incubating) for Apache Karaf"
>>
>> Regards,
>> Dave
>>
>> >
>> > Thanks for the help folks.
>> >
>> > -Adrian
>> >
>> >
>> > On Thu, Feb 14, 2019, 7:40 PM John D. Ament <johndament@apache.org wrote:
>> >
>> >> On Thu, Feb 14, 2019 at 6:35 AM Justin Mclean <ju...@me.com> wrote:
>> >>
>> >>> Hi,
>> >>>
>> >>>> I can follow up with the developer to fix their headers via a github
>> >>> issue (if no one else gets to it before me).
>> >>>
>> >>> I already have raise it as an issue :-) Add to it it if you want. [1]
>> >>>
>> >>>> Including prior statements about NOTICE is completely optional, but in
>> >>> the
>> >>>> case of no SGA would be ideal. I don't think that's a blocker for
>> >>> release …
>> >>>
>> >>> No neither do I think it is a blocker, but having a jar in a source
>> >>> release is.
>> >>>
>> >>>
>> >> And I can see in the repo that's already been resolved. So I think
>> >> Adrian's all set to re-roll the release and put it up for a vote.
>> >>
>> >>
>> >>> Thanks,
>> >>> Justin
>> >>>
>> >>> 1. https://github.com/takari/maven-wrapper/issues/104
>> >>> ---------------------------------------------------------------------
>> >>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> >>> For additional commands, e-mail: general-help@incubator.apache.org
>> >>>
>> >>>
>> >>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
>> For additional commands, e-mail: dev-help@zipkin.apache.org
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2
Posted by Adrian Cole <ad...@gmail.com>.
Perfectly fine naming suggestion. thanks, Dave.
"Apache Zipkin Brave (incubating) for Apache Karaf"
I will put that into a pull request and suspect no-one will contest it.
-A
On Fri, Feb 15, 2019, 7:43 AM Dave Fisher <wave@apache.org wrote:
> Hi Adrian,
>
> (NOTE - cross posted to private lists. Take care with replies.)
>
> Thanks for your patience regarding the branding issue I mentioned.
>
> > On Feb 14, 2019, at 4:29 AM, Adrian Cole <ad...@gmail.com>
> wrote:
>
> <snip>
>
> > Finally, there was an unresolved question about branding of the repo. I
> > dont think we should attempt another release if there is something else
> > lurking.
>
> The name Apache Zipkin Brave Karaf (incubating) represents a confusion of
> two Apache Brands - Zipkin an incubating podling and Apache Karaf.
>
> See http://www.apache.org/foundation/marks/pmcs#other
>
> This suggests that the proper name respecting Karaf’s brand would be
> "Apache Zipkin Brave (incubating) for Apache Karaf"
>
> Regards,
> Dave
>
> >
> > Thanks for the help folks.
> >
> > -Adrian
> >
> >
> > On Thu, Feb 14, 2019, 7:40 PM John D. Ament <johndament@apache.org
> wrote:
> >
> >> On Thu, Feb 14, 2019 at 6:35 AM Justin Mclean <ju...@me.com>
> wrote:
> >>
> >>> Hi,
> >>>
> >>>> I can follow up with the developer to fix their headers via a github
> >>> issue (if no one else gets to it before me).
> >>>
> >>> I already have raise it as an issue :-) Add to it it if you want. [1]
> >>>
> >>>> Including prior statements about NOTICE is completely optional, but in
> >>> the
> >>>> case of no SGA would be ideal. I don't think that's a blocker for
> >>> release …
> >>>
> >>> No neither do I think it is a blocker, but having a jar in a source
> >>> release is.
> >>>
> >>>
> >> And I can see in the repo that's already been resolved. So I think
> >> Adrian's all set to re-roll the release and put it up for a vote.
> >>
> >>
> >>> Thanks,
> >>> Justin
> >>>
> >>> 1. https://github.com/takari/maven-wrapper/issues/104
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> >>> For additional commands, e-mail: general-help@incubator.apache.org
> >>>
> >>>
> >>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
> For additional commands, e-mail: dev-help@zipkin.apache.org
>
>
Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2
Posted by Adrian Cole <ad...@gmail.com>.
Perfectly fine naming suggestion. thanks, Dave.
"Apache Zipkin Brave (incubating) for Apache Karaf"
I will put that into a pull request and suspect no-one will contest it.
-A
On Fri, Feb 15, 2019, 7:43 AM Dave Fisher <wave@apache.org wrote:
> Hi Adrian,
>
> (NOTE - cross posted to private lists. Take care with replies.)
>
> Thanks for your patience regarding the branding issue I mentioned.
>
> > On Feb 14, 2019, at 4:29 AM, Adrian Cole <ad...@gmail.com>
> wrote:
>
> <snip>
>
> > Finally, there was an unresolved question about branding of the repo. I
> > dont think we should attempt another release if there is something else
> > lurking.
>
> The name Apache Zipkin Brave Karaf (incubating) represents a confusion of
> two Apache Brands - Zipkin an incubating podling and Apache Karaf.
>
> See http://www.apache.org/foundation/marks/pmcs#other
>
> This suggests that the proper name respecting Karaf’s brand would be
> "Apache Zipkin Brave (incubating) for Apache Karaf"
>
> Regards,
> Dave
>
> >
> > Thanks for the help folks.
> >
> > -Adrian
> >
> >
> > On Thu, Feb 14, 2019, 7:40 PM John D. Ament <johndament@apache.org
> wrote:
> >
> >> On Thu, Feb 14, 2019 at 6:35 AM Justin Mclean <ju...@me.com>
> wrote:
> >>
> >>> Hi,
> >>>
> >>>> I can follow up with the developer to fix their headers via a github
> >>> issue (if no one else gets to it before me).
> >>>
> >>> I already have raise it as an issue :-) Add to it it if you want. [1]
> >>>
> >>>> Including prior statements about NOTICE is completely optional, but in
> >>> the
> >>>> case of no SGA would be ideal. I don't think that's a blocker for
> >>> release …
> >>>
> >>> No neither do I think it is a blocker, but having a jar in a source
> >>> release is.
> >>>
> >>>
> >> And I can see in the repo that's already been resolved. So I think
> >> Adrian's all set to re-roll the release and put it up for a vote.
> >>
> >>
> >>> Thanks,
> >>> Justin
> >>>
> >>> 1. https://github.com/takari/maven-wrapper/issues/104
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> >>> For additional commands, e-mail: general-help@incubator.apache.org
> >>>
> >>>
> >>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
> For additional commands, e-mail: dev-help@zipkin.apache.org
>
>
Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version
0.1.2
Posted by Dave Fisher <wa...@apache.org>.
Hi Adrian,
(NOTE - cross posted to private lists. Take care with replies.)
Thanks for your patience regarding the branding issue I mentioned.
> On Feb 14, 2019, at 4:29 AM, Adrian Cole <ad...@gmail.com> wrote:
<snip>
> Finally, there was an unresolved question about branding of the repo. I
> dont think we should attempt another release if there is something else
> lurking.
The name Apache Zipkin Brave Karaf (incubating) represents a confusion of two Apache Brands - Zipkin an incubating podling and Apache Karaf.
See http://www.apache.org/foundation/marks/pmcs#other
This suggests that the proper name respecting Karaf’s brand would be "Apache Zipkin Brave (incubating) for Apache Karaf"
Regards,
Dave
>
> Thanks for the help folks.
>
> -Adrian
>
>
> On Thu, Feb 14, 2019, 7:40 PM John D. Ament <johndament@apache.org wrote:
>
>> On Thu, Feb 14, 2019 at 6:35 AM Justin Mclean <ju...@me.com> wrote:
>>
>>> Hi,
>>>
>>>> I can follow up with the developer to fix their headers via a github
>>> issue (if no one else gets to it before me).
>>>
>>> I already have raise it as an issue :-) Add to it it if you want. [1]
>>>
>>>> Including prior statements about NOTICE is completely optional, but in
>>> the
>>>> case of no SGA would be ideal. I don't think that's a blocker for
>>> release …
>>>
>>> No neither do I think it is a blocker, but having a jar in a source
>>> release is.
>>>
>>>
>> And I can see in the repo that's already been resolved. So I think
>> Adrian's all set to re-roll the release and put it up for a vote.
>>
>>
>>> Thanks,
>>> Justin
>>>
>>> 1. https://github.com/takari/maven-wrapper/issues/104
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>>> For additional commands, e-mail: general-help@incubator.apache.org
>>>
>>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org
Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version
0.1.2
Posted by Dave Fisher <wa...@apache.org>.
Hi Adrian,
(NOTE - cross posted to private lists. Take care with replies.)
Thanks for your patience regarding the branding issue I mentioned.
> On Feb 14, 2019, at 4:29 AM, Adrian Cole <ad...@gmail.com> wrote:
<snip>
> Finally, there was an unresolved question about branding of the repo. I
> dont think we should attempt another release if there is something else
> lurking.
The name Apache Zipkin Brave Karaf (incubating) represents a confusion of two Apache Brands - Zipkin an incubating podling and Apache Karaf.
See http://www.apache.org/foundation/marks/pmcs#other
This suggests that the proper name respecting Karaf’s brand would be "Apache Zipkin Brave (incubating) for Apache Karaf"
Regards,
Dave
>
> Thanks for the help folks.
>
> -Adrian
>
>
> On Thu, Feb 14, 2019, 7:40 PM John D. Ament <johndament@apache.org wrote:
>
>> On Thu, Feb 14, 2019 at 6:35 AM Justin Mclean <ju...@me.com> wrote:
>>
>>> Hi,
>>>
>>>> I can follow up with the developer to fix their headers via a github
>>> issue (if no one else gets to it before me).
>>>
>>> I already have raise it as an issue :-) Add to it it if you want. [1]
>>>
>>>> Including prior statements about NOTICE is completely optional, but in
>>> the
>>>> case of no SGA would be ideal. I don't think that's a blocker for
>>> release …
>>>
>>> No neither do I think it is a blocker, but having a jar in a source
>>> release is.
>>>
>>>
>> And I can see in the repo that's already been resolved. So I think
>> Adrian's all set to re-roll the release and put it up for a vote.
>>
>>
>>> Thanks,
>>> Justin
>>>
>>> 1. https://github.com/takari/maven-wrapper/issues/104
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>>> For additional commands, e-mail: general-help@incubator.apache.org
>>>
>>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2
Posted by Adrian Cole <ad...@gmail.com>.
We would really prefer us to not have to add a non standard and explicit
line in the NOTICE file about "The OpenZipkin Authors" as it doesnt exist
as a legal entity and even if it did, it didn't sign an SGA.
We would like that to not only be a non-blocker for this release, but also
subsequent ones in different repos which are yet to move. In other words,
we would like a clean file and if there is confusion on this topic it be
fully resolved prior to any more work on incubation.
In other words agree that this "The OpenZipkin Authors" addendum to the
NOTICE is neither required nor will be resurrected as a blocker to a future
release or graduation? If this is a disagreement, we would prefer to have
multiple IPMC members say so and why before asking us to escalate to legal.
Finally, there was an unresolved question about branding of the repo. I
dont think we should attempt another release if there is something else
lurking.
Thanks for the help folks.
-Adrian
On Thu, Feb 14, 2019, 7:40 PM John D. Ament <johndament@apache.org wrote:
> On Thu, Feb 14, 2019 at 6:35 AM Justin Mclean <ju...@me.com> wrote:
>
> > Hi,
> >
> > > I can follow up with the developer to fix their headers via a github
> > issue (if no one else gets to it before me).
> >
> > I already have raise it as an issue :-) Add to it it if you want. [1]
> >
> > > Including prior statements about NOTICE is completely optional, but in
> > the
> > > case of no SGA would be ideal. I don't think that's a blocker for
> > release …
> >
> > No neither do I think it is a blocker, but having a jar in a source
> > release is.
> >
> >
> And I can see in the repo that's already been resolved. So I think
> Adrian's all set to re-roll the release and put it up for a vote.
>
>
> > Thanks,
> > Justin
> >
> > 1. https://github.com/takari/maven-wrapper/issues/104
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
> >
>
Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2
Posted by "John D. Ament" <jo...@apache.org>.
On Thu, Feb 14, 2019 at 6:35 AM Justin Mclean <ju...@me.com> wrote:
> Hi,
>
> > I can follow up with the developer to fix their headers via a github
> issue (if no one else gets to it before me).
>
> I already have raise it as an issue :-) Add to it it if you want. [1]
>
> > Including prior statements about NOTICE is completely optional, but in
> the
> > case of no SGA would be ideal. I don't think that's a blocker for
> release …
>
> No neither do I think it is a blocker, but having a jar in a source
> release is.
>
>
And I can see in the repo that's already been resolved. So I think
Adrian's all set to re-roll the release and put it up for a vote.
> Thanks,
> Justin
>
> 1. https://github.com/takari/maven-wrapper/issues/104
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version
0.1.2
Posted by Justin Mclean <ju...@me.com>.
Hi,
> I can follow up with the developer to fix their headers via a github issue (if no one else gets to it before me).
I already have raise it as an issue :-) Add to it it if you want. [1]
> Including prior statements about NOTICE is completely optional, but in the
> case of no SGA would be ideal. I don't think that's a blocker for release …
No neither do I think it is a blocker, but having a jar in a source release is.
Thanks,
Justin
1. https://github.com/takari/maven-wrapper/issues/104
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2
Posted by "John D. Ament" <jo...@apache.org>.
Hi all,
I just want to point out that the issue is that MavenWrapperDownloader has
incorrect license headers in its source repository, see [1]. We should not
fault Apache projects for leveraging this, since the upstream is not
properly setup. I can follow up with the developer to fix their headers
via a github issue (if no one else gets to it before me). Likewise, we
should leave the source in as that is the ideal way to bootstrap the
plugin. The developer even added it since many Apache projects were
struggling to create releases when his toolkit was in use. Likewise, since
this project includes no NOTICE file there's nothing to add to a project's
notice file, per the Apache License.
Including prior statements about NOTICE is completely optional, but in the
case of no SGA would be ideal. I don't think that's a blocker for release
since we have ICLAs on file for the main contributors [2] to this
codebase. I see Adrian has already corrected this in the repo, so I would
be +1 to releasing with that modification.
John
[1]:
https://github.com/takari/maven-wrapper/blob/master/.mvn/wrapper/MavenWrapperDownloader.java
[2]:
https://github.com/apache/incubator-zipkin-brave-karaf/graphs/contributors
On Thu, Feb 14, 2019 at 1:02 AM Dave Fisher <da...@comcast.net> wrote:
> Hi Adrian/Justin,
>
> We are discussing the wrong points. The clear question is what is
> MavenWrapperDownloader.java and why does it need to be in source release?
> It doesn’t.
>
> The Zipkin build instruction should include the installation instructions
> for MavenWrapper. [3]
>
> Adrian will that work for Zipkin?
>
> Regards,
> Dave
>
> [3] https://www.baeldung.com/maven-wrapper
>
> Sent from my iPhone
>
> > On Feb 13, 2019, at 6:07 PM, Justin Mclean <ju...@classsoftware.com>
> wrote:
> >
> > Hi,
> >
> > Sorry but it’s -1 (binding) as it contains compiled code (a .jar) [1],
> an ASF release must consist of source code only. The other issue are minor
> IMO and can be fixed in a future release.
> >
> > I checked:
> > - incubating in name
> > - signature and hashed correct
> > - LICENSE is fine
> > - NOTICE has some minor issue (see below)
> > - All source files have have headers
> > - An unexpected binary file in source release [1]
> > - Can compile from source
> >
> > Re NOTICE did you project come to the ASF in 2016? Who did it come from,
> and if the headers were changed to ASF ones then they should be mentioned
> in NOTICE.
> >
> > Should this file have an ASF header? [2] Where did it originally come
> from? Answer to this question may mean that some changes to LICENSE and
> HEADER are required.
> >
> > Re the maven wrapper jar several project have run into this issue and
> have managed to resolve it without including the jar. You should be able to
> find them with a search of this list. BTW A warning that rat didn’t pick
> this up and it seem it doesn’t follow directories with a dot in front of
> them.
> >
> > While i can compile it looks like the build assumes the code is checked
> out of GitHub and you’re not compiling the source release as I get a lot of
> these:
> > failure occured while calling class
> com.mycila.maven.plugin.license.git.CopyrightRangeProvider
> > java.lang.RuntimeException: Could not compute the year of the last git
> commit for file xxxxx
> >
> > Thanks,
> > Justin
> >
> > 1. ./.mvn/wrapper/maven-wrapper.jar
> > 2. .mvn/wrapper/MavenWrapperDownloader.java
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
>
Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2
Posted by Dave Fisher <da...@comcast.net>.
Hi Adrian/Justin,
We are discussing the wrong points. The clear question is what is MavenWrapperDownloader.java and why does it need to be in source release? It doesn’t.
The Zipkin build instruction should include the installation instructions for MavenWrapper. [3]
Adrian will that work for Zipkin?
Regards,
Dave
[3] https://www.baeldung.com/maven-wrapper
Sent from my iPhone
> On Feb 13, 2019, at 6:07 PM, Justin Mclean <ju...@classsoftware.com> wrote:
>
> Hi,
>
> Sorry but it’s -1 (binding) as it contains compiled code (a .jar) [1], an ASF release must consist of source code only. The other issue are minor IMO and can be fixed in a future release.
>
> I checked:
> - incubating in name
> - signature and hashed correct
> - LICENSE is fine
> - NOTICE has some minor issue (see below)
> - All source files have have headers
> - An unexpected binary file in source release [1]
> - Can compile from source
>
> Re NOTICE did you project come to the ASF in 2016? Who did it come from, and if the headers were changed to ASF ones then they should be mentioned in NOTICE.
>
> Should this file have an ASF header? [2] Where did it originally come from? Answer to this question may mean that some changes to LICENSE and HEADER are required.
>
> Re the maven wrapper jar several project have run into this issue and have managed to resolve it without including the jar. You should be able to find them with a search of this list. BTW A warning that rat didn’t pick this up and it seem it doesn’t follow directories with a dot in front of them.
>
> While i can compile it looks like the build assumes the code is checked out of GitHub and you’re not compiling the source release as I get a lot of these:
> failure occured while calling class com.mycila.maven.plugin.license.git.CopyrightRangeProvider
> java.lang.RuntimeException: Could not compute the year of the last git commit for file xxxxx
>
> Thanks,
> Justin
>
> 1. ./.mvn/wrapper/maven-wrapper.jar
> 2. .mvn/wrapper/MavenWrapperDownloader.java
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version
0.1.2
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Again, this seems a site of unique enforcement with questionable
> clarity as a result. You seem to want us to add a statement saying
> that this code came from the Takari maven plugin and/or to investigate
> their CLA process.
Um no I want you to respect the license and headers of 3rd party code. I don’t know where that code came from, perhaps if you told me we could work out how best to deal with it. You seem to have confirmed it’s comes from a a 3rd party and not the ASF so it seems unlikely it should have an ASF header on it.
> The general feedback is that we are being asked to do things of
> questionable value
If you think that not complying with ASF licensing policy is of questionable value I can’t help you.
> Meanwhile graduated projects do not fall under this more
> strict regime and the types of enforcement are certainly more strict.
If a graduated project is found to not be complying with licensing policy they will be asked to comply, hopefully they will notice and fix it themselves before that but sometimes things slip between the cracks. And yes I have asked TLPs to fix things e.g. With Apache Spark as a number of incubator projects were copying what they were doing and it was not in line with license policy and they fixed it. Copying what TLPs do without understanding why things are done that way often causes incubating projects issues.
I also agree it would be good for other IPMC member to add their thoughts as well.
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2
Posted by Adrian Cole <ad...@gmail.com>.
>
> Did the Zipkin project file an SGA? If no, the contribution is all ICLA
> based and you are correct.
> If yes, then AFAIK Justin is correct, but there may be other edge cases.
>
There was no SGA. This particular codebase was also primarily authored by
iCLA signers. In Zipkin, we did an odd thing which was the IP stuff up
front.
Not every TLP may follow policy to the letter. Issues may have been missed
> in the past. A TLP may not have gone through the Incubator. You are free to
> examine the history of every project’s NOTICE file. If you do not accept
> the collective advice here and wish a ruling then you can ask the legal
> affairs committee at legal-discuss@apache.org by filing a LEGAL JIRA. But
> wait a bit to see. People who would answer there are as likely to answer
> here.
>
Most importantly, I am trying to figure out if advice is collective or not.
This is mainly an issue of understanding if all Justin's comments are to be
taken as a collective without others saying anything. We are lucky to have
people speak a lot but it would be nice to have especially detailed points
asked as "yeah you should do this" especially when others are clearly not.
I hope you saw my other thread opened as I doubt discussing also here will
get the same visibility into what could become a crisis if not watched over
well.
Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2
Posted by Dave Fisher <da...@comcast.net>.
Hi Adrian,
Simple question inline.
Sent from my iPhone
On Feb 13, 2019, at 8:33 PM, Adrian Cole <ad...@gmail.com> wrote:
>> See [1][2] on policy and many many projects do it except those that were developed solely at the ASF.
> In practice, you can find many, many that have stock files and were
> not developed solely at the ASF.
>
> Considering our statement was "The OpenZipkin Authors", I have not
> seen any file at all like this.. noting a non-legal entity.. though I
> haven't searched the entire org.
> I'm not saying this to be argumentative, rather it feels like cruft
> and not commonly applied. I wish others would chime in on topics like
> this.
Did the Zipkin project file an SGA? If no, the contribution is all ICLA based and you are correct.
If yes, then AFAIK Justin is correct, but there may be other edge cases.
>
>> Where does the code original come from is the question? That ASF header states it was licensed to the ASF under an CLA. Is this actually the case?
>
> Again, this seems a site of unique enforcement with questionable
> clarity as a result. You seem to want us to add a statement saying
> that this code came from the Takari maven plugin and/or to investigate
> their CLA process. You are asking us eventhough many many projects use
> this as-is. We can follow this, but the same feedback applies.
>
> The general feedback is that we are being asked to do things of
> questionable value even if it is to the letter of the law as you
> interpret it. Meanwhile graduated projects do not fall under this more
> strict regime and the types of enforcement are certainly more strict.
> It seems strict enforcements in general should be a community decide
> thing vs one person, even if you are very qualified, Justin.
Not every TLP may follow policy to the letter. Issues may have been missed in the past. A TLP may not have gone through the Incubator. You are free to examine the history of every project’s NOTICE file. If you do not accept the collective advice here and wish a ruling then you can ask the legal affairs committee at legal-discuss@apache.org by filing a LEGAL JIRA. But wait a bit to see. People who would answer there are as likely to answer here.
Regards,
Dave
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2
Posted by Adrian Cole <ad...@gmail.com>.
> See [1][2] on policy and many many projects do it except those that were developed solely at the ASF.
In practice, you can find many, many that have stock files and were
not developed solely at the ASF.
Considering our statement was "The OpenZipkin Authors", I have not
seen any file at all like this.. noting a non-legal entity.. though I
haven't searched the entire org.
I'm not saying this to be argumentative, rather it feels like cruft
and not commonly applied. I wish others would chime in on topics like
this.
> Where does the code original come from is the question? That ASF header states it was licensed to the ASF under an CLA. Is this actually the case?
Again, this seems a site of unique enforcement with questionable
clarity as a result. You seem to want us to add a statement saying
that this code came from the Takari maven plugin and/or to investigate
their CLA process. You are asking us eventhough many many projects use
this as-is. We can follow this, but the same feedback applies.
The general feedback is that we are being asked to do things of
questionable value even if it is to the letter of the law as you
interpret it. Meanwhile graduated projects do not fall under this more
strict regime and the types of enforcement are certainly more strict.
It seems strict enforcements in general should be a community decide
thing vs one person, even if you are very qualified, Justin.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version
0.1.2
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> I've not seen any example of a project noting prior headers like this,
> so I winged a pull request. Feedback welcome!
See [1][2] on policy and many many projects do it except those that were developed solely at the ASF.
> similar to above, I've not found any apache project special-casing the
> maven wrapper downloader file.
Where does the code original come from is the question? That ASF header states it was licensed to the ASF under an CLA. Is this actually the case?
> If so, wouldn't most apache projects need to do this, as opposed to just us?
I have no idea what other Apache project do, but they do need to follow header and license policy yes.
Thanks,
Justin
1. https://www.apache.org/legal/src-headers.html#headers
2. http://www.apache.org/dev/licensing-howto.html#mod-notice
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2
Posted by Adrian Cole <ad...@gmail.com>.
> Re NOTICE did you project come to the ASF in 2016? Who did it come from, and if the headers were changed to ASF ones then they should be mentioned in NOTICE.
I've not seen any example of a project noting prior headers like this,
so I winged a pull request. Feedback welcome!
https://github.com/apache/incubator-zipkin-brave-karaf/pull/30
> Should this file have an ASF header? [2] Where did it originally come from? Answer to this question may mean that some changes to LICENSE and HEADER are required.
> [2] .mvn/wrapper/MavenWrapperDownloader.java
similar to above, I've not found any apache project special-casing the
maven wrapper downloader file. We didn't affect the headers either..
are you looking for a statement inside NOTICE to say we used takari's
script to generate this? Is that required considering the license
header is apache? If so, wouldn't most apache projects need to do
this, as opposed to just us?
> Re the maven wrapper jar several project have run into this issue and have managed to resolve it without including the jar. You should be able to find them with a search of this list. BTW A warning that rat didn’t pick this up and it seem it doesn’t follow directories with a dot in front of them.
done - https://github.com/apache/incubator-zipkin-brave-karaf/pull/30
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2
Posted by Adrian Cole <ad...@gmail.com>.
> The product name is a problem.
>
> Please explain how this release relates to Apache Karaf? We can give you branding guidance once you do.
Sure thing. Zipkin is a tracing system and Brave is the original name
of the tracing libary, and the most widely used one. We currently file
"Brave" under the "Zipkin" brand, though users of it think of the
product as a top-level one.
As tracing ends up integrating with other libraries, our artifacts end
up being named brave-XXX where XXX is the library it is supporting.
For example, the brave repo itself has a dozen such things. Karaf was
split out because it is a specialized community with its own notion of
tests and such (PAX exam , etc).
So, this repo includes support libraries for those using Karaf
directly or indirectly (via CXF). Most of the Zipkin community
(including me) are not that familiar with the Karaf ecosystem. We've
mostly been just supporting the library by updating build etc and
trying to keep it passing tests.
Christian Schneider wrote most of this and we've had some advice from
Andriy Redko as well. Folks like these could likely more intelligently
answer Karaf related specifics.
Hope this helps, and thanks for having a look!
-A
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2
Posted by Dave Fisher <da...@comcast.net>.
The product name is a problem.
Please explain how this release relates to Apache Karaf? We can give you branding guidance once you do.
Regards,
Dave
Sent from my iPhone
> On Feb 13, 2019, at 6:07 PM, Justin Mclean <ju...@classsoftware.com> wrote:
>
> Hi,
>
> Sorry but it’s -1 (binding) as it contains compiled code (a .jar) [1], an ASF release must consist of source code only. The other issue are minor IMO and can be fixed in a future release.
>
> I checked:
> - incubating in name
> - signature and hashed correct
> - LICENSE is fine
> - NOTICE has some minor issue (see below)
> - All source files have have headers
> - An unexpected binary file in source release [1]
> - Can compile from source
>
> Re NOTICE did you project come to the ASF in 2016? Who did it come from, and if the headers were changed to ASF ones then they should be mentioned in NOTICE.
>
> Should this file have an ASF header? [2] Where did it originally come from? Answer to this question may mean that some changes to LICENSE and HEADER are required.
>
> Re the maven wrapper jar several project have run into this issue and have managed to resolve it without including the jar. You should be able to find them with a search of this list. BTW A warning that rat didn’t pick this up and it seem it doesn’t follow directories with a dot in front of them.
>
> While i can compile it looks like the build assumes the code is checked out of GitHub and you’re not compiling the source release as I get a lot of these:
> failure occured while calling class com.mycila.maven.plugin.license.git.CopyrightRangeProvider
> java.lang.RuntimeException: Could not compute the year of the last git commit for file xxxxx
>
> Thanks,
> Justin
>
> 1. ./.mvn/wrapper/maven-wrapper.jar
> 2. .mvn/wrapper/MavenWrapperDownloader.java
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version
0.1.2
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> As recutting, revoting, and reverifying is time consuming for the
> volunteers I will wait for someone else to also look at this (besides our
> mentors who already have) to save our folks the frustration of 3rd go round
> leading to a 4th.
That’s always a good idea any other IPMC have some time to take a look?
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2
Posted by Adrian Cole <ad...@gmail.com>.
thanks justin. I missed this part about the jar and know there are options
to it.
the license warnings were already resolved for the next release.
On the NOTICE, the headers originally said copyright "The OpenZipkin
Authors" I can put that into a pull request prior to re-cutting.
As recutting, revoting, and reverifying is time consuming for the
volunteers I will wait for someone else to also look at this (besides our
mentors who already have) to save our folks the frustration of 3rd go round
leading to a 4th.
On Thu, Feb 14, 2019, 10:08 AM Justin Mclean <justin@classsoftware.com
wrote:
> Hi,
>
> Sorry but it’s -1 (binding) as it contains compiled code (a .jar) [1], an
> ASF release must consist of source code only. The other issue are minor IMO
> and can be fixed in a future release.
>
> I checked:
> - incubating in name
> - signature and hashed correct
> - LICENSE is fine
> - NOTICE has some minor issue (see below)
> - All source files have have headers
> - An unexpected binary file in source release [1]
> - Can compile from source
>
> Re NOTICE did you project come to the ASF in 2016? Who did it come from,
> and if the headers were changed to ASF ones then they should be mentioned
> in NOTICE.
>
> Should this file have an ASF header? [2] Where did it originally come
> from? Answer to this question may mean that some changes to LICENSE and
> HEADER are required.
>
> Re the maven wrapper jar several project have run into this issue and have
> managed to resolve it without including the jar. You should be able to find
> them with a search of this list. BTW A warning that rat didn’t pick this up
> and it seem it doesn’t follow directories with a dot in front of them.
>
> While i can compile it looks like the build assumes the code is checked
> out of GitHub and you’re not compiling the source release as I get a lot of
> these:
> failure occured while calling class
> com.mycila.maven.plugin.license.git.CopyrightRangeProvider
> java.lang.RuntimeException: Could not compute the year of the last git
> commit for file xxxxx
>
> Thanks,
> Justin
>
> 1. ./.mvn/wrapper/maven-wrapper.jar
> 2. .mvn/wrapper/MavenWrapperDownloader.java
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version
0.1.2
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
Sorry but it’s -1 (binding) as it contains compiled code (a .jar) [1], an ASF release must consist of source code only. The other issue are minor IMO and can be fixed in a future release.
I checked:
- incubating in name
- signature and hashed correct
- LICENSE is fine
- NOTICE has some minor issue (see below)
- All source files have have headers
- An unexpected binary file in source release [1]
- Can compile from source
Re NOTICE did you project come to the ASF in 2016? Who did it come from, and if the headers were changed to ASF ones then they should be mentioned in NOTICE.
Should this file have an ASF header? [2] Where did it originally come from? Answer to this question may mean that some changes to LICENSE and HEADER are required.
Re the maven wrapper jar several project have run into this issue and have managed to resolve it without including the jar. You should be able to find them with a search of this list. BTW A warning that rat didn’t pick this up and it seem it doesn’t follow directories with a dot in front of them.
While i can compile it looks like the build assumes the code is checked out of GitHub and you’re not compiling the source release as I get a lot of these:
failure occured while calling class com.mycila.maven.plugin.license.git.CopyrightRangeProvider
java.lang.RuntimeException: Could not compute the year of the last git commit for file xxxxx
Thanks,
Justin
1. ./.mvn/wrapper/maven-wrapper.jar
2. .mvn/wrapper/MavenWrapperDownloader.java
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org