You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/08/08 23:57:43 UTC
Review Request 24511: Retry freeze in cgroups TasksKiller to workaround
MESOS-1689.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24511/
-----------------------------------------------------------
Review request for mesos, Ian Downes and Vinod Kone.
Repository: mesos-git
Description
-------
See ticket and summary.
Diffs
-----
src/linux/cgroups.cpp 39a4874
Diff: https://reviews.apache.org/r/24511/diff/
Testing
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 24511: Retry freeze in cgroups TasksKiller to workaround
MESOS-1689.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24511/#review50078
-----------------------------------------------------------
Ship it!
lgtm. i will let @iand give the final nod.
src/linux/cgroups.cpp
<https://reviews.apache.org/r/24511/#comment87606>
Can you add a blurb about why you want to do a freeze here?
- Vinod Kone
On Aug. 8, 2014, 9:59 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24511/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2014, 9:59 p.m.)
>
>
> Review request for mesos, Ian Downes and Vinod Kone.
>
>
> Bugs: MESOS-1689
> https://issues.apache.org/jira/browse/MESOS-1689
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See ticket and summary.
>
>
> Diffs
> -----
>
> src/linux/cgroups.cpp 39a4874
>
> Diff: https://reviews.apache.org/r/24511/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24511: Retry freeze in cgroups TasksKiller to workaround
MESOS-1689.
Posted by Jie Yu <yu...@gmail.com>.
> On Aug. 8, 2014, 10:07 p.m., Ian Downes wrote:
> > src/linux/cgroups.cpp, line 1480
> > <https://reviews.apache.org/r/24511/diff/1/?file=656793#file656793line1480>
> >
> > s/freezeTimedout/freezeTimedOut/ ?
We consistently use Timedout in our code base:)
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24511/#review50077
-----------------------------------------------------------
On Aug. 8, 2014, 9:59 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24511/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2014, 9:59 p.m.)
>
>
> Review request for mesos, Ian Downes and Vinod Kone.
>
>
> Bugs: MESOS-1689
> https://issues.apache.org/jira/browse/MESOS-1689
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See ticket and summary.
>
>
> Diffs
> -----
>
> src/linux/cgroups.cpp 39a4874
>
> Diff: https://reviews.apache.org/r/24511/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24511: Retry freeze in cgroups TasksKiller to workaround
MESOS-1689.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24511/#review50077
-----------------------------------------------------------
Ship it!
I'll file a ticket for exposing the overall failure to destroy a container as a metric.
src/linux/cgroups.cpp
<https://reviews.apache.org/r/24511/#comment87604>
s/freezeTimedout/freezeTimedOut/ ?
src/linux/cgroups.cpp
<https://reviews.apache.org/r/24511/#comment87605>
Expand this comment?
Thaw the cgroup before trying to freeze again to allow any pending signals to be delivered.
- Ian Downes
On Aug. 8, 2014, 2:59 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24511/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2014, 2:59 p.m.)
>
>
> Review request for mesos, Ian Downes and Vinod Kone.
>
>
> Bugs: MESOS-1689
> https://issues.apache.org/jira/browse/MESOS-1689
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See ticket and summary.
>
>
> Diffs
> -----
>
> src/linux/cgroups.cpp 39a4874
>
> Diff: https://reviews.apache.org/r/24511/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 24511: Retry freeze in cgroups TasksKiller to workaround
MESOS-1689.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24511/
-----------------------------------------------------------
(Updated Aug. 8, 2014, 9:59 p.m.)
Review request for mesos, Ian Downes and Vinod Kone.
Changes
-------
Added "Bugs" field.
Bugs: MESOS-1689
https://issues.apache.org/jira/browse/MESOS-1689
Repository: mesos-git
Description
-------
See ticket and summary.
Diffs
-----
src/linux/cgroups.cpp 39a4874
Diff: https://reviews.apache.org/r/24511/diff/
Testing
-------
sudo make check
Thanks,
Jie Yu