[GitHub] [pinot] kriti-sc commented on a change in pull request #7869: Ignore query options from commented out queries

[GitBox <gi...@apache.org>]

kriti-sc commented on a change in pull request #7869:
URL: https://github.com/apache/pinot/pull/7869#discussion_r764292020



##########
File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
##########
@@ -744,7 +746,11 @@ private static void applyAlias(Map<Identifier, Expression> aliasMap, Expression
 
   private static List<String> extractOptionsFromSql(String sql) {
     List<String> results = new ArrayList<>();
-    Matcher matcher = OPTIONS_REGEX_PATTEN.matcher(sql);
+    Matcher matcher = COMMENTED_QUERY_PATTERN.matcher(sql);
+    if (matcher.find()) {

Review comment:
       Makes sense, fixing this




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org