You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/14 12:59:23 UTC
[GitHub] [pulsar] nicoloboschi opened a new pull request, #17648: [fix][cli] Pulsar shell: support relative paths (cliextensions)
nicoloboschi opened a new pull request, #17648:
URL: https://github.com/apache/pulsar/pull/17648
### Motivation
The `pulsar-shell` script doesn't change the working directory to the Pulsar home one. In this way if you configure `cliExtensionsDirectory` with a relative path, it only works if you run pulsar-shell from the pulsar home directory. For instance `cd bin && ./pulsar-shell` is not able to find the cli extensions dir.
### Modifications
* Change directory to pulsar home before starting the java process (in this way it's the same as the other scripts)
The only disadvantage is that the `--file` autocompletion will suggest files from the Pulsar home directory and not from
the real working dir. (but it's still better than the current behaviour)
- [x] `doc-not-needed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli merged pull request #17648: [fix][cli] Pulsar shell: support relative paths (cliextensions)
Posted by GitBox <gi...@apache.org>.
eolivelli merged PR #17648:
URL: https://github.com/apache/pulsar/pull/17648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #17648: [fix][cli] Pulsar shell: support relative paths (cliextensions)
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #17648:
URL: https://github.com/apache/pulsar/pull/17648#issuecomment-1247768453
@eolivelli all the other scripts behave this way
https://github.com/apache/pulsar/blob/98cf15f3b822200781724342473b527db470ae6d/bin/pulsar-admin#L25
I agree that is not optimal but it's better to be consistent and do (if needed) the change for each script in the same pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org