You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ch...@apache.org on 2024/12/29 10:27:40 UTC
(kafka) 02/02: KAFKA-18359 Set zkConnect to null in LocalLeaderEndPointTest, HighwatermarkPersistenceTest, IsrExpirationTest, ReplicaManagerQuotasTest, OffsetsForLeaderEpochTest (#18344)
This is an automated email from the ASF dual-hosted git repository.
chia7712 pushed a commit to branch 4.0
in repository https://gitbox.apache.org/repos/asf/kafka.git
commit 2a391e4823e369ba4a92ac96b333fa7320dec981
Author: PoAn Yang <pa...@apache.org>
AuthorDate: Sun Dec 29 18:23:42 2024 +0800
KAFKA-18359 Set zkConnect to null in LocalLeaderEndPointTest, HighwatermarkPersistenceTest, IsrExpirationTest, ReplicaManagerQuotasTest, OffsetsForLeaderEpochTest (#18344)
Reviewers: TaiJuWu <tj...@gmail.com>, Chia-Ping Tsai <ch...@gmail.com>
---
core/src/test/scala/kafka/server/LocalLeaderEndPointTest.scala | 2 +-
.../src/test/scala/unit/kafka/server/HighwatermarkPersistenceTest.scala | 2 +-
core/src/test/scala/unit/kafka/server/IsrExpirationTest.scala | 2 +-
core/src/test/scala/unit/kafka/server/ReplicaManagerQuotasTest.scala | 2 +-
.../test/scala/unit/kafka/server/epoch/OffsetsForLeaderEpochTest.scala | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/core/src/test/scala/kafka/server/LocalLeaderEndPointTest.scala b/core/src/test/scala/kafka/server/LocalLeaderEndPointTest.scala
index 6832b3a0cf7..3b71ca01ba2 100644
--- a/core/src/test/scala/kafka/server/LocalLeaderEndPointTest.scala
+++ b/core/src/test/scala/kafka/server/LocalLeaderEndPointTest.scala
@@ -56,7 +56,7 @@ class LocalLeaderEndPointTest extends Logging {
@BeforeEach
def setUp(): Unit = {
- val props = TestUtils.createBrokerConfig(sourceBroker.id, TestUtils.MockZkConnect, port = sourceBroker.port)
+ val props = TestUtils.createBrokerConfig(sourceBroker.id, null, port = sourceBroker.port)
val config = KafkaConfig.fromProps(props)
val mockLogMgr = TestUtils.createLogManager(config.logDirs.map(new File(_)))
val alterPartitionManager = mock(classOf[AlterPartitionManager])
diff --git a/core/src/test/scala/unit/kafka/server/HighwatermarkPersistenceTest.scala b/core/src/test/scala/unit/kafka/server/HighwatermarkPersistenceTest.scala
index 506ceac074b..a5f294f378a 100755
--- a/core/src/test/scala/unit/kafka/server/HighwatermarkPersistenceTest.scala
+++ b/core/src/test/scala/unit/kafka/server/HighwatermarkPersistenceTest.scala
@@ -32,7 +32,7 @@ import org.apache.kafka.storage.internals.log.{CleanerConfig, LogDirFailureChann
class HighwatermarkPersistenceTest {
- val configs = TestUtils.createBrokerConfigs(2, TestUtils.MockZkConnect).map(KafkaConfig.fromProps)
+ val configs = TestUtils.createBrokerConfigs(2, null).map(KafkaConfig.fromProps)
val topic = "foo"
val configRepository = new MockConfigRepository()
val logManagers = configs map { config =>
diff --git a/core/src/test/scala/unit/kafka/server/IsrExpirationTest.scala b/core/src/test/scala/unit/kafka/server/IsrExpirationTest.scala
index d34e72148b5..f82e14c6e0f 100644
--- a/core/src/test/scala/unit/kafka/server/IsrExpirationTest.scala
+++ b/core/src/test/scala/unit/kafka/server/IsrExpirationTest.scala
@@ -47,7 +47,7 @@ class IsrExpirationTest {
val overridingProps = new Properties()
overridingProps.put(ReplicationConfigs.REPLICA_LAG_TIME_MAX_MS_CONFIG, replicaLagTimeMaxMs.toString)
overridingProps.put(ReplicationConfigs.REPLICA_FETCH_WAIT_MAX_MS_CONFIG, replicaFetchWaitMaxMs.toString)
- val configs = TestUtils.createBrokerConfigs(2, TestUtils.MockZkConnect).map(KafkaConfig.fromProps(_, overridingProps))
+ val configs = TestUtils.createBrokerConfigs(2, null).map(KafkaConfig.fromProps(_, overridingProps))
val topic = "foo"
val time = new MockTime
diff --git a/core/src/test/scala/unit/kafka/server/ReplicaManagerQuotasTest.scala b/core/src/test/scala/unit/kafka/server/ReplicaManagerQuotasTest.scala
index fd395257598..2690bcfdc65 100644
--- a/core/src/test/scala/unit/kafka/server/ReplicaManagerQuotasTest.scala
+++ b/core/src/test/scala/unit/kafka/server/ReplicaManagerQuotasTest.scala
@@ -42,7 +42,7 @@ import org.mockito.{AdditionalMatchers, ArgumentMatchers}
import scala.jdk.CollectionConverters._
class ReplicaManagerQuotasTest {
- val configs = TestUtils.createBrokerConfigs(2, TestUtils.MockZkConnect).map(KafkaConfig.fromProps(_, new Properties()))
+ val configs = TestUtils.createBrokerConfigs(2, null).map(KafkaConfig.fromProps(_, new Properties()))
val time = new MockTime
val metrics = new Metrics
val record = new SimpleRecord("some-data-in-a-message".getBytes())
diff --git a/core/src/test/scala/unit/kafka/server/epoch/OffsetsForLeaderEpochTest.scala b/core/src/test/scala/unit/kafka/server/epoch/OffsetsForLeaderEpochTest.scala
index 434ce24b92f..13c018cf345 100644
--- a/core/src/test/scala/unit/kafka/server/epoch/OffsetsForLeaderEpochTest.scala
+++ b/core/src/test/scala/unit/kafka/server/epoch/OffsetsForLeaderEpochTest.scala
@@ -38,7 +38,7 @@ import org.mockito.Mockito.{mock, when}
import scala.jdk.CollectionConverters._
class OffsetsForLeaderEpochTest {
- private val config = TestUtils.createBrokerConfigs(1, TestUtils.MockZkConnect).map(KafkaConfig.fromProps).head
+ private val config = TestUtils.createBrokerConfigs(1, null).map(KafkaConfig.fromProps).head
private val time = new MockTime
private val metrics = new Metrics
private val alterIsrManager = TestUtils.createAlterIsrManager()