[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #3048: Support to get the real client ip address when using VIP as kyuubi server load balancer

[GitBox <gi...@apache.org>]

yaooqinn commented on code in PR #3048:
URL: https://github.com/apache/incubator-kyuubi/pull/3048#discussion_r919590995


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiReservedKeys.scala:
##########
@@ -19,6 +19,7 @@ package org.apache.kyuubi.config
 
 object KyuubiReservedKeys {
   final val KYUUBI_SESSION_USER_KEY = "kyuubi.session.user"
+  final val KYUUBI_SESSION_IP_KEY = "kyuubi.session.ip"

Review Comment:
   we have `kyuubi.client.ip` already, how about using this?
   
   maybe  kyuubi.client.ipAddress is better



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org