You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fory.apache.org by "LiangliangSui (via GitHub)" <gi...@apache.org> on 2025/12/04 07:11:15 UTC

[PR] docs: update the C++ benchmark case [fory]

LiangliangSui opened a new pull request, #2988:
URL: https://github.com/apache/fory/pull/2988

   <!--
   **Thanks for contributing to Apache Fory™.**
   
   **If this is your first time opening a PR on fory, you can refer to [CONTRIBUTING.md](https://github.com/apache/fory/blob/main/CONTRIBUTING.md).**
   
   Contribution Checklist
   
       - The **Apache Fory™** community has requirements on the naming of pr titles. You can also find instructions in [CONTRIBUTING.md](https://github.com/apache/fory/blob/main/CONTRIBUTING.md).
   
       - Apache Fory™ has a strong focus on performance. If the PR you submit will have an impact on performance, please benchmark it first and provide the benchmark result here.
   -->
   
   ## Why?
   
   <!-- Describe the purpose of this PR. -->
   
   ## What does this PR do?
   
   <!-- Describe the details of this PR. -->
   update the C++ benchmark case doc
   
   ## Related issues
   
   <!--
   Is there any related issue? If this PR closes them you say say fix/closes:
   
   - #xxxx0
   - #xxxx1
   - Fixes #xxxx2
   -->
   
   ## Does this PR introduce any user-facing change?
   
   <!--
   If any user-facing interface changes, please [open an issue](https://github.com/apache/fory/issues/new/choose) describing the need to do so and update the document if necessary.
   
   Delete section if not applicable.
   -->
   
   - [ ] Does this PR introduce any public API change?
   - [ ] Does this PR introduce any binary protocol compatibility change?
   
   ## Benchmark
   
   <!--
   When the PR has an impact on performance (if you don't know whether the PR will have an impact on performance, you can submit the PR first, and if it will have impact on performance, the code reviewer will explain it), be sure to attach a benchmark data here.
   
   Delete section if not applicable.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org


Re: [PR] docs: update the C++ benchmark case [fory]

Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on code in PR #2988:
URL: https://github.com/apache/fory/pull/2988#discussion_r2588432661


##########
benchmarks/cpp_benchmark/README.md:
##########
@@ -59,16 +59,21 @@ cmake --build . -j$(nproc)
 
 ## Benchmark Cases
 
-| Benchmark                        | Description                                                         |
-| -------------------------------- | ------------------------------------------------------------------- |
-| `BM_Fory_Struct_Serialize`       | Serialize a simple struct with 8 int32 fields using Fory            |
-| `BM_Protobuf_Struct_Serialize`   | Serialize the same struct using Protobuf                            |
-| `BM_Fory_Struct_Deserialize`     | Deserialize a simple struct using Fory                              |
-| `BM_Protobuf_Struct_Deserialize` | Deserialize the same struct using Protobuf                          |
-| `BM_Fory_Sample_Serialize`       | Serialize a complex object with various types and arrays using Fory |
-| `BM_Protobuf_Sample_Serialize`   | Serialize the same object using Protobuf                            |
-| `BM_Fory_Sample_Deserialize`     | Deserialize a complex object using Fory                             |
-| `BM_Protobuf_Sample_Deserialize` | Deserialize the same object using Protobuf                          |
+| Benchmark                             | Description                                                         |
+| ------------------------------------- | ------------------------------------------------------------------- |
+| `BM_Fory_Struct_Serialize`            | Serialize a simple struct with 8 int32 fields using Fory            |
+| `BM_Protobuf_Struct_Serialize`        | Serialize the same struct using Protobuf                            |
+| `BM_Fory_Struct_Deserialize`          | Deserialize a simple struct using Fory                              |
+| `BM_Protobuf_Struct_Deserialize`      | Deserialize the same struct using Protobuf                          |
+| `BM_Fory_Sample_Serialize`            | Serialize a complex object with various types and arrays using Fory |
+| `BM_Protobuf_Sample_Serialize`        | Serialize the same object using Protobuf                            |
+| `BM_Fory_Sample_Deserialize`          | Deserialize a complex object using Fory                             |
+| `BM_Protobuf_Sample_Deserialize`      | Deserialize the same object using Protobuf                          |
+| `BM_Fory_MediaContent_Serialize`      | Serialize a complex object with Media and Images using Fory         |
+| `BM_Protobuf_MediaContent_Serialize`  | Serialize the same object using Protobuf                            |
+| `BM_Fory_MediaContent_Deserialize`    | Deserialize a complex object with Media and Images using Fory       |
+| `BM_Protobuf_MediaContent_Deserialize`| Deserialize the same object using Protobuf                          |

Review Comment:
   Let's start with copilot first, and change to Gemini in the future



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org


Re: [PR] docs: update the C++ benchmark case [fory]

Posted by "LiangliangSui (via GitHub)" <gi...@apache.org>.
LiangliangSui commented on code in PR #2988:
URL: https://github.com/apache/fory/pull/2988#discussion_r2588015939


##########
benchmarks/cpp_benchmark/README.md:
##########
@@ -59,16 +59,21 @@ cmake --build . -j$(nproc)
 
 ## Benchmark Cases
 
-| Benchmark                        | Description                                                         |
-| -------------------------------- | ------------------------------------------------------------------- |
-| `BM_Fory_Struct_Serialize`       | Serialize a simple struct with 8 int32 fields using Fory            |
-| `BM_Protobuf_Struct_Serialize`   | Serialize the same struct using Protobuf                            |
-| `BM_Fory_Struct_Deserialize`     | Deserialize a simple struct using Fory                              |
-| `BM_Protobuf_Struct_Deserialize` | Deserialize the same struct using Protobuf                          |
-| `BM_Fory_Sample_Serialize`       | Serialize a complex object with various types and arrays using Fory |
-| `BM_Protobuf_Sample_Serialize`   | Serialize the same object using Protobuf                            |
-| `BM_Fory_Sample_Deserialize`     | Deserialize a complex object using Fory                             |
-| `BM_Protobuf_Sample_Deserialize` | Deserialize the same object using Protobuf                          |
+| Benchmark                             | Description                                                         |
+| ------------------------------------- | ------------------------------------------------------------------- |
+| `BM_Fory_Struct_Serialize`            | Serialize a simple struct with 8 int32 fields using Fory            |
+| `BM_Protobuf_Struct_Serialize`        | Serialize the same struct using Protobuf                            |
+| `BM_Fory_Struct_Deserialize`          | Deserialize a simple struct using Fory                              |
+| `BM_Protobuf_Struct_Deserialize`      | Deserialize the same struct using Protobuf                          |
+| `BM_Fory_Sample_Serialize`            | Serialize a complex object with various types and arrays using Fory |
+| `BM_Protobuf_Sample_Serialize`        | Serialize the same object using Protobuf                            |
+| `BM_Fory_Sample_Deserialize`          | Deserialize a complex object using Fory                             |
+| `BM_Protobuf_Sample_Deserialize`      | Deserialize the same object using Protobuf                          |
+| `BM_Fory_MediaContent_Serialize`      | Serialize a complex object with Media and Images using Fory         |
+| `BM_Protobuf_MediaContent_Serialize`  | Serialize the same object using Protobuf                            |
+| `BM_Fory_MediaContent_Deserialize`    | Deserialize a complex object with Media and Images using Fory       |
+| `BM_Protobuf_MediaContent_Deserialize`| Deserialize the same object using Protobuf                          |

Review Comment:
   Done. I think it's possible to configure Copilot to be included in the reviewers by default, at least for document reviews, which would be helpful.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org


Re: [PR] docs: update the C++ benchmark case [fory]

Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on code in PR #2988:
URL: https://github.com/apache/fory/pull/2988#discussion_r2588113070


##########
benchmarks/cpp_benchmark/README.md:
##########
@@ -59,16 +59,21 @@ cmake --build . -j$(nproc)
 
 ## Benchmark Cases
 
-| Benchmark                        | Description                                                         |
-| -------------------------------- | ------------------------------------------------------------------- |
-| `BM_Fory_Struct_Serialize`       | Serialize a simple struct with 8 int32 fields using Fory            |
-| `BM_Protobuf_Struct_Serialize`   | Serialize the same struct using Protobuf                            |
-| `BM_Fory_Struct_Deserialize`     | Deserialize a simple struct using Fory                              |
-| `BM_Protobuf_Struct_Deserialize` | Deserialize the same struct using Protobuf                          |
-| `BM_Fory_Sample_Serialize`       | Serialize a complex object with various types and arrays using Fory |
-| `BM_Protobuf_Sample_Serialize`   | Serialize the same object using Protobuf                            |
-| `BM_Fory_Sample_Deserialize`     | Deserialize a complex object using Fory                             |
-| `BM_Protobuf_Sample_Deserialize` | Deserialize the same object using Protobuf                          |
+| Benchmark                             | Description                                                         |
+| ------------------------------------- | ------------------------------------------------------------------- |
+| `BM_Fory_Struct_Serialize`            | Serialize a simple struct with 8 int32 fields using Fory            |
+| `BM_Protobuf_Struct_Serialize`        | Serialize the same struct using Protobuf                            |
+| `BM_Fory_Struct_Deserialize`          | Deserialize a simple struct using Fory                              |
+| `BM_Protobuf_Struct_Deserialize`      | Deserialize the same struct using Protobuf                          |
+| `BM_Fory_Sample_Serialize`            | Serialize a complex object with various types and arrays using Fory |
+| `BM_Protobuf_Sample_Serialize`        | Serialize the same object using Protobuf                            |
+| `BM_Fory_Sample_Deserialize`          | Deserialize a complex object using Fory                             |
+| `BM_Protobuf_Sample_Deserialize`      | Deserialize the same object using Protobuf                          |
+| `BM_Fory_MediaContent_Serialize`      | Serialize a complex object with Media and Images using Fory         |
+| `BM_Protobuf_MediaContent_Serialize`  | Serialize the same object using Protobuf                            |
+| `BM_Fory_MediaContent_Deserialize`    | Deserialize a complex object with Media and Images using Fory       |
+| `BM_Protobuf_MediaContent_Deserialize`| Deserialize the same object using Protobuf                          |

Review Comment:
   Do you know how to do that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org


Re: [PR] docs: update the C++ benchmark case [fory]

Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang merged PR #2988:
URL: https://github.com/apache/fory/pull/2988


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org


Re: [PR] docs: update the C++ benchmark case [fory]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #2988:
URL: https://github.com/apache/fory/pull/2988#discussion_r2587851935


##########
benchmarks/cpp_benchmark/README.md:
##########
@@ -59,16 +59,21 @@ cmake --build . -j$(nproc)
 
 ## Benchmark Cases
 
-| Benchmark                        | Description                                                         |
-| -------------------------------- | ------------------------------------------------------------------- |
-| `BM_Fory_Struct_Serialize`       | Serialize a simple struct with 8 int32 fields using Fory            |
-| `BM_Protobuf_Struct_Serialize`   | Serialize the same struct using Protobuf                            |
-| `BM_Fory_Struct_Deserialize`     | Deserialize a simple struct using Fory                              |
-| `BM_Protobuf_Struct_Deserialize` | Deserialize the same struct using Protobuf                          |
-| `BM_Fory_Sample_Serialize`       | Serialize a complex object with various types and arrays using Fory |
-| `BM_Protobuf_Sample_Serialize`   | Serialize the same object using Protobuf                            |
-| `BM_Fory_Sample_Deserialize`     | Deserialize a complex object using Fory                             |
-| `BM_Protobuf_Sample_Deserialize` | Deserialize the same object using Protobuf                          |
+| Benchmark                             | Description                                                         |
+| ------------------------------------- | ------------------------------------------------------------------- |
+| `BM_Fory_Struct_Serialize`            | Serialize a simple struct with 8 int32 fields using Fory            |
+| `BM_Protobuf_Struct_Serialize`        | Serialize the same struct using Protobuf                            |
+| `BM_Fory_Struct_Deserialize`          | Deserialize a simple struct using Fory                              |
+| `BM_Protobuf_Struct_Deserialize`      | Deserialize the same struct using Protobuf                          |
+| `BM_Fory_Sample_Serialize`            | Serialize a complex object with various types and arrays using Fory |
+| `BM_Protobuf_Sample_Serialize`        | Serialize the same object using Protobuf                            |
+| `BM_Fory_Sample_Deserialize`          | Deserialize a complex object using Fory                             |
+| `BM_Protobuf_Sample_Deserialize`      | Deserialize the same object using Protobuf                          |
+| `BM_Fory_MediaContent_Serialize`      | Serialize a complex object with Media and Images using Fory         |
+| `BM_Protobuf_MediaContent_Serialize`  | Serialize the same object using Protobuf                            |
+| `BM_Fory_MediaContent_Deserialize`    | Deserialize a complex object with Media and Images using Fory       |
+| `BM_Protobuf_MediaContent_Deserialize`| Deserialize the same object using Protobuf                          |

Review Comment:
   Missing space after the pipe character before "Deserialize". The table cell separator should have proper spacing for consistency with other rows.
   ```suggestion
   | `BM_Protobuf_MediaContent_Deserialize` | Deserialize the same object using Protobuf                          |
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org


Re: [PR] docs: update the C++ benchmark case [fory]

Posted by "LiangliangSui (via GitHub)" <gi...@apache.org>.
LiangliangSui commented on code in PR #2988:
URL: https://github.com/apache/fory/pull/2988#discussion_r2588367635


##########
benchmarks/cpp_benchmark/README.md:
##########
@@ -59,16 +59,21 @@ cmake --build . -j$(nproc)
 
 ## Benchmark Cases
 
-| Benchmark                        | Description                                                         |
-| -------------------------------- | ------------------------------------------------------------------- |
-| `BM_Fory_Struct_Serialize`       | Serialize a simple struct with 8 int32 fields using Fory            |
-| `BM_Protobuf_Struct_Serialize`   | Serialize the same struct using Protobuf                            |
-| `BM_Fory_Struct_Deserialize`     | Deserialize a simple struct using Fory                              |
-| `BM_Protobuf_Struct_Deserialize` | Deserialize the same struct using Protobuf                          |
-| `BM_Fory_Sample_Serialize`       | Serialize a complex object with various types and arrays using Fory |
-| `BM_Protobuf_Sample_Serialize`   | Serialize the same object using Protobuf                            |
-| `BM_Fory_Sample_Deserialize`     | Deserialize a complex object using Fory                             |
-| `BM_Protobuf_Sample_Deserialize` | Deserialize the same object using Protobuf                          |
+| Benchmark                             | Description                                                         |
+| ------------------------------------- | ------------------------------------------------------------------- |
+| `BM_Fory_Struct_Serialize`            | Serialize a simple struct with 8 int32 fields using Fory            |
+| `BM_Protobuf_Struct_Serialize`        | Serialize the same struct using Protobuf                            |
+| `BM_Fory_Struct_Deserialize`          | Deserialize a simple struct using Fory                              |
+| `BM_Protobuf_Struct_Deserialize`      | Deserialize the same struct using Protobuf                          |
+| `BM_Fory_Sample_Serialize`            | Serialize a complex object with various types and arrays using Fory |
+| `BM_Protobuf_Sample_Serialize`        | Serialize the same object using Protobuf                            |
+| `BM_Fory_Sample_Deserialize`          | Deserialize a complex object using Fory                             |
+| `BM_Protobuf_Sample_Deserialize`      | Deserialize the same object using Protobuf                          |
+| `BM_Fory_MediaContent_Serialize`      | Serialize a complex object with Media and Images using Fory         |
+| `BM_Protobuf_MediaContent_Serialize`  | Serialize the same object using Protobuf                            |
+| `BM_Fory_MediaContent_Deserialize`    | Deserialize a complex object with Media and Images using Fory       |
+| `BM_Protobuf_MediaContent_Deserialize`| Deserialize the same object using Protobuf                          |

Review Comment:
   Gemini-Code-Assist requires account integration, which might not be very friendly for GitHub. We might need to apply for a Google account for fory



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org


Re: [PR] docs: update the C++ benchmark case [fory]

Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on code in PR #2988:
URL: https://github.com/apache/fory/pull/2988#discussion_r2588315254


##########
benchmarks/cpp_benchmark/README.md:
##########
@@ -59,16 +59,21 @@ cmake --build . -j$(nproc)
 
 ## Benchmark Cases
 
-| Benchmark                        | Description                                                         |
-| -------------------------------- | ------------------------------------------------------------------- |
-| `BM_Fory_Struct_Serialize`       | Serialize a simple struct with 8 int32 fields using Fory            |
-| `BM_Protobuf_Struct_Serialize`   | Serialize the same struct using Protobuf                            |
-| `BM_Fory_Struct_Deserialize`     | Deserialize a simple struct using Fory                              |
-| `BM_Protobuf_Struct_Deserialize` | Deserialize the same struct using Protobuf                          |
-| `BM_Fory_Sample_Serialize`       | Serialize a complex object with various types and arrays using Fory |
-| `BM_Protobuf_Sample_Serialize`   | Serialize the same object using Protobuf                            |
-| `BM_Fory_Sample_Deserialize`     | Deserialize a complex object using Fory                             |
-| `BM_Protobuf_Sample_Deserialize` | Deserialize the same object using Protobuf                          |
+| Benchmark                             | Description                                                         |
+| ------------------------------------- | ------------------------------------------------------------------- |
+| `BM_Fory_Struct_Serialize`            | Serialize a simple struct with 8 int32 fields using Fory            |
+| `BM_Protobuf_Struct_Serialize`        | Serialize the same struct using Protobuf                            |
+| `BM_Fory_Struct_Deserialize`          | Deserialize a simple struct using Fory                              |
+| `BM_Protobuf_Struct_Deserialize`      | Deserialize the same struct using Protobuf                          |
+| `BM_Fory_Sample_Serialize`            | Serialize a complex object with various types and arrays using Fory |
+| `BM_Protobuf_Sample_Serialize`        | Serialize the same object using Protobuf                            |
+| `BM_Fory_Sample_Deserialize`          | Deserialize a complex object using Fory                             |
+| `BM_Protobuf_Sample_Deserialize`      | Deserialize the same object using Protobuf                          |
+| `BM_Fory_MediaContent_Serialize`      | Serialize a complex object with Media and Images using Fory         |
+| `BM_Protobuf_MediaContent_Serialize`  | Serialize the same object using Protobuf                            |
+| `BM_Fory_MediaContent_Deserialize`    | Deserialize a complex object with Media and Images using Fory       |
+| `BM_Protobuf_MediaContent_Deserialize`| Deserialize the same object using Protobuf                          |

Review Comment:
   gemini-code-assist is better, it would be nice to have it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org


Re: [PR] docs: update the C++ benchmark case [fory]

Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on code in PR #2988:
URL: https://github.com/apache/fory/pull/2988#discussion_r2587991805


##########
benchmarks/cpp_benchmark/README.md:
##########
@@ -59,16 +59,21 @@ cmake --build . -j$(nproc)
 
 ## Benchmark Cases
 
-| Benchmark                        | Description                                                         |
-| -------------------------------- | ------------------------------------------------------------------- |
-| `BM_Fory_Struct_Serialize`       | Serialize a simple struct with 8 int32 fields using Fory            |
-| `BM_Protobuf_Struct_Serialize`   | Serialize the same struct using Protobuf                            |
-| `BM_Fory_Struct_Deserialize`     | Deserialize a simple struct using Fory                              |
-| `BM_Protobuf_Struct_Deserialize` | Deserialize the same struct using Protobuf                          |
-| `BM_Fory_Sample_Serialize`       | Serialize a complex object with various types and arrays using Fory |
-| `BM_Protobuf_Sample_Serialize`   | Serialize the same object using Protobuf                            |
-| `BM_Fory_Sample_Deserialize`     | Deserialize a complex object using Fory                             |
-| `BM_Protobuf_Sample_Deserialize` | Deserialize the same object using Protobuf                          |
+| Benchmark                             | Description                                                         |
+| ------------------------------------- | ------------------------------------------------------------------- |
+| `BM_Fory_Struct_Serialize`            | Serialize a simple struct with 8 int32 fields using Fory            |
+| `BM_Protobuf_Struct_Serialize`        | Serialize the same struct using Protobuf                            |
+| `BM_Fory_Struct_Deserialize`          | Deserialize a simple struct using Fory                              |
+| `BM_Protobuf_Struct_Deserialize`      | Deserialize the same struct using Protobuf                          |
+| `BM_Fory_Sample_Serialize`            | Serialize a complex object with various types and arrays using Fory |
+| `BM_Protobuf_Sample_Serialize`        | Serialize the same object using Protobuf                            |
+| `BM_Fory_Sample_Deserialize`          | Deserialize a complex object using Fory                             |
+| `BM_Protobuf_Sample_Deserialize`      | Deserialize the same object using Protobuf                          |
+| `BM_Fory_MediaContent_Serialize`      | Serialize a complex object with Media and Images using Fory         |
+| `BM_Protobuf_MediaContent_Serialize`  | Serialize the same object using Protobuf                            |
+| `BM_Fory_MediaContent_Deserialize`    | Deserialize a complex object with Media and Images using Fory       |
+| `BM_Protobuf_MediaContent_Deserialize`| Deserialize the same object using Protobuf                          |

Review Comment:
   @LiangliangSui could you add spaces and format file?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org


Re: [PR] docs: update the C++ benchmark case [fory]

Posted by "LiangliangSui (via GitHub)" <gi...@apache.org>.
LiangliangSui commented on code in PR #2988:
URL: https://github.com/apache/fory/pull/2988#discussion_r2588067635


##########
benchmarks/cpp_benchmark/README.md:
##########
@@ -59,16 +59,21 @@ cmake --build . -j$(nproc)
 
 ## Benchmark Cases
 
-| Benchmark                        | Description                                                         |
-| -------------------------------- | ------------------------------------------------------------------- |
-| `BM_Fory_Struct_Serialize`       | Serialize a simple struct with 8 int32 fields using Fory            |
-| `BM_Protobuf_Struct_Serialize`   | Serialize the same struct using Protobuf                            |
-| `BM_Fory_Struct_Deserialize`     | Deserialize a simple struct using Fory                              |
-| `BM_Protobuf_Struct_Deserialize` | Deserialize the same struct using Protobuf                          |
-| `BM_Fory_Sample_Serialize`       | Serialize a complex object with various types and arrays using Fory |
-| `BM_Protobuf_Sample_Serialize`   | Serialize the same object using Protobuf                            |
-| `BM_Fory_Sample_Deserialize`     | Deserialize a complex object using Fory                             |
-| `BM_Protobuf_Sample_Deserialize` | Deserialize the same object using Protobuf                          |
+| Benchmark                             | Description                                                         |
+| ------------------------------------- | ------------------------------------------------------------------- |
+| `BM_Fory_Struct_Serialize`            | Serialize a simple struct with 8 int32 fields using Fory            |
+| `BM_Protobuf_Struct_Serialize`        | Serialize the same struct using Protobuf                            |
+| `BM_Fory_Struct_Deserialize`          | Deserialize a simple struct using Fory                              |
+| `BM_Protobuf_Struct_Deserialize`      | Deserialize the same struct using Protobuf                          |
+| `BM_Fory_Sample_Serialize`            | Serialize a complex object with various types and arrays using Fory |
+| `BM_Protobuf_Sample_Serialize`        | Serialize the same object using Protobuf                            |
+| `BM_Fory_Sample_Deserialize`          | Deserialize a complex object using Fory                             |
+| `BM_Protobuf_Sample_Deserialize`      | Deserialize the same object using Protobuf                          |
+| `BM_Fory_MediaContent_Serialize`      | Serialize a complex object with Media and Images using Fory         |
+| `BM_Protobuf_MediaContent_Serialize`  | Serialize the same object using Protobuf                            |
+| `BM_Fory_MediaContent_Deserialize`    | Deserialize a complex object with Media and Images using Fory       |
+| `BM_Protobuf_MediaContent_Deserialize`| Deserialize the same object using Protobuf                          |

Review Comment:
   > Done. I think it's possible to configure Copilot to be included in the reviewers by default, at least for document reviews, which would be helpful.
   
   @chaokunyang  how about this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org