You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "mengw15 (via GitHub)" <gi...@apache.org> on 2026/05/08 20:49:43 UTC
[PR] refactor(amber): stop hardcoding S3 in REST catalog init [texera]
mengw15 opened a new pull request, #4988:
URL: https://github.com/apache/texera/pull/4988
### What changes were proposed in this PR?
`IcebergUtil.createRestCatalog` (Scala) and
`iceberg_utils.create_rest_catalog` (Python) no longer hardcode
`s3.endpoint`, `s3.region`, `s3.path-style-access`, `s3.access-key-id` or
`s3.secret-access-key` at catalog initialization. Both helpers now pass
only `warehouse`, the catalog `uri`, and (Scala only) the FileIO
implementation hint; the REST catalog server stays the source of truth for
S3 settings.
| Before | After |
| --- | --- |
| Both helpers passed system `StorageConfig.s3*` / `StorageConfig.S3_*` at init | Both helpers pass only catalog-side settings |
| Hardcoded creds were inert under remote-signing (Lakekeeper returns `s3.remote-signing-enabled: true`, which makes both Iceberg `S3FileIO` and pyiceberg `FsspecFileIO` ignore them) | Server-provided settings are the only ones in play |
| Same system bucket assumed for every warehouse | Per-warehouse storage isolation becomes possible |
`StorageConfig.s3*` / `StorageConfig.S3_*` are kept — they continue to
flow into Python via `PythonWorkflowWorker` and are consumed by
`pytexera/storage/large_binary_manager.py` (boto3 client for the
non-Iceberg `texera-large-binaries` bucket, used for R UDF large binary
support). That bucket is out of scope for this PR.
### Any related issues, documentation, discussions?
Closes #4987
### How was this PR tested?
```
sbt "WorkflowCore/compile"
[success] Total time: 10 s
```
Python edits were syntax-checked via `ast.parse` — both files parse
cleanly.
This is a dead-code removal: the compile step verifies no remaining caller
depends on the removed Scala properties; the Python
`iceberg_utils.create_rest_catalog` signature change is reflected in its
only caller (`iceberg_catalog_instance.py`). Runtime behavior is unchanged
because the catalog server's `s3.remote-signing-enabled: true` already
caused both clients to ignore the locally-configured credentials.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.7)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(amber): stop hardcoding S3 in REST catalog init [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4988:
URL: https://github.com/apache/texera/pull/4988#issuecomment-4409770046
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/4988?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 42.74%. Comparing base ([`6832cfa`](https://app.codecov.io/gh/apache/texera/commit/6832cfa418e56ce4197415b382cc4c8b91559b27?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`de6d9b2`](https://app.codecov.io/gh/apache/texera/commit/de6d9b20e88d3f06a5a9464f4813cd056da38088?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #4988 +/- ##
============================================
+ Coverage 42.73% 42.74% +0.01%
Complexity 2188 2188
============================================
Files 1031 1031
Lines 38152 38143 -9
Branches 4004 4004
============================================
Hits 16306 16306
+ Misses 20828 20819 -9
Partials 1018 1018
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/4988/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/4988/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.53% <ø> (ø)` | | |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/4988/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.72% <ø> (ø)` | | Carriedforward from [6832cfa](https://app.codecov.io/gh/apache/texera/commit/6832cfa418e56ce4197415b382cc4c8b91559b27?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/4988/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.27% <ø> (+0.02%)` | :arrow_up: | Carriedforward from [6832cfa](https://app.codecov.io/gh/apache/texera/commit/6832cfa418e56ce4197415b382cc4c8b91559b27?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/4988/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/4988/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/4988/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.18% <ø> (ø)` | | Carriedforward from [6832cfa](https://app.codecov.io/gh/apache/texera/commit/6832cfa418e56ce4197415b382cc4c8b91559b27?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/4988/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.08% <ø> (ø)` | | Carriedforward from [6832cfa](https://app.codecov.io/gh/apache/texera/commit/6832cfa418e56ce4197415b382cc4c8b91559b27?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [python](https://app.codecov.io/gh/apache/texera/pull/4988/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `88.90% <ø> (ø)` | | Carriedforward from [6832cfa](https://app.codecov.io/gh/apache/texera/commit/6832cfa418e56ce4197415b382cc4c8b91559b27?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/4988/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.72% <ø> (ø)` | | Carriedforward from [6832cfa](https://app.codecov.io/gh/apache/texera/commit/6832cfa418e56ce4197415b382cc4c8b91559b27?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/texera/pull/4988?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(amber): stop hardcoding S3 in REST catalog init [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #4988:
URL: https://github.com/apache/texera/pull/4988#issuecomment-4410633039
Thanks @mengw15 can you make the description a bit concise about why this change is needed? Also please add tests to confirm this change works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(amber): stop hardcoding S3 in REST catalog init [texera]
Posted by "mengw15 (via GitHub)" <gi...@apache.org>.
mengw15 commented on PR #4988:
URL: https://github.com/apache/texera/pull/4988#issuecomment-4464159797
> Yes integration test is for now designed not to alter coverage report: we rely on unit tests.
The unit test I added in IcebergUtilSpec is coverage-only — without a running Lakekeeper, RESTCatalog wraps the connection failure into RESTException
The PR's real semantics (client sends only warehouse + uri, Lakekeeper resolves S3 config from the warehouse record) can only be verified end-to-end against a running Lakekeeper. That's what IcebergRestCatalogIntegrationSpec covers in amber-integration.
For a real test in a coverage-uploading job, we'd need to add Lakekeeper (+ MinIO + Postgres) to the amber job — basically duplicating the service setup that amber-integration already does. Want me to do that, or is the current coverage-only test fine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(amber): stop hardcoding S3 in REST catalog init [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #4988:
URL: https://github.com/apache/texera/pull/4988#issuecomment-4424975947
Yes integration test is for now designed not to alter coverage report: we rely on unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(amber): stop hardcoding S3 in REST catalog init [texera]
Posted by "mengw15 (via GitHub)" <gi...@apache.org>.
mengw15 commented on code in PR #4988:
URL: https://github.com/apache/texera/pull/4988#discussion_r3253205504
##########
common/workflow-core/src/test/scala/org/apache/texera/amber/util/IcebergUtilSpec.scala:
##########
@@ -298,4 +299,13 @@ class IcebergUtilSpec extends AnyFlatSpec {
assert(IcebergUtil.fromRecord(record, schema) == tuple)
}
+
+ it should "build REST catalog properties without S3 settings" in {
Review Comment:
The name comes from this PR's change — `createRestCatalog` used to take S3 settings and no longer does, so the test exercises that new no-S3 call. Fair point that this isn't obvious without the PR context; will rename to describe what the assertion actually checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(amber): stop hardcoding S3 in REST catalog init [texera]
Posted by "mengw15 (via GitHub)" <gi...@apache.org>.
mengw15 commented on PR #4988:
URL: https://github.com/apache/texera/pull/4988#issuecomment-4420862329
> now as #4276 is merged, can we hook up with new tests?
With #4276 merged, which brought over the Lakekeeper CI job and the two integration tests.
These two tests are testing the createRestCatalog in Scala and python. so this PR is covered end-to-end. With CI passed, I think we can confirm that this change works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(amber): stop hardcoding S3 in REST catalog init [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #4988:
URL: https://github.com/apache/texera/pull/4988#issuecomment-4422961554
> These two tests are testing the createRestCatalog in Scala and python. so this PR is covered end-to-end. With CI passed, I think we can confirm that this change works.
sg. thanks! let's also make sure the coverage is filled
><!DOCTYPE html><head></head><p dir="auto" style="box-sizing: border-box; margin-top: 0px; margin-bottom: var(--base-size-16);">❌ Patch coverage is<span class="Apple-converted-space"> </span><code class="notranslate" style="box-sizing: border-box; font-family: var(--fontStack-monospace,ui-monospace, SFMono-Regular, SF Mono, Menlo, Consolas, Liberation Mono, monospace); font-size: 11.9px; tab-size: var(--tab-size-preference); white-space: break-spaces; background-color: var(--bgColor-neutral-muted,var(--color-neutral-muted)); border-radius: 6px; margin: 0px; padding: 0.2em 0.4em;">0%</code><span class="Apple-converted-space"> </span>with<span class="Apple-converted-space"> </span><code class="notranslate" style="box-sizing: border-box; font-family: var(--fontStack-monospace,ui-monospace, SFMono-Regular, SF Mono, Menlo, Consolas, Liberation Mono, monospace); font-size: 11.9px; tab-size: var(--tab-size-preference); white-space: break-spaces; background-color: var(--bgColor-neutr
al-muted,var(--color-neutral-muted)); border-radius: 6px; margin: 0px; padding: 0.2em 0.4em;">3 lines</code><span class="Apple-converted-space"> </span>in your changes missing coverage. Please review.<br style="box-sizing: border-box;">✅ Project coverage is 42.75%. Comparing base (<a href="https://app.codecov.io/gh/apache/texera/commit/14f8be4c0856dd9f0be2aa594bdfe46a92f9d4cd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache" rel="nofollow" style="box-sizing: border-box; background-color: rgba(0, 0, 0, 0); color: var(--fgColor-accent,var(--color-accent-fg)); text-decoration: underline; text-underline-offset: 0.2rem;"><code class="notranslate" style="box-sizing: border-box; font-family: var(--fontStack-monospace,ui-monospace, SFMono-Regular, SF Mono, Menlo, Consolas, Liberation Mono, monospace); font-size: 11.9px; tab-size: var(--tab-size-preference); white-space: break-spaces; backg
round-color: var(--bgColor-neutral-muted,var(--color-neutral-muted)); border-radius: 6px; margin: 0px; padding: 0.2em 0.4em;">14f8be4</code></a>) to head (<a href="https://app.codecov.io/gh/apache/texera/commit/b7b3f8440de654510ed22cf9e291c655b0ee7dbb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache" rel="nofollow" style="box-sizing: border-box; background-color: rgba(0, 0, 0, 0); color: var(--fgColor-accent,var(--color-accent-fg)); text-decoration: underline; text-underline-offset: 0.2rem;"><code class="notranslate" style="box-sizing: border-box; font-family: var(--fontStack-monospace,ui-monospace, SFMono-Regular, SF Mono, Menlo, Consolas, Liberation Mono, monospace); font-size: 11.9px; tab-size: var(--tab-size-preference); white-space: break-spaces; background-color: var(--bgColor-neutral-muted,var(--color-neutral-muted)); border-radius: 6px; margin: 0px; padding: 0.2em 0.4em;">b7b3
f84</code></a>).</p><markdown-accessiblity-table data-catalyst="" style="box-sizing: border-box; display: block;">
Files with missing lines | Patch % | Lines
-- | -- | --
...ala/org/apache/texera/amber/util/IcebergUtil.scala | 0.00% | 3 Missing ⚠️
</markdown-accessiblity-table><details style="box-sizing: border-box; display: block; margin-top: 0px; margin-bottom: var(--base-size-16);"></span><br class="Apple-interchange-newline">❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.75%. Comparing base ([14f8be4](https://app.codecov.io/gh/apache/texera/commit/14f8be4c0856dd9f0be2aa594bdfe46a92f9d4cd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([b7b3f84](https://app.codecov.io/gh/apache/texera/commit/b7b3f8440de654510ed22cf9e291c655b0ee7dbb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
[Files with missing lines](https://app.codecov.io/gh/apache/texera/pull/4988?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Patch % Lines
[...ala/org/apache/texera/amber/util/IcebergUtil.scala](https://app.codecov.io/gh/apache/texera/pull/4988?src=pr&el=tree&filepath=common%2Fworkflow-core%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Ftexera%2Famber%2Futil%2FIcebergUtil.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3dvcmtmbG93LWNvcmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS90ZXhlcmEvYW1iZXIvdXRpbC9JY2ViZXJnVXRpbC5zY2FsYQ==) 0.00% [3 Missing ⚠️](https://app.codecov.io/gh/apache/texera/pull/4988?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(amber): stop hardcoding S3 in REST catalog init [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on code in PR #4988:
URL: https://github.com/apache/texera/pull/4988#discussion_r3253082695
##########
common/workflow-core/src/test/scala/org/apache/texera/amber/util/IcebergUtilSpec.scala:
##########
@@ -298,4 +299,13 @@ class IcebergUtilSpec extends AnyFlatSpec {
assert(IcebergUtil.fromRecord(record, schema) == tuple)
}
+
+ it should "build REST catalog properties without S3 settings" in {
Review Comment:
The test name and content does not match?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(amber): stop hardcoding S3 in REST catalog init [texera]
Posted by "mengw15 (via GitHub)" <gi...@apache.org>.
mengw15 merged PR #4988:
URL: https://github.com/apache/texera/pull/4988
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(amber): stop hardcoding S3 in REST catalog init [texera]
Posted by "mengw15 (via GitHub)" <gi...@apache.org>.
mengw15 commented on PR #4988:
URL: https://github.com/apache/texera/pull/4988#issuecomment-4410775482
> Thanks @mengw15 can you make the description a bit concise about why this change is needed? Also please add tests to confirm this change works.
Thanks for the questions.
Why the change is needed. When a Lakekeeper warehouse is created, the S3 settings (endpoint, region, credentials, path-style, etc.) are already registered against that warehouse on the server side. At REST-catalog init the client only needs the warehouse identifier and uri — Lakekeeper resolves and serves the S3 config from the warehouse record. The previously hardcoded s3.* properties from StorageConfig were therefore redundant on the client; deleting them lets each warehouse own its own storage settings instead of all warehouses being forced onto the system bucket. I'll tighten the PR description to say just this.
About tests. End-to-end verification needs a running Lakekeeper, which CI doesn't have yet. #4276 (draft) adds Lakekeeper to CI; once that lands I'll layer an integration test on top of it that creates a warehouse with its own S3 settings, opens a REST catalog with only warehouse + uri, and round-trips a table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(amber): stop hardcoding S3 in REST catalog init [texera]
Posted by "mengw15 (via GitHub)" <gi...@apache.org>.
mengw15 commented on PR #4988:
URL: https://github.com/apache/texera/pull/4988#issuecomment-4423948574
> > These two tests are testing the createRestCatalog in Scala and python. so this PR is covered end-to-end. With CI passed, I think we can confirm that this change works.
>
> sg. thanks! let's also make sure the coverage is filled, this can make sure your changes in this PR are actually being tested in the CI.
>
> > ❌ Patch coverage is `0%` with `3 lines` in your changes missing coverage. Please review.✅ Project coverage is 42.75%. Comparing base ([`14f8be4`](https://app.codecov.io/gh/apache/texera/commit/14f8be4c0856dd9f0be2aa594bdfe46a92f9d4cd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b7b3f84`](https://app.codecov.io/gh/apache/texera/commit/b7b3f8440de654510ed22cf9e291c655b0ee7dbb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
>
> Files with missing lines Patch % Lines
> ...ala/org/apache/texera/amber/util/IcebergUtil.scala 0.00% 3 Missing ⚠️
> See more [#4988 (comment)](https://github.com/apache/texera/pull/4988#issuecomment-4409770046)
It seems like the amber-integration job doesn't upload to Codecov. Added a mock unit test in IcebergUtilSpec to satisfy the patch number; it just drives createRestCatalog until .initialize throws (no Lakekeeper in unit-test scope). Real coverage still comes from the integration test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(amber): stop hardcoding S3 in REST catalog init [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #4988:
URL: https://github.com/apache/texera/pull/4988#issuecomment-4418194693
now as #4276 is merged, can we hook up with new tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org