You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/16 10:59:03 UTC
[GitHub] [flink] Godlumen opened a new pull request #11775:
[FLINK-17132][metrics] Use the latest version of simpleclient_pushgateway
to solve the "Failed to push metrics to PushGateway" problem
Godlumen opened a new pull request #11775: [FLINK-17132][metrics] Use the latest version of simpleclient_pushgateway to solve the "Failed to push metrics to PushGateway" problem
URL: https://github.com/apache/flink/pull/11775
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Solve this problem: Use the flink-metrics-prometheus module to report the metric, pushgateway successfully received the data, but Jobmanager and TaskManager will print "Failed to push metrics to PushGateway" and throw "java.io.IOException: Response code from xxx was 200". [https://issues.apache.org/jira/browse/FLINK-17132](FLINK-17132)
## Brief change log
- Upgrade <promutheus.version> from 0.3.0 to 0.8.0 in root pom.xml.
## Verifying this change
This change is already covered by existing tests, such as PrometheusPushGatewayReporterTest&PrometheusReporterTaskScopeTest&PrometheusReporterTest.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): yes
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] Godlumen commented on issue #11775: [FLINK-17132][metrics]
Use the latest version of simpleclient_pushgateway to solve the "Failed to
push metrics to PushGateway" problem
Posted by GitBox <gi...@apache.org>.
Godlumen commented on issue #11775: [FLINK-17132][metrics] Use the latest version of simpleclient_pushgateway to solve the "Failed to push metrics to PushGateway" problem
URL: https://github.com/apache/flink/pull/11775#issuecomment-614596607
> We could go straight for 8.0.1 .
>
> Have you verified the functionality with an actual prometheus (pushgateway) deployment?
Yes, i have verified.
Would you tell me why CLI Report shows UNKOWN on above？Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol merged pull request #11775: [FLINK-17132][metrics]
Use the latest version of simpleclient_pushgateway to solve the "Failed to
push metrics to PushGateway" problem
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #11775: [FLINK-17132][metrics] Use the latest version of simpleclient_pushgateway to solve the "Failed to push metrics to PushGateway" problem
URL: https://github.com/apache/flink/pull/11775
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11775:
[FLINK-17132][metrics] Use the latest version of simpleclient_pushgateway
to solve the "Failed to push metrics to PushGateway" problem
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11775: [FLINK-17132][metrics] Use the latest version of simpleclient_pushgateway to solve the "Failed to push metrics to PushGateway" problem
URL: https://github.com/apache/flink/pull/11775#issuecomment-614586674
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "37957c26db1ac46c4a562caa775a50bc21564d69",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7592",
"triggerID" : "37957c26db1ac46c4a562caa775a50bc21564d69",
"triggerType" : "PUSH"
}, {
"hash" : "37957c26db1ac46c4a562caa775a50bc21564d69",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160535306",
"triggerID" : "37957c26db1ac46c4a562caa775a50bc21564d69",
"triggerType" : "PUSH"
}, {
"hash" : "5178c66b32381b67a41cb2a4e36a7498f241502c",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7598",
"triggerID" : "5178c66b32381b67a41cb2a4e36a7498f241502c",
"triggerType" : "PUSH"
}, {
"hash" : "5178c66b32381b67a41cb2a4e36a7498f241502c",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160543598",
"triggerID" : "5178c66b32381b67a41cb2a4e36a7498f241502c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 37957c26db1ac46c4a562caa775a50bc21564d69 Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/160535306) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7592)
* 5178c66b32381b67a41cb2a4e36a7498f241502c Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160543598) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7598)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] Godlumen removed a comment on issue #11775:
[FLINK-17132][metrics] Use the latest version of simpleclient_pushgateway
to solve the "Failed to push metrics to PushGateway" problem
Posted by GitBox <gi...@apache.org>.
Godlumen removed a comment on issue #11775: [FLINK-17132][metrics] Use the latest version of simpleclient_pushgateway to solve the "Failed to push metrics to PushGateway" problem
URL: https://github.com/apache/flink/pull/11775#issuecomment-614593022
> We could go straight for 8.0.1 .
>
> Have you verified the functionality with an actual prometheus (pushgateway) deployment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] Godlumen opened a new pull request #11775:
[FLINK-17132][metrics] Use the latest version of simpleclient_pushgateway
to solve the "Failed to push metrics to PushGateway" problem
Posted by GitBox <gi...@apache.org>.
Godlumen opened a new pull request #11775: [FLINK-17132][metrics] Use the latest version of simpleclient_pushgateway to solve the "Failed to push metrics to PushGateway" problem
URL: https://github.com/apache/flink/pull/11775
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Solve this problem: Use the flink-metrics-prometheus module to report the metric, pushgateway successfully received the data, but Jobmanager and TaskManager will print "Failed to push metrics to PushGateway" and throw "java.io.IOException: Response code from xxx was 200". [FLINK-17132](https://issues.apache.org/jira/browse/FLINK-17132)
## Brief change log
- Upgrade <prometheus.version> from 0.3.0 to 0.8.0 in root pom.xml.
## Verifying this change
This change is already covered by existing tests, such as PrometheusPushGatewayReporterTest&PrometheusReporterTaskScopeTest&PrometheusReporterTest.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): yes
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on issue #11775: [FLINK-17132][metrics]
Use the latest version of simpleclient_pushgateway to solve the "Failed to
push metrics to PushGateway" problem
Posted by GitBox <gi...@apache.org>.
zentol commented on issue #11775: [FLINK-17132][metrics] Use the latest version of simpleclient_pushgateway to solve the "Failed to push metrics to PushGateway" problem
URL: https://github.com/apache/flink/pull/11775#issuecomment-614602903
Because it hasn't picked up the actual build status yet; this is normal shortly after the build was triggered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11775:
[FLINK-17132][metrics] Use the latest version of simpleclient_pushgateway
to solve the "Failed to push metrics to PushGateway" problem
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11775: [FLINK-17132][metrics] Use the latest version of simpleclient_pushgateway to solve the "Failed to push metrics to PushGateway" problem
URL: https://github.com/apache/flink/pull/11775#issuecomment-614586674
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "37957c26db1ac46c4a562caa775a50bc21564d69",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7592",
"triggerID" : "37957c26db1ac46c4a562caa775a50bc21564d69",
"triggerType" : "PUSH"
}, {
"hash" : "37957c26db1ac46c4a562caa775a50bc21564d69",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160535306",
"triggerID" : "37957c26db1ac46c4a562caa775a50bc21564d69",
"triggerType" : "PUSH"
}, {
"hash" : "5178c66b32381b67a41cb2a4e36a7498f241502c",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7598",
"triggerID" : "5178c66b32381b67a41cb2a4e36a7498f241502c",
"triggerType" : "PUSH"
}, {
"hash" : "5178c66b32381b67a41cb2a4e36a7498f241502c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160543598",
"triggerID" : "5178c66b32381b67a41cb2a4e36a7498f241502c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5178c66b32381b67a41cb2a4e36a7498f241502c Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160543598) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7598)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11775:
[FLINK-17132][metrics] Use the latest version of simpleclient_pushgateway
to solve the "Failed to push metrics to PushGateway" problem
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11775: [FLINK-17132][metrics] Use the latest version of simpleclient_pushgateway to solve the "Failed to push metrics to PushGateway" problem
URL: https://github.com/apache/flink/pull/11775#issuecomment-614586674
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "37957c26db1ac46c4a562caa775a50bc21564d69",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7592",
"triggerID" : "37957c26db1ac46c4a562caa775a50bc21564d69",
"triggerType" : "PUSH"
}, {
"hash" : "37957c26db1ac46c4a562caa775a50bc21564d69",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160535306",
"triggerID" : "37957c26db1ac46c4a562caa775a50bc21564d69",
"triggerType" : "PUSH"
}, {
"hash" : "5178c66b32381b67a41cb2a4e36a7498f241502c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7598",
"triggerID" : "5178c66b32381b67a41cb2a4e36a7498f241502c",
"triggerType" : "PUSH"
}, {
"hash" : "5178c66b32381b67a41cb2a4e36a7498f241502c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160543598",
"triggerID" : "5178c66b32381b67a41cb2a4e36a7498f241502c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5178c66b32381b67a41cb2a4e36a7498f241502c Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160543598) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7598)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11775: [FLINK-17132][metrics]
Use the latest version of simpleclient_pushgateway to solve the "Failed to
push metrics to PushGateway" problem
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11775: [FLINK-17132][metrics] Use the latest version of simpleclient_pushgateway to solve the "Failed to push metrics to PushGateway" problem
URL: https://github.com/apache/flink/pull/11775#issuecomment-614586674
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "37957c26db1ac46c4a562caa775a50bc21564d69",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "37957c26db1ac46c4a562caa775a50bc21564d69",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 37957c26db1ac46c4a562caa775a50bc21564d69 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] Godlumen commented on issue #11775: [FLINK-17132][metrics]
Use the latest version of simpleclient_pushgateway to solve the "Failed to
push metrics to PushGateway" problem
Posted by GitBox <gi...@apache.org>.
Godlumen commented on issue #11775: [FLINK-17132][metrics] Use the latest version of simpleclient_pushgateway to solve the "Failed to push metrics to PushGateway" problem
URL: https://github.com/apache/flink/pull/11775#issuecomment-614593022
> We could go straight for 8.0.1 .
>
> Have you verified the functionality with an actual prometheus (pushgateway) deployment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11775:
[FLINK-17132][metrics] Use the latest version of simpleclient_pushgateway
to solve the "Failed to push metrics to PushGateway" problem
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11775: [FLINK-17132][metrics] Use the latest version of simpleclient_pushgateway to solve the "Failed to push metrics to PushGateway" problem
URL: https://github.com/apache/flink/pull/11775#issuecomment-614586674
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "37957c26db1ac46c4a562caa775a50bc21564d69",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7592",
"triggerID" : "37957c26db1ac46c4a562caa775a50bc21564d69",
"triggerType" : "PUSH"
}, {
"hash" : "37957c26db1ac46c4a562caa775a50bc21564d69",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160535306",
"triggerID" : "37957c26db1ac46c4a562caa775a50bc21564d69",
"triggerType" : "PUSH"
}, {
"hash" : "5178c66b32381b67a41cb2a4e36a7498f241502c",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7598",
"triggerID" : "5178c66b32381b67a41cb2a4e36a7498f241502c",
"triggerType" : "PUSH"
}, {
"hash" : "5178c66b32381b67a41cb2a4e36a7498f241502c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160543598",
"triggerID" : "5178c66b32381b67a41cb2a4e36a7498f241502c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5178c66b32381b67a41cb2a4e36a7498f241502c Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160543598) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7598)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11775: [FLINK-17132][metrics]
Use the latest version of simpleclient_pushgateway to solve the "Failed to
push metrics to PushGateway" problem
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11775: [FLINK-17132][metrics] Use the latest version of simpleclient_pushgateway to solve the "Failed to push metrics to PushGateway" problem
URL: https://github.com/apache/flink/pull/11775#issuecomment-614580320
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 37957c26db1ac46c4a562caa775a50bc21564d69 (Thu Apr 16 11:02:38 UTC 2020)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11775:
[FLINK-17132][metrics] Use the latest version of simpleclient_pushgateway
to solve the "Failed to push metrics to PushGateway" problem
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11775: [FLINK-17132][metrics] Use the latest version of simpleclient_pushgateway to solve the "Failed to push metrics to PushGateway" problem
URL: https://github.com/apache/flink/pull/11775#issuecomment-614586674
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "37957c26db1ac46c4a562caa775a50bc21564d69",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7592",
"triggerID" : "37957c26db1ac46c4a562caa775a50bc21564d69",
"triggerType" : "PUSH"
}, {
"hash" : "37957c26db1ac46c4a562caa775a50bc21564d69",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160535306",
"triggerID" : "37957c26db1ac46c4a562caa775a50bc21564d69",
"triggerType" : "PUSH"
}, {
"hash" : "5178c66b32381b67a41cb2a4e36a7498f241502c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5178c66b32381b67a41cb2a4e36a7498f241502c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 37957c26db1ac46c4a562caa775a50bc21564d69 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160535306) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7592)
* 5178c66b32381b67a41cb2a4e36a7498f241502c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11775:
[FLINK-17132][metrics] Use the latest version of simpleclient_pushgateway
to solve the "Failed to push metrics to PushGateway" problem
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11775: [FLINK-17132][metrics] Use the latest version of simpleclient_pushgateway to solve the "Failed to push metrics to PushGateway" problem
URL: https://github.com/apache/flink/pull/11775#issuecomment-614586674
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "37957c26db1ac46c4a562caa775a50bc21564d69",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7592",
"triggerID" : "37957c26db1ac46c4a562caa775a50bc21564d69",
"triggerType" : "PUSH"
}, {
"hash" : "37957c26db1ac46c4a562caa775a50bc21564d69",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160535306",
"triggerID" : "37957c26db1ac46c4a562caa775a50bc21564d69",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 37957c26db1ac46c4a562caa775a50bc21564d69 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160535306) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7592)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] Godlumen closed pull request #11775: [FLINK-17132][metrics]
Use the latest version of simpleclient_pushgateway to solve the "Failed to
push metrics to PushGateway" problem
Posted by GitBox <gi...@apache.org>.
Godlumen closed pull request #11775: [FLINK-17132][metrics] Use the latest version of simpleclient_pushgateway to solve the "Failed to push metrics to PushGateway" problem
URL: https://github.com/apache/flink/pull/11775
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] Godlumen commented on issue #11775: [FLINK-17132][metrics]
Use the latest version of simpleclient_pushgateway to solve the "Failed to
push metrics to PushGateway" problem
Posted by GitBox <gi...@apache.org>.
Godlumen commented on issue #11775: [FLINK-17132][metrics] Use the latest version of simpleclient_pushgateway to solve the "Failed to push metrics to PushGateway" problem
URL: https://github.com/apache/flink/pull/11775#issuecomment-614605517
> Because it hasn't picked up the actual build status yet; this is normal shortly after the build was triggered.
Thanks, i got it.
I have upgraded promethus's version to 0.8.1, and verified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services