[GitHub] [incubator-netbeans] matthiasblaesing opened a new pull request #1208: [NETBEANS-2274] Remove special casing of JComboBox handling in language chooser

[GitBox <gi...@apache.org>]

matthiasblaesing opened a new pull request #1208: [NETBEANS-2274] Remove special casing of JComboBox handling in language chooser
URL: https://github.com/apache/incubator-netbeans/pull/1208
 
 
   In the Options Dialog, the Panel "Fonts & Colors" and there the subpanel
   Syntax Pane relies on undocumented ActionEvent#getModifiers behavior.
   
   The currently choosen language is only updated when:
   
   - the new language is acknowledged with a space/enter keypress
   - or choosen with a left mouse click
   
   Two problems:
   1. The language in the combobox and the currently select language can
      drift apart. (use only cursor keys to change selection)
   2. On Ubuntu Linux (OpenJDK 1.8u191) it was observed, that the
      undocumented behaviour, the action handler relied on, was not
      present.
   
   Both problems are solved by using the default behaviour of the JComboBox:
   
   Everytime the selection changes and action event is fired, regardless
   of the source of the selection change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists