You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/07/15 10:28:27 UTC

[GitHub] [hudi] codope commented on pull request #5954: [HUDI-4303] Use Hive sentinel value as partition default to avoid casting err

codope commented on PR #5954:
URL: https://github.com/apache/hudi/pull/5954#issuecomment-1185409577

   Rebased.
   @xushiyan @nsivabalan This change is an incompatible one. But, it restores to the correct default value that we had in previous [versions](https://github.com/apache/hudi/blob/release-0.9.0/hudi-common/src/main/java/org/apache/hudi/common/util/PartitionPathEncodeUtils.java#L74)
   So, the default value has changed in the past as well. So, it appears that it does not affect users in a critical way. Keeping the default value consistent as Hive is important as Presto, Trino and Spark all use same default partition value. As for incompatibility, I think it would be better to keep this put of upgrade path. Instead we can write a hudi-cli command.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org