You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tv42 (via GitHub)" <gi...@apache.org> on 2024/11/19 05:27:55 UTC
[I] Public API using private types: `Buffer::from_bytes` takes unexported `Bytes` [arrow-rs]
tv42 opened a new issue, #6754:
URL: https://github.com/apache/arrow-rs/issues/6754
**Describe the bug**
https://docs.rs/arrow-buffer/53.2.0/arrow_buffer/buffer/struct.Buffer.html#method.from_bytes
```rust
/// Auxiliary method to create a new Buffer
pub fn from_bytes(bytes: Bytes) -> Self
```
This method is in the public API, but cannot be called.
**Expected behavior**
1. All types used by Public API are public.
2. User can construct a `Buffer` from arbitrary bytes they have
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Public API using private types: `Buffer::from_bytes` takes unexported `Bytes` [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #6754:
URL: https://github.com/apache/arrow-rs/issues/6754#issuecomment-2615471251
`label_issue.py` automatically added labels {'arrow-flight'} from #6939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Public API using private types: `Buffer::from_bytes` takes unexported `Bytes` [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on issue #6754:
URL: https://github.com/apache/arrow-rs/issues/6754#issuecomment-2485089396
We should probbly make from_bytes crate private, agreed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Public API using private types: `Buffer::from_bytes` takes unexported `Bytes` [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #6754: Public API using private types: `Buffer::from_bytes` takes unexported `Bytes`
URL: https://github.com/apache/arrow-rs/issues/6754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Public API using private types: `Buffer::from_bytes` takes unexported `Bytes` [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #6754:
URL: https://github.com/apache/arrow-rs/issues/6754#issuecomment-2615471097
`label_issue.py` automatically added labels {'arrow'} from #6939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Public API using private types: `Buffer::from_bytes` takes unexported `Bytes` [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #6754:
URL: https://github.com/apache/arrow-rs/issues/6754#issuecomment-2615470961
`label_issue.py` automatically added labels {'parquet'} from #6939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Public API using private types: `Buffer::from_bytes` takes unexported `Bytes` [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #6754:
URL: https://github.com/apache/arrow-rs/issues/6754#issuecomment-2571360757
Here is a proposal to fix the problem (deprecate the confusing API and convert to use `From` impls)
- https://github.com/apache/arrow-rs/pull/6939/files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org