You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/04 12:37:30 UTC

[GitHub] [flink] HuangXingBo opened a new pull request, #20156: [FLINK-28355][python][e2e] Clean up python environment after e2e tests

HuangXingBo opened a new pull request, #20156:
URL: https://github.com/apache/flink/pull/20156

   ## What is the purpose of the change
   
   *This pull request will clean up python environment after e2e tests*
   
   
   ## Brief change log
   
     - *Clean up python environment after e2e tests*
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - *Original tests*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] HuangXingBo commented on a diff in pull request #20156: [FLINK-28355][python][e2e] Clean up python environment after e2e tests

Posted by GitBox <gi...@apache.org>.
HuangXingBo commented on code in PR #20156:
URL: https://github.com/apache/flink/pull/20156#discussion_r913327366


##########
flink-python/dev/lint-python.sh:
##########
@@ -854,3 +863,8 @@ pushd "$FLINK_PYTHON_DIR" &> /dev/null
 if [ $skip_checks -eq 0 ]; then
     check_stage
 fi
+
+if [[ ${CLEAN_UP_FLAG} -eq 1 ]]; then
+    rm -rf ${CONDA_HOME}
+    rm -rf ${STAGE_FILE}

Review Comment:
   Yes. Good catch. Although the `.tox` directory is not generated during the `e2e` stage. The .tox folder is generated during the `flink-python` module test stage.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] HuangXingBo commented on pull request #20156: [FLINK-28355][python][e2e] Clean up python environment after e2e tests

Posted by GitBox <gi...@apache.org>.
HuangXingBo commented on PR #20156:
URL: https://github.com/apache/flink/pull/20156#issuecomment-1175691590

   @MartijnVisser I have cherry-pick the patch towards release-1.15 and release-1.14


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser closed pull request #20156: [FLINK-28355][python][e2e] Clean up python environment after e2e tests

Posted by GitBox <gi...@apache.org>.
MartijnVisser closed pull request #20156: [FLINK-28355][python][e2e] Clean up python environment after e2e tests
URL: https://github.com/apache/flink/pull/20156


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser merged pull request #20156: [FLINK-28355][python][e2e] Clean up python environment after e2e tests

Posted by GitBox <gi...@apache.org>.
MartijnVisser merged PR #20156:
URL: https://github.com/apache/flink/pull/20156


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #20156: [FLINK-28355][python][e2e] Clean up python environment after e2e tests

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20156:
URL: https://github.com/apache/flink/pull/20156#issuecomment-1173777534

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "283cc741d2898e420d2c79f28d5dd7de96601e75",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "283cc741d2898e420d2c79f28d5dd7de96601e75",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 283cc741d2898e420d2c79f28d5dd7de96601e75 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on a diff in pull request #20156: [FLINK-28355][python][e2e] Clean up python environment after e2e tests

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on code in PR #20156:
URL: https://github.com/apache/flink/pull/20156#discussion_r913153914


##########
flink-python/dev/lint-python.sh:
##########
@@ -854,3 +863,8 @@ pushd "$FLINK_PYTHON_DIR" &> /dev/null
 if [ $skip_checks -eq 0 ]; then
     check_stage
 fi
+
+if [[ ${CLEAN_UP_FLAG} -eq 1 ]]; then
+    rm -rf ${CONDA_HOME}
+    rm -rf ${STAGE_FILE}

Review Comment:
   Should we also clean up the `flink-python/.tox` folder?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #20156: [FLINK-28355][python][e2e] Clean up python environment after e2e tests

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #20156:
URL: https://github.com/apache/flink/pull/20156#issuecomment-1175322224

   The failing test in CI run https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=37660&view=results was FLINK-26721 which is unrelated to this change. Merging this now.
   
   @HuangXingBo Will you also create the backports towards `release-1.15` and `release-1.14` ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #20156: [FLINK-28355][python][e2e] Clean up python environment after e2e tests

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #20156:
URL: https://github.com/apache/flink/pull/20156#issuecomment-1175312808

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] HuangXingBo commented on a diff in pull request #20156: [FLINK-28355][python][e2e] Clean up python environment after e2e tests

Posted by GitBox <gi...@apache.org>.
HuangXingBo commented on code in PR #20156:
URL: https://github.com/apache/flink/pull/20156#discussion_r913328921


##########
flink-python/dev/lint-python.sh:
##########
@@ -854,3 +863,8 @@ pushd "$FLINK_PYTHON_DIR" &> /dev/null
 if [ $skip_checks -eq 0 ]; then
     check_stage
 fi
+
+if [[ ${CLEAN_UP_FLAG} -eq 1 ]]; then
+    rm -rf ${CONDA_HOME}
+    rm -rf ${STAGE_FILE}

Review Comment:
   It looks like tirggering the tox test in `e2e` stage. I need to correct the script.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org