You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/26 09:41:01 UTC
[GitHub] [doris] yixiutt opened a new pull request, #13690: [feature](compaction) support ordered data non-traverse compaction
yixiutt opened a new pull request, #13690:
URL: https://github.com/apache/doris/pull/13690
This feature mainly handle compaction for ordered data, adding a min_max key for segment and check if rowset are non-overlapping so we can do compaction just move files and modify rowset meta instead of traverse all rows.
The strategy list below:
1. more than half of rowsets are non overlapping.
2. all segments are more than 10M
3. if base compaction, no delete version contains in input_rowsets.
By the way, my test shows that calc min max key does not effect load performance.
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman closed pull request #13690: [feature](compaction) support ordered data non-traverse compaction
Posted by GitBox <gi...@apache.org>.
morningman closed pull request #13690: [feature](compaction) support ordered data non-traverse compaction
URL: https://github.com/apache/doris/pull/13690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13690: [feature](compaction) support ordered data non-traverse compaction
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13690:
URL: https://github.com/apache/doris/pull/13690#issuecomment-1291874039
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 38.53 seconds
load time: 574 seconds
storage size: 17154827484 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221026191453_clickbench_pr_34299.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #13690: [feature](compaction) support ordered data non-traverse compaction
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #13690:
URL: https://github.com/apache/doris/pull/13690#issuecomment-1298232740
Hi @yixiutt , I think this is a breaking change to Doris core feature, so I created a new branch:
https://github.com/apache/doris/tree/compaction_opt for this feature dev.
And I have pushed the PR: opt compaction task producer and quick compaction (#13495) to it.
I will close this PR, and please push this PR to branch `compaction_opt` for testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13690: [feature](compaction) support ordered data non-traverse compaction
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13690:
URL: https://github.com/apache/doris/pull/13690#issuecomment-1292942145
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 38.71 seconds
load time: 598 seconds
storage size: 17154827763 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221027040554_clickbench_pr_34536.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13690: [feature](compaction) support ordered data non-traverse compaction
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13690:
URL: https://github.com/apache/doris/pull/13690#issuecomment-1293377223
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 38.63 seconds
load time: 565 seconds
storage size: 17154711916 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221027192031_clickbench_pr_34776.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org