[GitHub] [pulsar] 315157973 commented on pull request #7688: Expose MessagesImpl

[GitBox <gi...@apache.org>]

315157973 commented on pull request #7688:
URL: https://github.com/apache/pulsar/pull/7688#issuecomment-666887157


   Requirements:
   Receive a batch of messages (BatchA), but only ack some of them (BatchB), and only call one API to ack BatchB
   
   Solution：
   Change the visibility level of the method from protect to public,so that we can ack list of messages by using `acknowledge(Messages<?> messages)`
   
   Suggestion：
   1)Since the internal implementation of the `acknowledge(Messages<?> messages)` method is still a circular ack, merlimat believes that there is no performance improvement.
   2)codelipenghui believes that acknowledge (Messages<?> messages) should not be reused, because Messages has restrictions, and `acknowledge(List<MessageIds> msgIds)` should be added。Although I prefer to use Messages。
   
   Solution2：
   1) add method `acknowledge(List<MessageId> msgIds)`。
   2) add batch individual acknowledgment to `PersistentAcknowledgmentsGroupingTracker`, ack a batch of messages only requires one request instead of circular requests
   
   @merlimat @codelipenghui @sijie 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org