You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by to...@apache.org on 2011/02/01 23:25:27 UTC
svn commit: r1066248 - in /hadoop/common/trunk: CHANGES.txt
src/java/org/apache/hadoop/ipc/ProtocolSignature.java
src/java/org/apache/hadoop/ipc/VersionedProtocol.java
Author: todd
Date: Tue Feb 1 22:25:26 2011
New Revision: 1066248
URL: http://svn.apache.org/viewvc?rev=1066248&view=rev
Log:
HADOOP-7129. Fix typo in method name getProtocolSigature. Contributed by Todd Lipcon.
Modified:
hadoop/common/trunk/CHANGES.txt
hadoop/common/trunk/src/java/org/apache/hadoop/ipc/ProtocolSignature.java
hadoop/common/trunk/src/java/org/apache/hadoop/ipc/VersionedProtocol.java
Modified: hadoop/common/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/CHANGES.txt?rev=1066248&r1=1066247&r2=1066248&view=diff
==============================================================================
--- hadoop/common/trunk/CHANGES.txt (original)
+++ hadoop/common/trunk/CHANGES.txt Tue Feb 1 22:25:26 2011
@@ -61,6 +61,8 @@ Trunk (unreleased changes)
HADOOP-6939. Inconsistent lock ordering in
AbstractDelegationTokenSecretManager. (Todd Lipcon via tomwhite)
+ HADOOP-7129. Fix typo in method name getProtocolSigature (todd)
+
Release 0.22.0 - Unreleased
INCOMPATIBLE CHANGES
Modified: hadoop/common/trunk/src/java/org/apache/hadoop/ipc/ProtocolSignature.java
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/src/java/org/apache/hadoop/ipc/ProtocolSignature.java?rev=1066248&r1=1066247&r2=1066248&view=diff
==============================================================================
--- hadoop/common/trunk/src/java/org/apache/hadoop/ipc/ProtocolSignature.java (original)
+++ hadoop/common/trunk/src/java/org/apache/hadoop/ipc/ProtocolSignature.java Tue Feb 1 22:25:26 2011
@@ -225,7 +225,7 @@ public class ProtocolSignature implement
* @throws IOException if any error occurs
*/
@SuppressWarnings("unchecked")
- public static ProtocolSignature getProtocolSigature(VersionedProtocol server,
+ public static ProtocolSignature getProtocolSignature(VersionedProtocol server,
String protocol,
long clientVersion, int clientMethodsHash) throws IOException {
Class<? extends VersionedProtocol> inter;
@@ -238,4 +238,16 @@ public class ProtocolSignature implement
return ProtocolSignature.getProtocolSignature(
clientMethodsHash, serverVersion, inter);
}
-}
\ No newline at end of file
+
+ /**
+ * @deprecated Misspelled method name - to be removed after references
+ * to this typo have been fixed in HDFS and MapRed.
+ */
+ @Deprecated
+ public static ProtocolSignature getProtocolSigature(VersionedProtocol server,
+ String protocol,
+ long clientVersion, int clientMethodsHash) throws IOException {
+ return getProtocolSignature(server, protocol, clientVersion,
+ clientMethodsHash);
+ }
+}
Modified: hadoop/common/trunk/src/java/org/apache/hadoop/ipc/VersionedProtocol.java
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/src/java/org/apache/hadoop/ipc/VersionedProtocol.java?rev=1066248&r1=1066247&r2=1066248&view=diff
==============================================================================
--- hadoop/common/trunk/src/java/org/apache/hadoop/ipc/VersionedProtocol.java (original)
+++ hadoop/common/trunk/src/java/org/apache/hadoop/ipc/VersionedProtocol.java Tue Feb 1 22:25:26 2011
@@ -45,7 +45,7 @@ public interface VersionedProtocol {
* @param clientMethodsHash the hashcode of client protocol methods
* @return the server protocol signature containing its version and
* a list of its supported methods
- * @see ProtocolSignature#getProtocolSigature(VersionedProtocol, String,
+ * @see ProtocolSignature#getProtocolSignature(VersionedProtocol, String,
* long, int) for a default implementation
*/
public ProtocolSignature getProtocolSignature(String protocol,