[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #21193: [Bug](pipeline) do not call cancelPlanFragmentAsync when instance finished

["BiteTheDDDDt (via GitHub)" <gi...@apache.org>]

BiteTheDDDDt commented on code in PR #21193:
URL: https://github.com/apache/doris/pull/21193#discussion_r1243103422


##########
fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java:
##########
@@ -2811,7 +2815,10 @@ public synchronized boolean cancelFragmentInstance(Types.PPlanFragmentCancelReas
                     return false;
                 }
             }
-            this.hasCanceled = true;
+            if (!this.hasCanceled) {

Review Comment:
   if all instance getIsDone is true, hasCanceled will be false



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org