[jira] [Commented] (YETUS-723) Overhaul the docker support for 2018

["Allen Wittenauer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YETUS-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692720#comment-16692720 ] 

Allen Wittenauer commented on YETUS-723:
----------------------------------------


aw-repo-00:

This patch is for my repo since it is highly dependent on several other patches that are still sitting in patch available state here.  Rough change list:  (incompatible changes marked as w/[I])

* [I] Docker version minimum is now 17.xx
* add labels to all of yetus generated images
* [I] move test-patch.sh relative_dir routine to yetuslib yetus_relative_dir  
* parameters passed to docker via a separate file rather than env var via new yetuslib routine
* seed the random number generator
* [I] remove the DOCKERFAIL code. No one uses it and it is very confusing for new people. (implements YETUS-702, should fix YETUS-230 if that's still a problem )
* add support for Docker's --platform option
* add support for pulling a given Docker tag rather than always building from a Dockerfile
* support for Docker-in-Docker and alternative Docker socket files when using DinD
* link to the Dockerfile that was used to build (fixes YETUS-203)
* [I] Remove the hard-coded MAVEN_OPTS and pass MAVEN_OPTS and ANT_OPTS directly via Docker env vars (provides a workaround for YETUS-558 & YETUS-631 by basically punting the problem to maven and ant)
* Rework how the run-specific Docker image is created to use build args (partial implementation of YETUS-650)
* [I] Immediately remove yetus/tp-### images. (Fixes YETUS-454)
* Image removal now always uses the id (fixes YETUS-301).
* Reworked the personality info in the vote table (fixes YETUS-197)
* Moved more Docker-specific code out of test-patch.sh and into docker.sh, where it belongs
* Fixed the double "finished" big_console_header
* Removed the output of creating the run-specific Docker image
* Dropped the run-specific image name from footer because who cares?
* launch-test-patch now loads yetuslib to take advantage of already written code

Todo:
* documentation (of course)

> Overhaul the docker support for 2018
> ------------------------------------
>
>                 Key: YETUS-723
>                 URL: https://issues.apache.org/jira/browse/YETUS-723
>             Project: Yetus
>          Issue Type: Improvement
>          Components: Test Patch
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>            Priority: Major
>             Fix For: 0.9.0
>
>
> Many core parts of the Docker support haven't been touched in 3 years.  Since that time, we have learned many things about how people use Docker with test-patch and Docker itself has added many new features.  It's time to overhaul the basic plug-in to take advantage of everything we've learned.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)