[jira] [Commented] (WHIRR-376) Launching a BYON cluster doesn't produce an instances file.

["Andrei Savu (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WHIRR-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119993#comment-13119993 ] 

Andrei Savu commented on WHIRR-376:
-----------------------------------

+1 the code looks good. I haven't tried to run it because I don't have a local vagrant / virtualbox setup now. 

Nit: You should probably revert the changes made to recipes/nodes-byon.yaml before committing 
                
> Launching a BYON cluster doesn't produce an instances file.
> -----------------------------------------------------------
>
>                 Key: WHIRR-376
>                 URL: https://issues.apache.org/jira/browse/WHIRR-376
>             Project: Whirr
>          Issue Type: Bug
>            Reporter: Karel Vervaeke
>         Attachments: WHIRR-376.patch, WHIRR-376.patch
>
>
> whirr launch-cluster doesn't produce an instances file when running a byon cluster.
> By consequence, whirr run-script and whirr list-cluster doesn't work for byon clusters.
> This isn't a bit problem for testing, but when installing to private hosted nodes it may be more annoying.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira