You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "Aditya Srivastava (Jira)" <ji...@apache.org> on 2021/01/08 11:07:00 UTC

[jira] [Closed] (TINKERPOP-2501) Websocket Connection handleError in javascript gremlin driver emits 'log' event instead of 'error'

     [ https://issues.apache.org/jira/browse/TINKERPOP-2501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aditya Srivastava closed TINKERPOP-2501.
----------------------------------------
    Resolution: Not A Problem

> Websocket Connection handleError in javascript gremlin driver emits 'log' event instead of 'error'
> --------------------------------------------------------------------------------------------------
>
>                 Key: TINKERPOP-2501
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2501
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: javascript
>            Reporter: Aditya Srivastava
>            Priority: Minor
>
> *Description*
> Javascript gremlin module has one weird logging behavior during client connection setup.
> The webSocket error event emits a *handleError* function [https://github.com/apache/tinkerpop/blob/64ec9fbc9e6d368f1a251b25cf7b120ace09298c/gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/connection.js#L155]
> and this function emits the error message under *log* event i.e [https://github.com/apache/tinkerpop/blob/64ec9fbc9e6d368f1a251b25cf7b120ace09298c/gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/connection.js#L235].
> It looks like this was broken recently by [https://github.com/apache/tinkerpop/commit/ab43b03514cf82fa004653c3a0d082e8a744107d] this commit.
> I believe this should ideally be thrown under *error* event. Right now we have to listen to these connection errors under *log* event.
> I'll be happy to raise a pr for this once the bug gets approved by the core team.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)