You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Shahaf <d....@daniel.shahaf.name> on 2021/05/01 15:25:26 UTC
Re: buildbot failure in on svn-backport-conflicts-1.10.x
Nathan Hartman wrote on Thu, 29 Apr 2021 16:18 +00:00:
> On Thu, Apr 29, 2021 at 9:03 AM Daniel Shahaf <d....@daniel.shahaf.name> wrote:
> > The module is provided by the libterm-readkey-perl package. IIRC,
> > that's not part of the default Perl installation.
>
> Thanks. I emailed builds@.
Besides installing the package, we have two other fixes we could try:
- Patch backport.pl to not «use» Term::ReadKey in headless runs. (The
module is used to implement interactive functionality.)
- Have buildbot use tools/dist/detect-conflicting-backports.py instead
of backport.pl. (See tools/dist/README.backport)
Re: buildbot failure in on svn-backport-conflicts-1.10.x
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Nathan Hartman wrote on Mon, 03 May 2021 15:06 +00:00:
> On Sat, May 1, 2021 at 11:25 AM Daniel Shahaf <d....@daniel.shahaf.name> wrote:
> > Besides installing the package, we have two other fixes we could try:
> >
> > - Patch backport.pl to not «use» Term::ReadKey in headless runs. (The
> > module is used to implement interactive functionality.)
> >
> > - Have buildbot use tools/dist/detect-conflicting-backports.py instead
> > of backport.pl. (See tools/dist/README.backport)
>
> Thanks for suggesting these alternate possibilities. If we can't get
> the package installed, one of these may be necessary. (The first seems
> to be the more expedient of the two, though the second might be better
> in the long run.)
Actually, I'd recommend the second. backport.py's implementation is
much cleaner, and more developers speak Python than Perl. The Python
script is covered by backport_tests.py (grep for «run_conflicter»), and
when I last checked, it passed them.
However, whoever does the legwork calls the shots.
Cheers,
Daniel
P.S. Incidentally, it so happens that we're coming up on the 10 years
anniversary of backport.pl. (First commit was on 2011-05-21; cron
job was installed 2012-02-03, when manual merge runs were stable.)
Re: buildbot failure in on svn-backport-conflicts-1.10.x
Posted by Nathan Hartman <ha...@gmail.com>.
On Sat, May 1, 2021 at 11:25 AM Daniel Shahaf <d....@daniel.shahaf.name>
wrote:
>
> Nathan Hartman wrote on Thu, 29 Apr 2021 16:18 +00:00:
> > On Thu, Apr 29, 2021 at 9:03 AM Daniel Shahaf <d....@daniel.shahaf.name>
wrote:
> > > The module is provided by the libterm-readkey-perl package. IIRC,
> > > that's not part of the default Perl installation.
> >
> > Thanks. I emailed builds@.
There hasn't been any response to my message to builds@. Rather than
ping it, I think it might be better to ask Infra to check into the
missing package... I'll do that now.
> Besides installing the package, we have two other fixes we could try:
>
> - Patch backport.pl to not «use» Term::ReadKey in headless runs. (The
> module is used to implement interactive functionality.)
>
> - Have buildbot use tools/dist/detect-conflicting-backports.py instead
> of backport.pl. (See tools/dist/README.backport)
Thanks for suggesting these alternate possibilities. If we can't get
the package installed, one of these may be necessary. (The first seems
to be the more expedient of the two, though the second might be better
in the long run.)
Cheers,
Nathan