You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2019/11/25 03:10:04 UTC

[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue #2949: 4.0.0-RC2 does not support Oracle 12C connection configuration #2911

tristaZero edited a comment on issue #2949: 4.0.0-RC2 does not support Oracle 12C connection configuration #2911
URL: https://github.com/apache/incubator-shardingsphere/pull/2949#issuecomment-557968490
 
 
   @timchan1011 timchan1011 
   Hi, we are sorry to make this PR conflicting. Here are my advices to simply this PR and make it merged into dev branch quickly.
   1. Run `git pull upstream dev` in your Command window.
   2. Fix the conflicting files.
   3. Only modify the bug in `OracleDataSourceMetaData.java`
   4. Review existing unit cases to keep or modify.
   Looking forward to seeing thi PR merged into your DEV branch, my dear contributor.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services