You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/21 19:07:20 UTC
[GitHub] [airflow] mik-laj opened a new issue #13231: One ClientInfo instance in Google provider
mik-laj opened a new issue #13231:
URL: https://github.com/apache/airflow/issues/13231
Hello,
Client info initialization is duplicated in many places.
https://github.com/apache/airflow/blob/349b0811c3022605426ba57d30936240a7c2848a/airflow/providers/google/cloud/_internal_client/secret_manager_client.py#L65
https://github.com/apache/airflow/blob/8c42cf1b00c90f0d7f11b8a3a455381de8e003c5/airflow/providers/google/cloud/log/gcs_task_handler.py#L100
https://github.com/apache/airflow/blob/b40dffa08547b610162f8cacfa75847f3c4ca364/airflow/providers/google/common/hooks/base_google.py#L343
https://github.com/apache/airflow/blob/8c42cf1b00c90f0d7f11b8a3a455381de8e003c5/airflow/providers/google/cloud/log/stackdriver_task_handler.py#L112
It would be great if you could reduce these duplications and use one object created at the module level.
Of course, we must not forget that this change should be backward compatible and that old references displayed deprecation warnings. (GoogleBaseHook.client_info.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on issue #13231: One ClientInfo instance in Google provider
Posted by GitBox <gi...@apache.org>.
pierrejeambrun commented on issue #13231:
URL: https://github.com/apache/airflow/issues/13231#issuecomment-1038270203
Hi @eladkal,
Thank you for pointing this issue.
I would be glad to work on it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on issue #13231: One ClientInfo instance in Google provider
Posted by GitBox <gi...@apache.org>.
pierrejeambrun commented on issue #13231:
URL: https://github.com/apache/airflow/issues/13231#issuecomment-1038270203
Hi @eladkal,
Thank you for pointing this issue.
I would be glad to work on it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #13231: One ClientInfo instance in Google provider
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #13231:
URL: https://github.com/apache/airflow/issues/13231#issuecomment-1038365124
Assigned you @pierrejeambrun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #13231: One ClientInfo instance in Google provider
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #13231:
URL: https://github.com/apache/airflow/issues/13231#issuecomment-839630791
@anand-sivampeta unassigning you due to passed time.
This issue is open for anyone who wants to pick it up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #13231: One ClientInfo instance in Google provider
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #13231:
URL: https://github.com/apache/airflow/issues/13231#issuecomment-1038365124
Assigned you @pierrejeambrun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun edited a comment on issue #13231: One ClientInfo instance in Google provider
Posted by GitBox <gi...@apache.org>.
pierrejeambrun edited a comment on issue #13231:
URL: https://github.com/apache/airflow/issues/13231#issuecomment-1038270203
Hi @eladkal,
Thank you for pointing me to this issue.
I would be glad to work on it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on issue #13231: One ClientInfo instance in Google provider
Posted by GitBox <gi...@apache.org>.
pierrejeambrun commented on issue #13231:
URL: https://github.com/apache/airflow/issues/13231#issuecomment-1039321819
Thank you @potiuk, the first draft of the PR is ready 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun edited a comment on issue #13231: One ClientInfo instance in Google provider
Posted by GitBox <gi...@apache.org>.
pierrejeambrun edited a comment on issue #13231:
URL: https://github.com/apache/airflow/issues/13231#issuecomment-1038270203
Hi @eladkal,
Thank you for pointing me to this issue.
I would be glad to work on it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #13231: One ClientInfo instance in Google provider
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #13231:
URL: https://github.com/apache/airflow/issues/13231#issuecomment-753634062
Feel Free! I assigned you :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #13231: One ClientInfo instance in Google provider
Posted by GitBox <gi...@apache.org>.
potiuk closed issue #13231:
URL: https://github.com/apache/airflow/issues/13231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on issue #13231: One ClientInfo instance in Google provider
Posted by GitBox <gi...@apache.org>.
pierrejeambrun commented on issue #13231:
URL: https://github.com/apache/airflow/issues/13231#issuecomment-1039321819
Thank you @potiuk, the first draft of the PR is ready 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] anand-sivampeta commented on issue #13231: One ClientInfo instance in Google provider
Posted by GitBox <gi...@apache.org>.
anand-sivampeta commented on issue #13231:
URL: https://github.com/apache/airflow/issues/13231#issuecomment-753550213
Hi. This is my first contribution and I'd like to work on this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org