You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/03/04 23:05:36 UTC
[GitHub] [lucene-solr] deanpearce opened a new pull request #2456: SOLR-15216 Fix for Invalid Reference to data.followers in Admin UI
deanpearce opened a new pull request #2456:
URL: https://github.com/apache/lucene-solr/pull/2456
# Description
Minor bug in the Admin UI Angular code introduced when switching to followers terminology, the underlying API for 8.x still refers to them as slave. In master 9.x branch this is resolved as full migration to new terminology is complete, but any future 8.x builds would have this issue.
This bug prevents the Replication UI for Legacy Replication from loading if polling is enabled and there has been a successful run.
# Solution
Changed to use the correct JavaScript attribute.
# Tests
Compiled and ran the UI against my development instance, verified that the UI loads correctly.
# Checklist
Please review the following and check all that apply:
- [X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [X] I have created a Jira issue and added the issue ID to my pull request title.
- [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `master` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] tflobbe commented on pull request #2456: SOLR-15216 Fix for Invalid Reference to data.followers in Admin UI
Posted by GitBox <gi...@apache.org>.
tflobbe commented on pull request #2456:
URL: https://github.com/apache/lucene-solr/pull/2456#issuecomment-791027598
@deanpearce, do you want to add an entry to CHANGES.txt in the 8.9 section?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] deanpearce commented on pull request #2456: SOLR-15216 Fix for Invalid Reference to data.followers in Admin UI
Posted by GitBox <gi...@apache.org>.
deanpearce commented on pull request #2456:
URL: https://github.com/apache/lucene-solr/pull/2456#issuecomment-791980444
Thanks for the reminder, done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] tflobbe merged pull request #2456: SOLR-15216 Fix for Invalid Reference to data.followers in Admin UI
Posted by GitBox <gi...@apache.org>.
tflobbe merged pull request #2456:
URL: https://github.com/apache/lucene-solr/pull/2456
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org