You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@uima.apache.org by sc...@apache.org on 2014/12/17 23:36:31 UTC

svn commit: r1646353 - in /uima/uimaj/trunk/uimaj-core/src: main/java/org/apache/uima/analysis_engine/impl/ main/java/org/apache/uima/cas/impl/ main/java/org/apache/uima/resource/metadata/impl/ test/java/org/apache/uima/cas/impl/ test/java/org/apache/u...

Author: schor
Date: Wed Dec 17 22:36:31 2014
New Revision: 1646353

URL: http://svn.apache.org/r1646353
Log:
no Jira - minor code audit updates - unused imports, empty for loop, unneeded casts

Modified:
    uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/analysis_engine/impl/AggregateAnalysisEngine_impl.java
    uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/cas/impl/CASImpl.java
    uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/resource/metadata/impl/ConfigurationParameterSettings_impl.java
    uima/uimaj/trunk/uimaj-core/src/test/java/org/apache/uima/cas/impl/IndexCorruptionReportingTest.java
    uima/uimaj/trunk/uimaj-core/src/test/java/org/apache/uima/cas/test/IteratorTest.java
    uima/uimaj/trunk/uimaj-core/src/test/java/org/apache/uima/util/impl/ProcessTrace_implTest.java

Modified: uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/analysis_engine/impl/AggregateAnalysisEngine_impl.java
URL: http://svn.apache.org/viewvc/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/analysis_engine/impl/AggregateAnalysisEngine_impl.java?rev=1646353&r1=1646352&r2=1646353&view=diff
==============================================================================
--- uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/analysis_engine/impl/AggregateAnalysisEngine_impl.java (original)
+++ uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/analysis_engine/impl/AggregateAnalysisEngine_impl.java Wed Dec 17 22:36:31 2014
@@ -65,7 +65,6 @@ import org.apache.uima.util.InvalidXMLEx
 import org.apache.uima.util.Level;
 import org.apache.uima.util.Logger;
 import org.apache.uima.util.ProcessTrace;
-import org.apache.uima.util.ProcessTraceEvent;
 import org.apache.uima.util.impl.ProcessTraceEvent_impl;
 
 /**

Modified: uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/cas/impl/CASImpl.java
URL: http://svn.apache.org/viewvc/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/cas/impl/CASImpl.java?rev=1646353&r1=1646352&r2=1646353&view=diff
==============================================================================
--- uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/cas/impl/CASImpl.java (original)
+++ uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/cas/impl/CASImpl.java Wed Dec 17 22:36:31 2014
@@ -1788,10 +1788,10 @@ public class CASImpl extends AbstractCas
         // but we need to run the loop to read over the items in the input stream
         loopStart += loopLen + 1;
         loopLen = fsIndex[loopStart];
-        for (int i = loopStart + 1; i < loopStart + 1 + loopLen; i++) {
+//        for (int i = loopStart + 1; i < loopStart + 1 + loopLen; i++) {
 //          loopIndexRep.removeFS(fsIndex[i]);
 //          loopIndexRep.addFS(fsIndex[i]);
-        }
+//        }
         loopStart += loopLen + 1;
         ((CASImpl) view).updateDocumentAnnotation();
       } else {
@@ -4862,11 +4862,11 @@ public class CASImpl extends AbstractCas
       if (pos >= 0) {
         for (int i = s.size() - 1; i > pos; i--) {
           s.remove(i);
-          ((FSsTobeAddedback)(s.get(i))).addback();
+          s.get(i).addback();
         }
       }      
     }
-    ((FSsTobeAddedback)addbacks).addback();
+    addbacks.addback();
   }
   
   /**

Modified: uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/resource/metadata/impl/ConfigurationParameterSettings_impl.java
URL: http://svn.apache.org/viewvc/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/resource/metadata/impl/ConfigurationParameterSettings_impl.java?rev=1646353&r1=1646352&r2=1646353&view=diff
==============================================================================
--- uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/resource/metadata/impl/ConfigurationParameterSettings_impl.java (original)
+++ uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/resource/metadata/impl/ConfigurationParameterSettings_impl.java Wed Dec 17 22:36:31 2014
@@ -38,7 +38,6 @@ import org.apache.uima.util.XMLizable;
 import org.w3c.dom.Element;
 import org.w3c.dom.Node;
 import org.w3c.dom.NodeList;
-import org.xml.sax.ContentHandler;
 import org.xml.sax.SAXException;
 
 /**

Modified: uima/uimaj/trunk/uimaj-core/src/test/java/org/apache/uima/cas/impl/IndexCorruptionReportingTest.java
URL: http://svn.apache.org/viewvc/uima/uimaj/trunk/uimaj-core/src/test/java/org/apache/uima/cas/impl/IndexCorruptionReportingTest.java?rev=1646353&r1=1646352&r2=1646353&view=diff
==============================================================================
--- uima/uimaj/trunk/uimaj-core/src/test/java/org/apache/uima/cas/impl/IndexCorruptionReportingTest.java (original)
+++ uima/uimaj/trunk/uimaj-core/src/test/java/org/apache/uima/cas/impl/IndexCorruptionReportingTest.java Wed Dec 17 22:36:31 2014
@@ -20,15 +20,12 @@
 package org.apache.uima.cas.impl;
 
 import java.io.File;
-import java.util.Arrays;
 
 import junit.framework.TestCase;
 
 import org.apache.uima.UIMAFramework;
-import org.apache.uima.cas.CASException;
 import org.apache.uima.cas.FSIndex;
 import org.apache.uima.cas.TypeSystem;
-import org.apache.uima.internal.util.IntPointerIterator;
 import org.apache.uima.jcas.JCas;
 import org.apache.uima.jcas.tcas.Annotation;
 import org.apache.uima.resource.metadata.FsIndexDescription;
@@ -45,9 +42,6 @@ public class IndexCorruptionReportingTes
 //    System.setProperty("uima.protect_indices_from_key_updates", "false");
 //    System.setProperty("uima.exception_when_fs_update_corrupts_index", "true");
   }
-
-  static {
-  }
   
   private TypeSystemDescription typeSystemDescription;
   

Modified: uima/uimaj/trunk/uimaj-core/src/test/java/org/apache/uima/cas/test/IteratorTest.java
URL: http://svn.apache.org/viewvc/uima/uimaj/trunk/uimaj-core/src/test/java/org/apache/uima/cas/test/IteratorTest.java?rev=1646353&r1=1646352&r2=1646353&view=diff
==============================================================================
--- uima/uimaj/trunk/uimaj-core/src/test/java/org/apache/uima/cas/test/IteratorTest.java (original)
+++ uima/uimaj/trunk/uimaj-core/src/test/java/org/apache/uima/cas/test/IteratorTest.java Wed Dec 17 22:36:31 2014
@@ -44,7 +44,6 @@ import org.apache.uima.cas.impl.CASImpl;
 import org.apache.uima.cas.text.AnnotationFS;
 import org.apache.uima.internal.util.IntVector;
 import org.apache.uima.jcas.JCas;
-import org.apache.uima.jcas.cas.TOP;
 import org.apache.uima.jcas.tcas.Annotation;
 import org.apache.uima.resource.ResourceInitializationException;
 import org.apache.uima.resource.ResourceSpecifier;

Modified: uima/uimaj/trunk/uimaj-core/src/test/java/org/apache/uima/util/impl/ProcessTrace_implTest.java
URL: http://svn.apache.org/viewvc/uima/uimaj/trunk/uimaj-core/src/test/java/org/apache/uima/util/impl/ProcessTrace_implTest.java?rev=1646353&r1=1646352&r2=1646353&view=diff
==============================================================================
--- uima/uimaj/trunk/uimaj-core/src/test/java/org/apache/uima/util/impl/ProcessTrace_implTest.java (original)
+++ uima/uimaj/trunk/uimaj-core/src/test/java/org/apache/uima/util/impl/ProcessTrace_implTest.java Wed Dec 17 22:36:31 2014
@@ -89,7 +89,7 @@ public class ProcessTrace_implTest exten
     Assert.assertEquals("success", subEvt0.getResultMessage());
     Assert.assertTrue(subEvt0.getSubEvents().isEmpty());
 
-    ProcessTraceEvent evt1 = (ProcessTraceEvent) evts.get(1);
+    ProcessTraceEvent evt1 = evts.get(1);
     Assert.assertEquals("c2", evt1.getComponentName());
     Assert.assertEquals("t1", evt1.getType());
     Assert.assertEquals("testing", evt1.getDescription());