You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "smartboy37597 (via GitHub)" <gi...@apache.org> on 2023/09/22 06:02:27 UTC
[GitHub] [skywalking] smartboy37597 opened a new pull request, #11350: Apply MQE on K8s layer UI-templates
smartboy37597 opened a new pull request, #11350:
URL: https://github.com/apache/skywalking/pull/11350
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes [#10914](https://github.com/apache/skywalking/issues/10914)
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
Here are some UI and e2e test screenshots.
<img width="1476" alt="ui-5" src="https://github.com/apache/skywalking/assets/47653926/72751bd3-0182-4a2c-bdbe-d464f4a77603">
<img width="1485" alt="ui-3" src="https://github.com/apache/skywalking/assets/47653926/5fd653b8-0e32-41ac-85b8-b192a050418f">
<img width="950" alt="k8su1-2" src="https://github.com/apache/skywalking/assets/47653926/ef2ef8b5-5357-46d8-9c8d-fd6997a0b248">
<img width="966" alt="k8s-ui" src="https://github.com/apache/skywalking/assets/47653926/aa628bda-6cc6-4f80-8602-02b03c0899af">
<img width="1107" alt="k8se2e-success" src="https://github.com/apache/skywalking/assets/47653926/8b1b062b-d9db-410e-ad4e-6eeee6fb22a8">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] smartboy37597 commented on a diff in pull request #11350: Apply MQE on K8s layer UI-templates
Posted by "smartboy37597 (via GitHub)" <gi...@apache.org>.
smartboy37597 commented on code in PR #11350:
URL: https://github.com/apache/skywalking/pull/11350#discussion_r1333934285
##########
skywalking-ui:
##########
Review Comment:
It should be a sync error, I will try to solve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] smartboy37597 commented on a diff in pull request #11350: Apply MQE on K8s layer UI-templates
Posted by "smartboy37597 (via GitHub)" <gi...@apache.org>.
smartboy37597 commented on code in PR #11350:
URL: https://github.com/apache/skywalking/pull/11350#discussion_r1335146801
##########
oap-server/server-starter/src/main/resources/ui-initialized-templates/k8s/k8s-cluster.json:
##########
@@ -1,19 +1,3 @@
-/**
Review Comment:
> @smartboy37597 Could you follow up on another PR to remove other existing headers to keep them consistent?
Okey, I'm going to delete all UI headers in a new PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] smartboy37597 commented on pull request #11350: Apply MQE on K8s layer UI-templates
Posted by "smartboy37597 (via GitHub)" <gi...@apache.org>.
smartboy37597 commented on PR #11350:
URL: https://github.com/apache/skywalking/pull/11350#issuecomment-1732522880
> @smartboy37597 We only have OpenFunction and topology related settings pending on the immigration to MQE. Take your time to finish the final step.
Okey, i got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] mrproliu commented on a diff in pull request #11350: Apply MQE on K8s layer UI-templates
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on code in PR #11350:
URL: https://github.com/apache/skywalking/pull/11350#discussion_r1334003943
##########
test/e2e-v2/cases/profiling/ebpf/network/expected/metrics-has-client-value-label.yml:
##########
@@ -0,0 +1,73 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+
+type: TIME_SERIES_VALUES
+results:
+ {{- contains .results }}
+ - metric:
+ labels:
+ - key: _
+ value: "false-http-172.18.0.6:80:50"
Review Comment:
I think it is enough for you to verify that the value of the label is not empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #11350: Apply MQE on K8s layer UI-templates
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #11350:
URL: https://github.com/apache/skywalking/pull/11350#discussion_r1334297419
##########
test/e2e-v2/cases/profiling/ebpf/network/expected/metrics-has-client-value-label.yml:
##########
@@ -0,0 +1,73 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+
+type: TIME_SERIES_VALUES
+results:
+ {{- contains .results }}
+ - metric:
+ labels:
+ - key: _
+ value: "false-http-172.18.0.6:80:50"
Review Comment:
@smartboy37597 I will approve the rerun once you fix the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #11350: Apply MQE on K8s layer UI-templates
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #11350:
URL: https://github.com/apache/skywalking/pull/11350#discussion_r1333957395
##########
test/e2e-v2/cases/profiling/ebpf/network/expected/metrics-has-client-value-label.yml:
##########
@@ -0,0 +1,73 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+
+type: TIME_SERIES_VALUES
+results:
+ {{- contains .results }}
+ - metric:
+ labels:
+ - key: _
+ value: "false-http-172.18.0.6:80:50"
Review Comment:
I feel different KinD would provide different IP pools. So, don't use the specific addresses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] smartboy37597 commented on a diff in pull request #11350: Apply MQE on K8s layer UI-templates
Posted by "smartboy37597 (via GitHub)" <gi...@apache.org>.
smartboy37597 commented on code in PR #11350:
URL: https://github.com/apache/skywalking/pull/11350#discussion_r1333973720
##########
test/e2e-v2/cases/profiling/ebpf/network/expected/metrics-has-client-value-label.yml:
##########
@@ -0,0 +1,73 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+
+type: TIME_SERIES_VALUES
+results:
+ {{- contains .results }}
+ - metric:
+ labels:
+ - key: _
+ value: "false-http-172.18.0.6:80:50"
Review Comment:
`process_relation_client_write_rtt_time_percentile` and `process_relation_client_write_exe_time_percentile`
`process_relation_server_write_rtt_time_percentile` and `process_relation_server_write_exe_time_percentile`
Can the metrics return the same value as `process_relation_http1_request_package_size_percentile` and `process_relation_http1_response_package_size_percentile` is consistent, and I think the label value of `http1` is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 commented on a diff in pull request #11350: Apply MQE on K8s layer UI-templates
Posted by "wankai123 (via GitHub)" <gi...@apache.org>.
wankai123 commented on code in PR #11350:
URL: https://github.com/apache/skywalking/pull/11350#discussion_r1333931468
##########
skywalking-ui:
##########
Review Comment:
It seems an old version. A mistake sync?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #11350: Apply MQE on K8s layer UI-templates
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #11350:
URL: https://github.com/apache/skywalking/pull/11350#discussion_r1333984097
##########
test/e2e-v2/cases/profiling/ebpf/network/expected/metrics-has-client-value-label.yml:
##########
@@ -0,0 +1,73 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+
+type: TIME_SERIES_VALUES
+results:
+ {{- contains .results }}
+ - metric:
+ labels:
+ - key: _
+ value: "false-http-172.18.0.6:80:50"
Review Comment:
How TCP could be as same as HTTP?
This PR should keep a metric to MQE, let's don't introduce more changes in here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] smartboy37597 commented on a diff in pull request #11350: Apply MQE on K8s layer UI-templates
Posted by "smartboy37597 (via GitHub)" <gi...@apache.org>.
smartboy37597 commented on code in PR #11350:
URL: https://github.com/apache/skywalking/pull/11350#discussion_r1334912169
##########
test/e2e-v2/cases/profiling/ebpf/network/expected/metrics-has-client-value-label.yml:
##########
@@ -0,0 +1,73 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+
+type: TIME_SERIES_VALUES
+results:
+ {{- contains .results }}
+ - metric:
+ labels:
+ - key: _
+ value: "false-http-172.18.0.6:80:50"
Review Comment:
I've fixed it and the e2e test are passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] mrproliu commented on a diff in pull request #11350: Apply MQE on K8s layer UI-templates
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on code in PR #11350:
URL: https://github.com/apache/skywalking/pull/11350#discussion_r1335080286
##########
oap-server/server-starter/src/main/resources/ui-initialized-templates/k8s/k8s-cluster.json:
##########
@@ -1,19 +1,3 @@
-/**
Review Comment:
@kezhenxu94 Should we keep the license header in the UI template files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #11350: Apply MQE on K8s layer UI-templates
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #11350:
URL: https://github.com/apache/skywalking/pull/11350#issuecomment-1730884781
ebpf cases have errors. Something is not matched. cc @mrproliu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] smartboy37597 commented on a diff in pull request #11350: Apply MQE on K8s layer UI-templates
Posted by "smartboy37597 (via GitHub)" <gi...@apache.org>.
smartboy37597 commented on code in PR #11350:
URL: https://github.com/apache/skywalking/pull/11350#discussion_r1333974749
##########
skywalking-ui:
##########
Review Comment:
ui is synchronized
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #11350: Apply MQE on K8s layer UI-templates
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #11350:
URL: https://github.com/apache/skywalking/pull/11350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #11350: Apply MQE on K8s layer UI-templates
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #11350:
URL: https://github.com/apache/skywalking/pull/11350#issuecomment-1732232738
I will take care of `Dead Link Checker ` through another PR. It seems some links had been removed from Envoy doc site.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #11350: Apply MQE on K8s layer UI-templates
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #11350:
URL: https://github.com/apache/skywalking/pull/11350#discussion_r1333933271
##########
skywalking-ui:
##########
Review Comment:
I think it should be a mistake. @smartboy37597 Please revert it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] mrproliu commented on a diff in pull request #11350: Apply MQE on K8s layer UI-templates
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on code in PR #11350:
URL: https://github.com/apache/skywalking/pull/11350#discussion_r1333948599
##########
test/e2e-v2/cases/profiling/ebpf/network/expected/metrics-has-client-value-label.yml:
##########
@@ -0,0 +1,73 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+
+type: TIME_SERIES_VALUES
+results:
+ {{- contains .results }}
+ - metric:
+ labels:
+ - key: _
+ value: "false-http-172.18.0.6:80:50"
Review Comment:
Does the value of the label look like a dynamic IP?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #11350: Apply MQE on K8s layer UI-templates
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #11350:
URL: https://github.com/apache/skywalking/pull/11350#discussion_r1335085359
##########
oap-server/server-starter/src/main/resources/ui-initialized-templates/k8s/k8s-cluster.json:
##########
@@ -1,19 +1,3 @@
-/**
Review Comment:
@smartboy37597 Could you follow up on another PR to remove other existing headers to keep them consistent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 commented on a diff in pull request #11350: Apply MQE on K8s layer UI-templates
Posted by "wankai123 (via GitHub)" <gi...@apache.org>.
wankai123 commented on code in PR #11350:
URL: https://github.com/apache/skywalking/pull/11350#discussion_r1335085163
##########
oap-server/server-starter/src/main/resources/ui-initialized-templates/k8s/k8s-cluster.json:
##########
@@ -1,19 +1,3 @@
-/**
Review Comment:
I think we no longer need these headers: https://github.com/apache/skywalking/pull/11184#discussion_r1285683989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #11350: Apply MQE on K8s layer UI-templates
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #11350:
URL: https://github.com/apache/skywalking/pull/11350#issuecomment-1732474994
@smartboy37597 We only have OpenFunction and topology related settings pending on the immigration to MQE.
Take your time to finish the final step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org