[GitHub] [druid] gianm commented on a change in pull request #9287: Add getRightEquiConditionKeys to JoinConditionAnalysis

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #9287: Add getRightEquiConditionKeys to JoinConditionAnalysis
URL: https://github.com/apache/druid/pull/9287#discussion_r372777563
 
 

 ##########
 File path: processing/src/test/java/org/apache/druid/segment/join/JoinConditionAnalysisTest.java
 ##########
 @@ -220,6 +229,7 @@ public void test_forExpression_onlyRight()
         ImmutableList.of(),
         exprsToStrings(analysis.getNonEquiConditions())
     );
+    Assert.assertEquals(analysis.getRightEquiConditionKeys(), ImmutableSet.of("x"));
 
 Review comment:
   These are backwards. (I think putting actual before expected is more natural, but JUnit disagrees and who am I to judge?) 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org