You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "xitep (via GitHub)" <gi...@apache.org> on 2025/11/18 13:55:14 UTC
[PR] impl `Spanned` for MERGE statements [datafusion-sqlparser-rs]
xitep opened a new pull request, #2100:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2100
* Provides the span for MERGE statements
* Part of #1548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] impl `Spanned` for MERGE statements [datafusion-sqlparser-rs]
Posted by "iffyio (via GitHub)" <gi...@apache.org>.
iffyio commented on code in PR #2100:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2100#discussion_r2552349625
##########
src/parser/mod.rs:
##########
@@ -17225,66 +17229,84 @@ impl<'a> Parser<'a> {
self.expect_keyword_is(Keyword::THEN)?;
+ macro_rules! not_allowed {
Review Comment:
maybe we can keep this inlined as before, alternative would be to pull it out to a function but that might not be worth it. But in generally we'd ideally avoid custom macros where possible since those are harder to maintain
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] impl `Spanned` for MERGE statements [datafusion-sqlparser-rs]
Posted by "xitep (via GitHub)" <gi...@apache.org>.
xitep commented on code in PR #2100:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2100#discussion_r2552626909
##########
src/parser/mod.rs:
##########
@@ -17225,66 +17229,84 @@ impl<'a> Parser<'a> {
self.expect_keyword_is(Keyword::THEN)?;
+ macro_rules! not_allowed {
Review Comment:
ok, will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] impl `Spanned` for MERGE statements [datafusion-sqlparser-rs]
Posted by "iffyio (via GitHub)" <gi...@apache.org>.
iffyio merged PR #2100:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org