You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "pgaref (via GitHub)" <gi...@apache.org> on 2023/03/13 20:37:21 UTC

[GitHub] [flink] pgaref commented on a diff in pull request #22153: [FLINK-31317] Introduce JobResourceRequirements and JobVertexResourceRequirements data structures.

pgaref commented on code in PR #22153:
URL: https://github.com/apache/flink/pull/22153#discussion_r1134587834


##########
flink-core/src/main/java/org/apache/flink/util/InstantiationUtil.java:
##########
@@ -466,6 +468,7 @@ public static String checkForInstantiationError(Class<?> clazz) {
         }
     }
 
+    @Nullable

Review Comment:
   Minor but would it make sense to introduce the Runtime annotation in a separate ticket as it is used in a bunch of places? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org