You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/01/23 03:44:55 UTC
[GitHub] [hudi] nsivabalan opened a new pull request #4670: [HUDI-3262] Fixing utilities and integ test suite bundle to include hudi spark datasources
nsivabalan opened a new pull request #4670:
URL: https://github.com/apache/hudi/pull/4670
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #4670: [HUDI-3262] Fixing utilities and integ test suite bundle to include hudi spark datasources
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4670:
URL: https://github.com/apache/hudi/pull/4670#issuecomment-1019476493
@leesf : fixed the unintended changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4670: [HUDI-3262] Fixing utilities and integ test suite bundle to include hudi spark datasources
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4670:
URL: https://github.com/apache/hudi/pull/4670#issuecomment-1019413978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "64d4c4398d3afc70038b2147cc49be3662c10478",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5437",
"triggerID" : "64d4c4398d3afc70038b2147cc49be3662c10478",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 64d4c4398d3afc70038b2147cc49be3662c10478 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5437)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4670: [HUDI-3262] Fixing utilities and integ test suite bundle to include hudi spark datasources
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4670:
URL: https://github.com/apache/hudi/pull/4670#issuecomment-1019477031
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "64d4c4398d3afc70038b2147cc49be3662c10478",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5437",
"triggerID" : "64d4c4398d3afc70038b2147cc49be3662c10478",
"triggerType" : "PUSH"
}, {
"hash" : "dc908a857f053bb34643d6e631b7d7bf450bde33",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dc908a857f053bb34643d6e631b7d7bf450bde33",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 64d4c4398d3afc70038b2147cc49be3662c10478 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5437)
* dc908a857f053bb34643d6e631b7d7bf450bde33 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4670: [HUDI-3262] Fixing utilities and integ test suite bundle to include hudi spark datasources
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4670:
URL: https://github.com/apache/hudi/pull/4670#issuecomment-1019408083
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "64d4c4398d3afc70038b2147cc49be3662c10478",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "64d4c4398d3afc70038b2147cc49be3662c10478",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 64d4c4398d3afc70038b2147cc49be3662c10478 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4670: [HUDI-3262] Fixing utilities and integ test suite bundle to include hudi spark datasources
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4670:
URL: https://github.com/apache/hudi/pull/4670#issuecomment-1019408083
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "64d4c4398d3afc70038b2147cc49be3662c10478",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "64d4c4398d3afc70038b2147cc49be3662c10478",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 64d4c4398d3afc70038b2147cc49be3662c10478 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4670: [HUDI-3262] Fixing utilities and integ test suite bundle to include hudi spark datasources
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4670:
URL: https://github.com/apache/hudi/pull/4670#issuecomment-1019477031
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "64d4c4398d3afc70038b2147cc49be3662c10478",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5437",
"triggerID" : "64d4c4398d3afc70038b2147cc49be3662c10478",
"triggerType" : "PUSH"
}, {
"hash" : "dc908a857f053bb34643d6e631b7d7bf450bde33",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dc908a857f053bb34643d6e631b7d7bf450bde33",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 64d4c4398d3afc70038b2147cc49be3662c10478 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5437)
* dc908a857f053bb34643d6e631b7d7bf450bde33 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4670: [HUDI-3262] Fixing utilities and integ test suite bundle to include hudi spark datasources
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4670:
URL: https://github.com/apache/hudi/pull/4670#issuecomment-1019408694
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "64d4c4398d3afc70038b2147cc49be3662c10478",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5437",
"triggerID" : "64d4c4398d3afc70038b2147cc49be3662c10478",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 64d4c4398d3afc70038b2147cc49be3662c10478 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5437)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf commented on a change in pull request #4670: [HUDI-3262] Fixing utilities and integ test suite bundle to include hudi spark datasources
Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #4670:
URL: https://github.com/apache/hudi/pull/4670#discussion_r790219576
##########
File path: hudi-spark-datasource/hudi-spark2/src/main/resources/META-INF/services/org.apache.spark.sql.sources.DataSourceRegister
##########
@@ -16,4 +15,4 @@
# limitations under the License.
-org.apache.hudi.Spark2DefaultSource
Review comment:
no need to change this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf commented on a change in pull request #4670: [HUDI-3262] Fixing utilities and integ test suite bundle to include hudi spark datasources
Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #4670:
URL: https://github.com/apache/hudi/pull/4670#discussion_r790240304
##########
File path: hudi-spark-datasource/hudi-spark2/src/main/scala/org/apache/hudi/Spark2DefaultSource.scala
##########
@@ -26,3 +26,4 @@ import org.apache.spark.sql.sources._
class Spark2DefaultSource extends DefaultSource with DataSourceRegister {
override def shortName(): String = "hudi"
}
+
Review comment:
and no need to change this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4670: [HUDI-3262] Fixing utilities and integ test suite bundle to include hudi spark datasources
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4670:
URL: https://github.com/apache/hudi/pull/4670#issuecomment-1019413978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "64d4c4398d3afc70038b2147cc49be3662c10478",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5437",
"triggerID" : "64d4c4398d3afc70038b2147cc49be3662c10478",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 64d4c4398d3afc70038b2147cc49be3662c10478 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5437)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4670: [HUDI-3262] Fixing utilities and integ test suite bundle to include hudi spark datasources
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4670:
URL: https://github.com/apache/hudi/pull/4670#issuecomment-1019477467
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "64d4c4398d3afc70038b2147cc49be3662c10478",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5437",
"triggerID" : "64d4c4398d3afc70038b2147cc49be3662c10478",
"triggerType" : "PUSH"
}, {
"hash" : "dc908a857f053bb34643d6e631b7d7bf450bde33",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5443",
"triggerID" : "dc908a857f053bb34643d6e631b7d7bf450bde33",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 64d4c4398d3afc70038b2147cc49be3662c10478 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5437)
* dc908a857f053bb34643d6e631b7d7bf450bde33 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5443)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #4670: [HUDI-3262] Fixing utilities and integ test suite bundle to include hudi spark datasources
Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #4670:
URL: https://github.com/apache/hudi/pull/4670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4670: [HUDI-3262] Fixing utilities and integ test suite bundle to include hudi spark datasources
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4670:
URL: https://github.com/apache/hudi/pull/4670#issuecomment-1019477467
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "64d4c4398d3afc70038b2147cc49be3662c10478",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5437",
"triggerID" : "64d4c4398d3afc70038b2147cc49be3662c10478",
"triggerType" : "PUSH"
}, {
"hash" : "dc908a857f053bb34643d6e631b7d7bf450bde33",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5443",
"triggerID" : "dc908a857f053bb34643d6e631b7d7bf450bde33",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 64d4c4398d3afc70038b2147cc49be3662c10478 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5437)
* dc908a857f053bb34643d6e631b7d7bf450bde33 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5443)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4670: [HUDI-3262] Fixing utilities and integ test suite bundle to include hudi spark datasources
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4670:
URL: https://github.com/apache/hudi/pull/4670#issuecomment-1019488898
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "64d4c4398d3afc70038b2147cc49be3662c10478",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5437",
"triggerID" : "64d4c4398d3afc70038b2147cc49be3662c10478",
"triggerType" : "PUSH"
}, {
"hash" : "dc908a857f053bb34643d6e631b7d7bf450bde33",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5443",
"triggerID" : "dc908a857f053bb34643d6e631b7d7bf450bde33",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dc908a857f053bb34643d6e631b7d7bf450bde33 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5443)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #4670: [HUDI-3262] Fixing utilities and integ test suite bundle to include hudi spark datasources
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4670:
URL: https://github.com/apache/hudi/pull/4670#issuecomment-1019476577
if you can approve, I can land once CI succeeds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4670: [HUDI-3262] Fixing utilities and integ test suite bundle to include hudi spark datasources
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4670:
URL: https://github.com/apache/hudi/pull/4670#issuecomment-1019408694
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "64d4c4398d3afc70038b2147cc49be3662c10478",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5437",
"triggerID" : "64d4c4398d3afc70038b2147cc49be3662c10478",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 64d4c4398d3afc70038b2147cc49be3662c10478 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5437)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org