[jira] [Commented] (KYLIN-1921) Support Grouping Funtions

["liyang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KYLIN-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401157#comment-15401157 ] 

liyang commented on KYLIN-1921:
-------------------------------

Great patch! Thanks [~sunyerui]!

'KYLIN-1921.2.patch' counts right?  I have it merged into master followed with a minor code format commit. Please review.
https://github.com/apache/kylin/commit/6dad0f3eeee98fde7a592046525f668a39354845

Happy coding!

> Support Grouping Funtions
> -------------------------
>
>                 Key: KYLIN-1921
>                 URL: https://issues.apache.org/jira/browse/KYLIN-1921
>             Project: Kylin
>          Issue Type: New Feature
>          Components: Query Engine
>    Affects Versions: v1.5.4
>            Reporter: Yerui Sun
>            Assignee: Yerui Sun
>         Attachments: KYLIN-1921.2.patch, KYLIN-1921.patch
>
>
> Usually we used 'group by dim1, dim2' to fetch the metrics with every value of dims, and we also want the summary metrics with the dim2 rolled up.
> This case could be resolved by union two query, like:
> {code}
> select dim1, dim2 metric from table group by dim1, dim2
> union all
> select dim1, 'ALL', metric from table group by dim1
> {code}
> Now with the expression cube/rollup/grouping sets in calcite, we can make the query sql more simple and more clearly:
> {code}
> select dim1, case(grouping(dim2) when 1 then 'ALL' else dim2 end), metric
> from table
> group by grouping sets((dim1, dim2), (dim1))
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)