[jira] [Resolved] (COUCHDB-1242) Filtered replication silently converts all query parameters to strings

["Robert Newson (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/COUCHDB-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Newson resolved COUCHDB-1242.
------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.2

Passing non-strings will give a useful 400 Bad Request message rather than silently do the wrong thing.

> Filtered replication silently converts all query parameters to strings
> ----------------------------------------------------------------------
>
>                 Key: COUCHDB-1242
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1242
>             Project: CouchDB
>          Issue Type: Bug
>    Affects Versions: 1.0.2, 1.1
>            Reporter: Robert Newson
>            Assignee: Robert Newson
>             Fix For: 1.2
>
>         Attachments: 0001-throw-400-bad_request-if-any-query_params-value-is-n.patch
>
>
> All filtered query params are silently converted to strings. this causes tests for if (req.query.foo) to evaluate to true even for {"query_params":{"foo":false}} because "false" is true.
> No clean solution exists to fix this as _changes has a GET entry point and request parameters are untyped.
> Suggested fix is to scan the query_params in handle_replicate_req and throw a 400 Bad Request if any value is not a JSON string.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira