You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2017/12/01 01:54:15 UTC

[GitHub] dubeejw commented on a change in pull request #3031: WIP: Return 202 for trigger fire requests

dubeejw commented on a change in pull request #3031: WIP: Return 202 for trigger fire requests
URL: https://github.com/apache/incubator-openwhisk/pull/3031#discussion_r154251897
 
 

 ##########
 File path: core/controller/src/main/scala/whisk/core/controller/Triggers.scala
 ##########
 @@ -205,13 +211,7 @@ trait WhiskTriggersApi extends WhiskCollectionAPI {
             }
           }
 
-          onComplete(saveTriggerActivation) {
 
 Review comment:
   Might want to keep this code block around so the user knows if a failure occurred. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services