You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "ccxxxyy (via GitHub)" <gi...@apache.org> on 2026/03/03 08:45:41 UTC
[PR] Support parsing Doris CREATE STREAMING JOB and CANCEL TASK syntax [shardingsphere]
ccxxxyy opened a new pull request, #38318:
URL: https://github.com/apache/shardingsphere/pull/38318
for https://github.com/apache/shardingsphere/issues/31463
Changes proposed in this pull request:
-
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
- [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support parsing Doris CREATE STREAMING JOB and CANCEL TASK syntax [shardingsphere]
Posted by "ccxxxyy (via GitHub)" <gi...@apache.org>.
ccxxxyy commented on PR #38318:
URL: https://github.com/apache/shardingsphere/pull/38318#issuecomment-3996853727
@terrymanu Hi! Thanks very much for your feedback and corrections. I have fixed the issues accordingly and would appreciate it if you could take a moment to review them. Below is a summary of the changes in this commit:
- Fixed visitCreateStreamingJob at line 543 in `DorisDDLStatementVisitor.java.`
- Added corresponding test cases and assertions in
`src/main/resources/sql/supported/ddl/create-streaming-job.xml`
`src/main/resources/case/ddl/create-streaming-job.xml`
to verify the fix.
Thank you again for your time and kind help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support parsing Doris CREATE STREAMING JOB and CANCEL TASK syntax [shardingsphere]
Posted by "ccxxxyy (via GitHub)" <gi...@apache.org>.
ccxxxyy commented on PR #38318:
URL: https://github.com/apache/shardingsphere/pull/38318#issuecomment-3989608335
Regarding **POSTGRES**, **MYSQL** and **STREAMING**, [Doris ](https://doris.apache.org/docs/4.x/sql-manual/basic-element/reserved-keywords)does not treat them as reserved keywords. Therefore, I have added them to `identifierKeywordsUnambiguous` in `BaseRule.g4`, so that they can be used in places where identifiers are expected.
My reasoning is as follows:
The identifier usage chain is:
tableName → name → identifier
columnName → identifier
and identifier includes identifierKeywordsUnambiguous.
This means that these keywords can be used as identifiers, such as table names, column names, and database names, without requiring quotation marks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support parsing Doris CREATE STREAMING JOB and CANCEL TASK syntax [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #38318:
URL: https://github.com/apache/shardingsphere/pull/38318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org