[GitHub] [calcite] rubenada commented on a change in pull request #2323: [CALCITE-4461] Do not use `Logical` nodes inside Enumerable rules

[GitBox <gi...@apache.org>]

rubenada commented on a change in pull request #2323:
URL: https://github.com/apache/calcite/pull/2323#discussion_r554997402



##########
File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableAggregateRule.java
##########
@@ -44,7 +45,7 @@ protected EnumerableAggregateRule(Config config) {
   }
 
   @Override public @Nullable RelNode convert(RelNode rel) {
-    final LogicalAggregate agg = (LogicalAggregate) rel;
+    final Aggregate agg = (Aggregate) rel;

Review comment:
       I guess if we apply this patch, all related javadocs should be updated too.
   E.g.:
   `Rule to convert a {@link LogicalAggregate} to an {@link EnumerableAggregate}.`
   => should be:
   `Rule to convert an {@link Aggregate} to an {@link EnumerableAggregate}.`
   
   An similarly in the rest of the impacted classes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org