You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/05/26 11:59:10 UTC
[GitHub] [incubator-inlong] haifxu opened a new pull request, #4399: [INLONG-4398][Manager] Fix status display incomplete
haifxu opened a new pull request, #4399:
URL: https://github.com/apache/incubator-inlong/pull/4399
### Title Name: [INLONG-4398][Manager] Fix status display incomplete
Fixes #4398
### Modifications
Add a Gson adapter, when it parses the specified class, it parses `status` as `STATUS (status)`
### Verifying this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] gong commented on pull request #4399: [INLONG-4398][Manager] Fix status display incomplete
Posted by GitBox <gi...@apache.org>.
gong commented on PR #4399:
URL: https://github.com/apache/incubator-inlong/pull/4399#issuecomment-1139539961
please use git rebase master. not use git merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow merged pull request #4399: [INLONG-4398][Manager] Fix status display incomplete
Posted by GitBox <gi...@apache.org>.
healchow merged PR #4399:
URL: https://github.com/apache/incubator-inlong/pull/4399
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] haifxu commented on pull request #4399: [INLONG-4398][Manager] Fix status display incomplete
Posted by GitBox <gi...@apache.org>.
haifxu commented on PR #4399:
URL: https://github.com/apache/incubator-inlong/pull/4399#issuecomment-1143096398
>
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] haifxu closed pull request #4399: [INLONG-4398][Manager] Fix status display incomplete
Posted by GitBox <gi...@apache.org>.
haifxu closed pull request #4399: [INLONG-4398][Manager] Fix status display incomplete
URL: https://github.com/apache/incubator-inlong/pull/4399
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4399: [INLONG-4398][Manager] Fix status display incomplete
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4399:
URL: https://github.com/apache/incubator-inlong/pull/4399#discussion_r887010242
##########
inlong-manager/manager-client-tools/src/main/java/org/apache/inlong/manager/client/cli/util/StatusAdapter.java:
##########
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.client.cli.util;
+
+import com.google.gson.JsonDeserializationContext;
+import com.google.gson.JsonDeserializer;
+import com.google.gson.JsonElement;
+import com.google.gson.JsonParseException;
+import org.apache.inlong.manager.client.api.enums.SimpleGroupStatus;
+
+import java.lang.reflect.Type;
+
+/**
+ * Status adapter.
+ */
+public class StatusAdapter implements JsonDeserializer {
Review Comment:
Currently, it looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4399: [INLONG-4398][Manager] Fix status display incomplete
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4399:
URL: https://github.com/apache/incubator-inlong/pull/4399#discussion_r887009626
##########
inlong-manager/manager-client-tools/src/main/java/org/apache/inlong/manager/client/cli/util/StatusAdapter.java:
##########
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.client.cli.util;
+
+import com.google.gson.JsonDeserializationContext;
+import com.google.gson.JsonDeserializer;
+import com.google.gson.JsonElement;
+import com.google.gson.JsonParseException;
+import org.apache.inlong.manager.client.api.enums.SimpleGroupStatus;
+
+import java.lang.reflect.Type;
+
+/**
+ * Status adapter.
+ */
+public class StatusAdapter implements JsonDeserializer {
Review Comment:
In the future, we need to remove the GSON dependency, because it is not convenient to parse JSON in a custom way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on pull request #4399: [INLONG-4398][Manager] Fix status display incomplete
Posted by GitBox <gi...@apache.org>.
healchow commented on PR #4399:
URL: https://github.com/apache/incubator-inlong/pull/4399#issuecomment-1143835172
In the future, we will remove the gson.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org