You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Brenden Matthews <br...@diddyinc.com> on 2013/06/03 19:59:35 UTC

Review Request: Don't log every single completed task.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11484/
-----------------------------------------------------------

Review request for mesos.


Description
-------

Don't log every single completed task.

On large jobs (with many thousands of tasks) this can generate an
unreasonable number of log messages.


Diffs
-----

  hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java afe401f5265e3d9494af7eace42eec45943184a3 

Diff: https://reviews.apache.org/r/11484/diff/


Testing
-------


Thanks,

Brenden Matthews


Re: Review Request 11484: Don't log every single completed task.

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11484/#review84919
-----------------------------------------------------------


hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java is no longer hosted in our source base. Closing for now

- Niklas Nielsen


On June 3, 2013, 10:59 a.m., Brenden Matthews wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11484/
> -----------------------------------------------------------
> 
> (Updated June 3, 2013, 10:59 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> Don't log every single completed task.
> 
> On large jobs (with many thousands of tasks) this can generate an
> unreasonable number of log messages.
> 
> 
> Diffs
> -----
> 
>   hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java afe401f5265e3d9494af7eace42eec45943184a3 
> 
> Diff: https://reviews.apache.org/r/11484/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brenden Matthews
> 
>


Re: Review Request: Don't log every single completed task.

Posted by Brenden Matthews <br...@diddyinc.com>.

> On June 6, 2013, 4:49 a.m., Vinod Kone wrote:
> > hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java, lines 142-144
> > <https://reviews.apache.org/r/11484/diff/1/?file=297978#file297978line142>
> >
> >     How about changing this to LOG.debug(). That way, if there is something you want to debug, we can turn up the log level.
> >     
> >     Also, as benm mentioned, change this to "Removing completed job..."

I have this updated in later commits.


- Brenden


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11484/#review21509
-----------------------------------------------------------


On June 3, 2013, 5:59 p.m., Brenden Matthews wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11484/
> -----------------------------------------------------------
> 
> (Updated June 3, 2013, 5:59 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Description
> -------
> 
> Don't log every single completed task.
> 
> On large jobs (with many thousands of tasks) this can generate an
> unreasonable number of log messages.
> 
> 
> Diffs
> -----
> 
>   hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java afe401f5265e3d9494af7eace42eec45943184a3 
> 
> Diff: https://reviews.apache.org/r/11484/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brenden Matthews
> 
>


Re: Review Request: Don't log every single completed task.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11484/#review21509
-----------------------------------------------------------

Ship it!



hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java
<https://reviews.apache.org/r/11484/#comment44549>

    How about changing this to LOG.debug(). That way, if there is something you want to debug, we can turn up the log level.
    
    Also, as benm mentioned, change this to "Removing completed job..."


- Vinod Kone


On June 3, 2013, 5:59 p.m., Brenden Matthews wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11484/
> -----------------------------------------------------------
> 
> (Updated June 3, 2013, 5:59 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Description
> -------
> 
> Don't log every single completed task.
> 
> On large jobs (with many thousands of tasks) this can generate an
> unreasonable number of log messages.
> 
> 
> Diffs
> -----
> 
>   hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java afe401f5265e3d9494af7eace42eec45943184a3 
> 
> Diff: https://reviews.apache.org/r/11484/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brenden Matthews
> 
>


Re: Review Request: Don't log every single completed task.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11484/#review21374
-----------------------------------------------------------

Ship it!



hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java
<https://reviews.apache.org/r/11484/#comment44308>

    Thanks! This log line was incorrect anyway, as we no longer deal with the Hadoop tasks directly.


- Ben Mahler


On June 3, 2013, 5:59 p.m., Brenden Matthews wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11484/
> -----------------------------------------------------------
> 
> (Updated June 3, 2013, 5:59 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Description
> -------
> 
> Don't log every single completed task.
> 
> On large jobs (with many thousands of tasks) this can generate an
> unreasonable number of log messages.
> 
> 
> Diffs
> -----
> 
>   hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java afe401f5265e3d9494af7eace42eec45943184a3 
> 
> Diff: https://reviews.apache.org/r/11484/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brenden Matthews
> 
>