You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/03 18:41:27 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #4101: Appease new clippy
alamb opened a new pull request, #4101:
URL: https://github.com/apache/arrow-datafusion/pull/4101
# Which issue does this PR close?
Closes https://github.com/apache/arrow-datafusion/issues/4100
# Rationale for this change
New clippy was released that is more strict
I agree with most of its suggested changes so 👍
# What changes are included in this PR?
Basically just do what clippy says
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4101: Appease new clippy
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4101:
URL: https://github.com/apache/arrow-datafusion/pull/4101#issuecomment-1302615244
Benchmark runs are scheduled for baseline = c9442ce6ecf7efeb238c6c25c0519350d0ba3839 and contender = fc03001797444ae254fcc9e5196d8389fbc7fdcd. fc03001797444ae254fcc9e5196d8389fbc7fdcd is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/7ad810ac2914430b877c31a1b2613179...051777f3d9e147c2afe77514ad8f4a89/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/356308ee9b4045aa8989c60858e007cd...dd0df07e8f1c45b1b8ac211f5d670605/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3f3a9895d2354179a69ce2b8fa09844f...d2d586aa799a41f2a7e5b3c269cc0450/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/fe5d67e9e669491ca86572fb208e8d60...1dd79af3716d4e05891b85fde68ce906/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #4101: Appease new clippy
Posted by GitBox <gi...@apache.org>.
alamb merged PR #4101:
URL: https://github.com/apache/arrow-datafusion/pull/4101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #4101: Appease new clippy
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #4101:
URL: https://github.com/apache/arrow-datafusion/pull/4101#issuecomment-1302532096
I think this is non controversial so I plan to merge it in if/when CI tests pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org