You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by jaredjstewart <gi...@git.apache.org> on 2016/11/22 19:32:44 UTC
[GitHub] incubator-geode pull request #294: Properly close WebDriver for UITests
GitHub user jaredjstewart opened a pull request:
https://github.com/apache/incubator-geode/pull/294
Properly close WebDriver for UITests
- WebDriver gets closed properly so that the UITests don't overwhelm
CI machines with extra processes
- Increase WebDriver element wait time to reduce test flakiness
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaredjstewart/incubator-geode closeWebDriverProperlyForUITests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-geode/pull/294.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #294
----
commit e9c15a3bcdef571e7e039cd751c063ede3c60b45
Author: Jared Stewart <js...@pivotal.io>
Date: 2016-11-22T18:52:52Z
Properly close WebDriver for UITests
- WebDriver gets closed properly so that the UITests don't overwhelm
CI machines with extra processes
- Increase WebDriver element wait time to reduce test flakiness
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #294: Properly close WebDriver for UITests
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-geode/pull/294
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #294: Properly close WebDriver for UITests
Posted by jaredjstewart <gi...@git.apache.org>.
Github user jaredjstewart commented on the issue:
https://github.com/apache/incubator-geode/pull/294
Precheckin started
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #294: Properly close WebDriver for UITests
Posted by jaredjstewart <gi...@git.apache.org>.
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/294#discussion_r90124555
--- Diff: geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/rules/ScreenshotOnFailureRule.java ---
@@ -45,7 +45,9 @@ private void takeScreenshot(String screenshotName) {
if (driver instanceof TakesScreenshot) {
File tempFile = ((TakesScreenshot) driver).getScreenshotAs(OutputType.FILE);
try {
- FileUtils.copyFile(tempFile, new File("build/screenshots/" + screenshotName + ".png"));
+ File screenshot = new File("build/screenshots/" + screenshotName + ".png");
+ FileUtils.copyFile(tempFile, screenshot);
+ System.err.println("Screenshot saved to: " + screenshot.getCanonicalPath());
--- End diff --
This is intentional, it adds some output to help find where the screenshots end up when one gets taken.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #294: Properly close WebDriver for UITests
Posted by jinmeiliao <gi...@git.apache.org>.
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/294#discussion_r89939851
--- Diff: geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/rules/ScreenshotOnFailureRule.java ---
@@ -45,7 +45,9 @@ private void takeScreenshot(String screenshotName) {
if (driver instanceof TakesScreenshot) {
File tempFile = ((TakesScreenshot) driver).getScreenshotAs(OutputType.FILE);
try {
- FileUtils.copyFile(tempFile, new File("build/screenshots/" + screenshotName + ".png"));
+ File screenshot = new File("build/screenshots/" + screenshotName + ".png");
+ FileUtils.copyFile(tempFile, screenshot);
+ System.err.println("Screenshot saved to: " + screenshot.getCanonicalPath());
--- End diff --
Is this an accidental change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---