You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2008/09/17 14:47:11 UTC
[Bug 5979] New: X-Spam-Level contains wrong number of asterisks
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5979
Summary: X-Spam-Level contains wrong number of asterisks
Product: Spamassassin
Version: 3.2.5
Platform: All
OS/Version: Linux
Status: NEW
Severity: normal
Priority: P5
Component: spamassassin
AssignedTo: dev@spamassassin.apache.org
ReportedBy: gb@icsti.su
For spam score like N.0 X-spam-level contains N-1 asterisk. Please see example
- score=9.0, but there are only 8 asterisks.
X-Spam-Level: ********
X-Spam-Status: Yes, score=9.0 required=5.0 tests=BAYES_99,HTML_IMAGE_ONLY_04,
HTML_MESSAGE,INVALID_DATE,RCVD_IN_PBL,RCVD_IN_SORBS_WEB,RDNS_NONE
autolearn=no version=3.2.5
This doesn't happen every time, the following example has everything correct.
Two letters are of the same day
X-Spam-Level: ******************
X-Spam-Status: Yes, score=18.0 required=5.0 tests=BAYES_99,
DATE_IN_FUTURE_96_XX,EXTRA_MPART_TYPE,HTML_IMAGE_ONLY_24,HTML_MESSAGE,
MPART_ALT_DIFF_COUNT,MSGID_OUTLOOK_INVALID,PART_CID_STOCK,PART_CID_STOCK_LESS,
RCVD_IN_PBL,RCVD_IN_XBL,STOCK_IMG_HDR_FROM,STOCK_IMG_HTML,
T_TVD_FW_GRAPHIC_ID1 autolearn=spam version=3.2.5
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 5979] X-Spam-Level contains wrong number of asterisks
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5979
--- Comment #1 from Matt Kettler <mk...@verizon.net> 2008-09-17 06:01:58 PST ---
It's a difference in rounding.
The "score" is rounded to the nearest tenth, so 8.96 = 9.0.
The stars is strictly based on the real first digit, so 8.96 = 8 stars.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 5979] X-Spam-Level contains wrong number of asterisks
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5979
Sidney Markowitz <si...@sidney.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |WONTFIX
--- Comment #5 from Sidney Markowitz <si...@sidney.com> 2008-09-17 08:51:13 PST ---
(in reply to comment #3)
You meant to type 8.981, not 9.981.
Ok, I tracked down what is going on. The first part of the wiki page I linked
to reflects the patch that was accepted for bug 2607, which has the score
rounded down to a tenth, which would have made this score show up as 8.9.
However, right after that checkin came
http://svn.apache.org/viewvc?view=rev&revision=6749
which reverted back to the practice of rounding to the nearest tenth but added
a test so that if the true score is less than the spam threshold change the
diaplayed score to be no more than a tenth less than the spam threshold.
So now 8.981 is rounded in the display to 9.0 unless the spam threshold is 9.0,
in which case it would say X-Spam-Status: No, score=8.9, required=9.0
If that's what we are going to do I think we neef to change the wiki to match.
In any case, here is the rationale for the current behaviour:
The individual rule scores are to three decimal places, but displayed rounded
to the nearest tenth. The total score is the sum of the exact rule scores,
which can be slightly different from the sum of what is displayed. The
displayed total score is rounded to the nearest tenth because that's what
people expect, except that it will never be rounded up to equal the spam
threshold to avoid looking confusing. The stars are always rounded down to an
integer so that you will never see a below-threshold score displaying above the
spam threshold number of stars.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 5979] X-Spam-Level contains wrong number of asterisks
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5979
mikhail timonin <gb...@icsti.su> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |gb@icsti.su
--- Comment #2 from mikhail timonin <gb...@icsti.su> 2008-09-17 06:10:39 PST ---
Matt,
thanks for quick reply.
If you'll have a minute,could you please explain why is it done like that? It
seems more logical to me to use the same rounding rules in both cases.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 5979] X-Spam-Level contains wrong number of asterisks
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5979
--- Comment #4 from mikhail timonin <gb...@icsti.su> 2008-09-17 07:49:03 PST ---
(In reply to comment #3)
Sidney,
we have BAYES_99 redefined to 4.070, so this adds up to 9.981
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 5979] X-Spam-Level contains wrong number of asterisks
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5979
--- Comment #3 from Sidney Markowitz <si...@sidney.com> 2008-09-17 07:11:34 PST ---
(reply to comment #1)
Wasn't that supposed to have been changed to round down to a tenth in 3.0 for
bug 2607, as described in the wiki?
http://wiki.apache.org/spamassassin/RoundingIssues
Also, when I look at the scores in the released 3.2.5 for those rukes, I get an
exact total of 8.411, which should not be displayed as 9.0 anyway.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.