You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/04 04:35:40 UTC
[GitHub] [airflow] thesuperzapper opened a new pull request #9133: Include 'can_failed' in User RBAC
thesuperzapper opened a new pull request #9133:
URL: https://github.com/apache/airflow/pull/9133
This is a simple fix which includes the missing `can_failed` RBAC permission for the `User` role, this omission was clearly a mistake as the `set_failed` RBAC permission is already present in the `User` role.
---
Make sure to mark the boxes below before creating PR: [x]
- [X] Description above provides context of the change
- [X] Unit tests coverage for changes (not needed for documentation changes)
- [X] Target Github ISSUE in description if exists
- [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [X] Relevant documentation is updated including usage instructions.
- [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #9133: Include missing RBAC roles
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #9133:
URL: https://github.com/apache/airflow/pull/9133
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] thesuperzapper commented on pull request #9133: Include missing RBAC roles
Posted by GitBox <gi...@apache.org>.
thesuperzapper commented on pull request #9133:
URL: https://github.com/apache/airflow/pull/9133#issuecomment-641659270
@ashb, I have made the change requested, is this PR now acceptable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] thesuperzapper commented on a change in pull request #9133: Include missing RBAC roles
Posted by GitBox <gi...@apache.org>.
thesuperzapper commented on a change in pull request #9133:
URL: https://github.com/apache/airflow/pull/9133#discussion_r437078140
##########
File path: tests/www/test_views.py
##########
@@ -1983,7 +1983,7 @@ def test_failed_success(self):
past="false",
)
resp = self.client.post('failed', data=form)
- self.check_content_in_response('Redirecting', resp, 302)
+ self.check_content_in_response('Redirecting', resp)
Review comment:
@ashb That test has been broken since it was created (mostly because `can_failure` was missing).
You're probably right, about 'Redirecting' what content does that POST return?
What text should we check for, other tests in that file check for `example_bash_operator` in the response, should this do the same?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #9133: Include missing RBAC roles
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #9133:
URL: https://github.com/apache/airflow/pull/9133#issuecomment-638799613
@thesuperzapper Tests need updating.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] thesuperzapper commented on pull request #9133: Include 'can_failed' in User RBAC
Posted by GitBox <gi...@apache.org>.
thesuperzapper commented on pull request #9133:
URL: https://github.com/apache/airflow/pull/9133#issuecomment-638685394
@potiuk can you review this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #9133: Include missing RBAC roles
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #9133:
URL: https://github.com/apache/airflow/pull/9133#discussion_r435806695
##########
File path: tests/www/test_views.py
##########
@@ -1983,7 +1983,7 @@ def test_failed_success(self):
past="false",
)
resp = self.client.post('failed', data=form)
- self.check_content_in_response('Redirecting', resp, 302)
+ self.check_content_in_response('Redirecting', resp)
Review comment:
This doesn't seem like the right fix. If it's saying "redirecting" but not issuing a 302 something else needs changing here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org