[jira] Commented: (DERBY-3378) Derby's timer thread should have a name that identifies it as belong to a derby instance

["Serge Tsv (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570343#action_12570343 ] 

Serge Tsv commented on DERBY-3378:
----------------------------------

Hello!

It looks like all the created daemon threads are using a common naming convention with a "derby." name prefix. It's possible because all the daemons are created using  a ModuleFactory#getDeamonThread(...) method with a single implementation in BaseMonitor, which actually hardcodes the "derby." prefix.

As for a SingletonTimerFactory, I think the first step could be to hardcode a "derby." prefix and choose some obvious name for a Timer deamon thread. And the next step could be to create a constant for a common thread prefix and probably an utility method which will return a full thread name by a specified name.

I do also think it won't be much effort to refactor existing code to use APIs which provide a common thread-naming scheme, which could be implemented in a final iteration.

I think I could handle the tasks with your approval.

Thanks!

> Derby's timer thread should have a name that identifies it as belong to a derby instance
> ----------------------------------------------------------------------------------------
>
>                 Key: DERBY-3378
>                 URL: https://issues.apache.org/jira/browse/DERBY-3378
>             Project: Derby
>          Issue Type: Improvement
>          Components: Newcomer, Services
>            Reporter: Daniel John Debrunner
>            Priority: Minor
>
> Looking at the threads with jconsole when derby is running shows derby's timer thread as Timer-0.
> All other derby threads are given a name starting with 'derby.', would be useful if the same was true for the timer thread.
> In SingletonTimerFactory just use the Timer constructor that takes a name.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.